From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x229.google.com (mail-oi1-x229.google.com [IPv6:2607:f8b0:4864:20::229]) by sourceware.org (Postfix) with ESMTPS id A44173875450 for ; Sun, 19 Nov 2023 18:30:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A44173875450 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A44173875450 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::229 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700418620; cv=none; b=AX1QxAaD6ZuGdR3pAcG1MLx0gIl1cW2hBS4xlHSoS7o1ivlaeWHnA/w/ozP/c8f8tOMxewl/CiyRvAXQRXKeTwKWc9pK2iv0LxqMhHqYW9MCYKBV1n3u31V9tSLltZYSyYQ5J0qQbUtyjgFZy72jMnkK6OsaXaBIRQjRE3tGICc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700418620; c=relaxed/simple; bh=CUbsJIXnjf192vuHj07XYDUOzERSBvnuR7z2W09jr+Y=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=JsMriazJWz+PhXLYbPkXuSlZrRr8D8w3NaZU1CJvf/Po5FQngH4AJgc0hsSpQmZC5zlzCExVcUgbOLooIGuPTU3SJhRJNUdIcXjck7GiYkDdicbfhGgHXAl50Mhrt2jiKg5xIgCVyB2ohm+3+AHqacEzkXymJRGnJta1iKCwHKM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-oi1-x229.google.com with SMTP id 5614622812f47-3b5ff072fc4so2443394b6e.3 for ; Sun, 19 Nov 2023 10:30:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700418618; x=1701023418; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZzfN+GpCXbK1MiWqKC/AvDlCqZkYZcEy1B0J+bkMITQ=; b=DPyHdjni/QIYLvLSuQGJ9WMH6++B0KOmGOce71baAOIa9VA5wVHyKp0WLNLvJBpCCL YTo4hsbfXMH51R9czmnPUhmMln5sS0gKol/UYEK/IDBj3hdHc3Gygruq1YsYPP6EFSZU XIjwPlEL5f0rSfiITGOC7Fc0l/6kDOvlme/O0mxjoswzB/dZw7qBrvObXafQgO1DUMq6 MmWOwDv12JnIRapQBfcGhmjwW/YdtYdSjRRGYyMnI+hkBxudS0cMCyetyoYOZgDol0RT o3kQffL15dIdAQwWJOy64SbmB4Og675MDeZWNjIzqc7+QMRXfFGbc2fmVOYSlq7BOPF7 E6hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700418618; x=1701023418; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZzfN+GpCXbK1MiWqKC/AvDlCqZkYZcEy1B0J+bkMITQ=; b=BdgkVLv5bfX+/nI5i7qDCV/nB91C4wjCN2gKc/uoAzmud/z49ItM/RXVIoh/Wdw7eS TSS3tPiVkkDCYrbDiiDkHewf90i30FjRilrKY0txP0g4adSAmYzAXd67HcNH/2wZhBt7 nxp+31ZQ0GHIzc4tG3UWlcW31y8B55J3Wot/cMNWHxRBgmCaMs2vauiqFWnohvcAiJVg pXJaBLR+r7BkKcx2+0gdpBubdUC1srpzUx1Erkd51E4wSGiOD5/PnuO2a7A0fcZwH7Z7 bbd5cBJV7n4k3TQMg0koOV4bu6kZvukbyFBQdQKPKPQ1I2KdNhiVA+4yZ3wakbreXwvg zlXg== X-Gm-Message-State: AOJu0Ywc3DLAwrpIvoovtNncJmYjKVk4CIgOp4EBLSivIoDqEIas103N lkQOZUoL8LSOkw2t+0sP5S4= X-Google-Smtp-Source: AGHT+IEQKTSF4NFGTwdyFq9Szx7jxagXkZejoOk6b5jVxhtl4/twfBtf/bYfdcx09JMUM8AxdWJ1FQ== X-Received: by 2002:a05:6808:dc1:b0:3ac:4ee2:337b with SMTP id g1-20020a0568080dc100b003ac4ee2337bmr6300651oic.51.1700418617848; Sun, 19 Nov 2023 10:30:17 -0800 (PST) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id i3-20020a544083000000b003ae31900048sm1019456oii.44.2023.11.19.10.30.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 19 Nov 2023 10:30:17 -0800 (PST) Message-ID: <099bf26c-aed4-4f8a-bf15-4e3f71165dfb@gmail.com> Date: Sun, 19 Nov 2023 11:30:16 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 33/44] RISC-V: Also allow FP conditions in `riscv_expand_conditional_move' Content-Language: en-US To: "Maciej W. Rozycki" , gcc-patches@gcc.gnu.org Cc: Andrew Waterman , Jim Wilson , Kito Cheng , Palmer Dabbelt References: From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE,URIBL_BLACK autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/18/23 22:42, Maciej W. Rozycki wrote: > In `riscv_expand_conditional_move' we only let integer conditions > through at the moment, even though code has already been prepared to > handle floating-point conditions as well. > > Lift this restriction and only bail out if a non-word-mode integer > condition has been requested, as we cannot handle this specific case > owing to machine instruction set restriction. We already take care of > the non-integer, non-floating-point case later on. > > gcc/ > * config/riscv/riscv.cc (riscv_expand_conditional_move): Don't > bail out in floating-point conditions. I probably goof'd something when merging up the eswin, vrull and ventana changes in this space. I recall fixing multiple bugs in handling FP conditional moves when building/testing spec2017 internally -- so this was supposed to be working. OK for the trunk. Jeff