From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-441708-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 69956 invoked by alias); 16 Nov 2016 18:58:48 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 69941 invoked by uid 89); 16 Nov 2016 18:58:46 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-4.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: resqmta-po-04v.sys.comcast.net
Received: from resqmta-po-04v.sys.comcast.net (HELO resqmta-po-04v.sys.comcast.net) (96.114.154.163) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 16 Nov 2016 18:58:36 +0000
Received: from resomta-po-03v.sys.comcast.net ([96.114.154.227])	by resqmta-po-04v.sys.comcast.net with SMTP	id 75P0cmGvJGkXB75PncV6uI; Wed, 16 Nov 2016 18:58:35 +0000
Received: from up.mrs.kithrup.com ([24.4.193.248])	by resomta-po-03v.sys.comcast.net with SMTP	id 75PlcLJFZQEJz75PmcEwi1; Wed, 16 Nov 2016 18:58:35 +0000
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
Subject: Re: [PATCH][GCC/TESTSUITE] Make test for traditional-cpp depend on
From: Mike Stump <mikestump@comcast.net>
In-Reply-To: <VI1PR0801MB2031EFF8BDA470D4DD32360FFFBE0@VI1PR0801MB2031.eurprd08.prod.outlook.com>
Date: Wed, 16 Nov 2016 18:58:00 -0000
Cc: Andreas Schwab <schwab@suse.de>, GCC Patches <gcc-patches@gcc.gnu.org>, "ro@CeBiTec.Uni-Bielefeld.DE" <ro@CeBiTec.Uni-Bielefeld.DE>, nd <nd@arm.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <0A1232F5-4EF7-4213-8DB0-B3F51DEAD439@comcast.net>
References: <VI1PR0801MB2031B2941A1620AC227B4593FFA10@VI1PR0801MB2031.eurprd08.prod.outlook.com> <4B6D15EB-C979-4162-BCF1-EE29C9BCFAAF@comcast.net> <mvm1syb5vyn.fsf@hawking.suse.de> <VI1PR0801MB2031FB3B4E16B06968DDA7C2FFBE0@VI1PR0801MB2031.eurprd08.prod.outlook.com> <VI1PR0801MB2031EFF8BDA470D4DD32360FFFBE0@VI1PR0801MB2031.eurprd08.prod.outlook.com>
To: Tamar Christina <Tamar.Christina@arm.com>
X-CMAE-Envelope: MS4wfPF3SQgampy7XjzNc5eWXu2qAn6KvJ09ciI066s7ts0x/hr9Qa7gBQ3MUF51Fexk0epYbuDXrcBhKfbpWs7lJA/z+lEXbtKUY5V3W2qs4SPv4Dh2Eppn Dj8LFydqVcIy5xAdJEFfwrUxm2w6tD7EtrfYu4Uaa7PK306mkuUNoHY8DpNJaUG3E3Jp0sEfy+3bEckHMobQqZYnZ7AYu1OObPe5EvcvXQDIKBZjF2u6Ivzw Ju7ylS3/ayIykJB+Dq6rwS8zy27ZUKgu2lUuOX/ehLuyKPIuzA74F1C4cnw0F65V
X-IsSubscribed: yes
X-SW-Source: 2016-11/txt/msg01694.txt.bz2

On Nov 16, 2016, at 7:57 AM, Tamar Christina <Tamar.Christina@arm.com> wrot=
e:
>=20
> Forgot to include the committed patch.

>>> This is causing all test names to depend on $srcdir.  A test name
>>> should never include the value of $srcdir.
>>=20
>> Sorry about that, committed a fix as r242500 under the obvious rule.

Yeah, I easily could have approved it as well, so no worries.

The patch is Ok.

The way I usually catch this would be in reviewing the output of ./contrib/=
compare_tests, it would complain about a ton of new tests now not passing, =
which is a dead giveaway.