From: Mike Stump <mikestump@comcast.net>
To: Szabolcs Nagy <szabolcs.nagy@arm.com>
Cc: Torvald Riegel <triegel@redhat.com>,
nd@arm.com, "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH 3/4][PR 71931] Fix libitm tests
Date: Tue, 06 Sep 2016 20:26:00 -0000 [thread overview]
Message-ID: <0AC32150-3245-4A8A-A2E5-05AE3ED09EF1@comcast.net> (raw)
In-Reply-To: <57CF0752.8000505@arm.com>
On Sep 6, 2016, at 11:13 AM, Szabolcs Nagy <szabolcs.nagy@arm.com> wrote:
>
> On 06/09/16 18:34, Mike Stump wrote:
>> On Sep 6, 2016, at 2:11 AM, Torvald Riegel <triegel@redhat.com> wrote:
>>>
>>> On Wed, 2016-08-24 at 20:08 +0100, Szabolcs Nagy wrote:
>>>> Pass build time CC make var down to dejagnu so the sysroot
>>>> is set correctly when gcc is built with --with-build-sysroot.
>>>>
>>>> libitm/
>>>> 2016-08-24 Szabolcs Nagy <szabolcs.nagy@arm.com>
>>>>
>>>> PR testsuite/71931
>>>> * configure.ac: Add AC_CONFIG_FILES.
>>>> * configure: Regenerated.
>>>> * testuite/Makefile.am: Add rule for libitm-test-support.exp.
>>>> * testuite/Makefile.in: Regenerated.
>>>> * testuite/libitm-test-support.exp.in: New.
>>>> * testuite/lib/libitm.exp (libitm_init): Use BUILD_CC.
>>>>
>>>
>>> I don't know enough about the build system to really review this. If a
>>> similar patch has been ACKed and applied for libatomic (71931 states
>>> that both are affected), then I guess this is OK?
>>
>> I was hoping that someone else might review it, but i can see why no one else can or wants to.
>>
>> Sorry for the feet dragging, Ok. If libatomic has the same problem, and a similar solutions works there, Ok to fix it as well.
>>
>
> the libatomic changes were not accepted:
> https://gcc.gnu.org/ml/gcc-patches/2016-08/msg01771.html
>
> i'll try a bit different approach
> (using automake's EXTRA_DEJAGNU_SITE_CONFIG so the
> CC setting is only done in the in-tree site.exp)
Oh, yeah. Sorry, I did see that but didn't mean to ignore the concern raised. Please do work out install v non-install testing before it goes in.
prev parent reply other threads:[~2016-09-06 19:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-24 19:04 [PATCH 0/4][PR 71931] Fix target lib tests --with-build-sysroot Szabolcs Nagy
2016-08-24 19:06 ` [PATCH 1/4][PR 71931] Fix libatomic tests Szabolcs Nagy
2016-08-24 22:08 ` Joseph Myers
2016-08-25 8:45 ` Szabolcs Nagy
2016-08-25 23:04 ` Joseph Myers
2016-08-24 19:07 ` [PATCH 2/4][PR 71931] Fix libgomp tests Szabolcs Nagy
2016-08-24 19:09 ` [PATCH 3/4][PR 71931] Fix libitm tests Szabolcs Nagy
2016-09-06 9:12 ` Torvald Riegel
2016-09-06 18:06 ` Mike Stump
2016-09-06 18:49 ` Szabolcs Nagy
2016-09-06 20:26 ` Mike Stump [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0AC32150-3245-4A8A-A2E5-05AE3ED09EF1@comcast.net \
--to=mikestump@comcast.net \
--cc=gcc-patches@gcc.gnu.org \
--cc=nd@arm.com \
--cc=szabolcs.nagy@arm.com \
--cc=triegel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).