From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 58415 invoked by alias); 6 Sep 2016 19:49:43 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 58396 invoked by uid 89); 6 Sep 2016 19:49:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=states, feet X-HELO: resqmta-po-08v.sys.comcast.net Received: from resqmta-po-08v.sys.comcast.net (HELO resqmta-po-08v.sys.comcast.net) (96.114.154.167) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 06 Sep 2016 19:49:32 +0000 Received: from resomta-po-19v.sys.comcast.net ([96.114.154.243]) by resqmta-po-08v.sys.comcast.net with SMTP id hMMzbOFjZ2dNjhMN9b5lrg; Tue, 06 Sep 2016 19:49:31 +0000 Received: from up.mrs.kithrup.com ([24.4.193.248]) by resomta-po-19v.sys.comcast.net with SMTP id hMN7bM7pQJcrGhMN8beHsQ; Tue, 06 Sep 2016 19:49:31 +0000 Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: [PATCH 3/4][PR 71931] Fix libitm tests From: Mike Stump In-Reply-To: <57CF0752.8000505@arm.com> Date: Tue, 06 Sep 2016 20:26:00 -0000 Cc: Torvald Riegel , nd@arm.com, "gcc-patches@gcc.gnu.org" Content-Transfer-Encoding: quoted-printable Message-Id: <0AC32150-3245-4A8A-A2E5-05AE3ED09EF1@comcast.net> References: <57BDEFC5.4050207@arm.com> <57BDF0BA.5070303@arm.com> <1473153065.20286.30.camel@localhost.localdomain> <51FF09E9-0BA6-4592-A919-4FE1C4982B76@comcast.net> <57CF0752.8000505@arm.com> To: Szabolcs Nagy X-CMAE-Envelope: MS4wfKMY92hwkbVH4V+2tCC75IQ//BAWVhKEFrRbxFPlZU5kGw4cjtYuBOZpmbBivTt3wQlomW0yPiSZgTQXVL2l8Z0QNMtM5yuOLr4CxWutSGyYNIPcztSB ahFIvSJkMb2OVrE032EDuKKZ1aQQIH2WCMeMlr88fTNl7eJz/y8zYJAZcFoHxdf1GE9LJ2LikTFMRWiBw6GOZcaIBX6mD01ImAqw8iZklBA9xsJZoFoR6bHG N5VHVzK991kQPML4BnQ1aMmitvaGluBx7FYQ6LvK/Js= X-IsSubscribed: yes X-SW-Source: 2016-09/txt/msg00336.txt.bz2 On Sep 6, 2016, at 11:13 AM, Szabolcs Nagy wrote: >=20 > On 06/09/16 18:34, Mike Stump wrote: >> On Sep 6, 2016, at 2:11 AM, Torvald Riegel wrote: >>>=20 >>> On Wed, 2016-08-24 at 20:08 +0100, Szabolcs Nagy wrote: >>>> Pass build time CC make var down to dejagnu so the sysroot >>>> is set correctly when gcc is built with --with-build-sysroot. >>>>=20 >>>> libitm/ >>>> 2016-08-24 Szabolcs Nagy >>>>=20 >>>> PR testsuite/71931 >>>> * configure.ac: Add AC_CONFIG_FILES. >>>> * configure: Regenerated. >>>> * testuite/Makefile.am: Add rule for libitm-test-support.exp. >>>> * testuite/Makefile.in: Regenerated. >>>> * testuite/libitm-test-support.exp.in: New. >>>> * testuite/lib/libitm.exp (libitm_init): Use BUILD_CC. >>>>=20 >>>=20 >>> I don't know enough about the build system to really review this. If a >>> similar patch has been ACKed and applied for libatomic (71931 states >>> that both are affected), then I guess this is OK? >>=20 >> I was hoping that someone else might review it, but i can see why no one= else can or wants to. >>=20 >> Sorry for the feet dragging, Ok. If libatomic has the same problem, and= a similar solutions works there, Ok to fix it as well. >>=20 >=20 > the libatomic changes were not accepted: > https://gcc.gnu.org/ml/gcc-patches/2016-08/msg01771.html >=20 > i'll try a bit different approach > (using automake's EXTRA_DEJAGNU_SITE_CONFIG so the > CC setting is only done in the in-tree site.exp) Oh, yeah. Sorry, I did see that but didn't mean to ignore the concern rais= ed. Please do work out install v non-install testing before it goes in.