From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpbg151.qq.com (smtpbg151.qq.com [18.169.211.239]) by sourceware.org (Postfix) with ESMTPS id 674D83858D20 for ; Sun, 12 Nov 2023 12:12:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 674D83858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivai.ai Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivai.ai ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 674D83858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=18.169.211.239 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699791161; cv=none; b=BLn4hrcW3huZxeCwnXBeckhdp4sEGIyvpFHXCxC/Wvnqdh0wc2i8ObDoBaZ8rXLRkSV5TKRZbGssWeVprm9NprXoff7G70a+xpAc8D0EbeKllRX2kaRBUPtWMnvlb1acpTo4x4IGzoNlvgWQ0YqkxTJbn3miulh+fChsbpWXdEQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699791161; c=relaxed/simple; bh=4AhPQgl0RSuM9Q8UQWL7DllhjqYnlFQbMalJnRO/1dM=; h=Message-ID:Date:MIME-Version:Subject:From:To; b=iMLK6guRZMEpOAOK+obJi+csojKZKV1fS//NpAAuckOiEYaJuVNw+AdnDFcSqqQi0Xdoi3ua+n4WLs4S0BZ0Rp83eGHE0ckejZwAUq2wR8c1bEajQNoDFgFUqluLNE/VNsjxlWvpxWWxLRyVZ7itt/ep3f4xUubAQTdJMa574Jo= ARC-Authentication-Results: i=1; server2.sourceware.org X-QQ-mid: bizesmtp72t1699791153t8wjauoz Received: from [10.101.11.9] ( [121.35.182.237]) by bizesmtp.qq.com (ESMTP) with id ; Sun, 12 Nov 2023 20:12:32 +0800 (CST) X-QQ-SSF: 01400000000000C0F000000A0000000 X-QQ-FEAT: ILHsT53NKPi/8KvxSum2FyxewE0a/11i7G9YxIOYCZL98pz+Ls/GYnrcBHLAe YpIcqs5IjOU6LTCiThDFqpuRsakX7UU6QdpJH3mMZ40dtsMvU49hwDhslmEJRKrGD+nOup+ i3c2UhXfEsNDxn7gHlcxsExmuLQGKxuBtTUL0abBbD9VU8XzjKy902NlySJ3CJlBs3cHwIQ UOAhiQYMjMrwbqBQ8mBiiJb+Nea56tiIttEnVNGUgbmxAdOLDRrN5KfgoDO9nv3ox+AtSvB xarhQzAFJSheMnnCk2YPkzo6UyTXQ6r0NBshlk638JexmXP1tHUIRNScx1N6wGBe2Ewg2eN HMVPvCQjrdCUMYi5GApvoR0dHTWv/DdeZbyLNLiAlHgO6syM/aP3FJrN2WA4ixDAxgFiiy9 Z79w6n+F9bk= X-QQ-GoodBg: 2 X-BIZMAIL-ID: 17952417375860006088 Message-ID: <0B3D7F2CF4837AE2+97056941-c2ad-4473-ad24-12a346c18340@rivai.ai> Date: Sun, 12 Nov 2023 20:12:33 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/7] ira/lra: Support subreg coalesce Content-Language: en-US From: Lehua Ding To: Vladimir Makarov , gcc-patches@gcc.gnu.org Cc: richard.sandiford@arm.com, juzhe.zhong@rivai.ai References: <20231108034740.834590-1-lehua.ding@rivai.ai> <2875be42-1bc8-695d-c314-2a28b4605a98@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:rivai.ai:qybglogicsvrgz:qybglogicsvrgz6a-0 X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,BODY_8BITS,FORGED_MUA_MOZILLA,KAM_DMARC_STATUS,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Vladimir, While you're starting your review, please review v3 version that fixes some ICE issues, thanks. https://gcc.gnu.org/pipermail/gcc-patches/2023-November/636178.html On 2023/11/12 20:01, Lehua Ding wrote: > Hi Vladimir, > > On 2023/11/10 4:24, Vladimir Makarov wrote: >> >> On 11/7/23 22:47, Lehua Ding wrote: >>> >>> Lehua Ding (7): >>>    ira: Refactor the handling of register conflicts to make it more >>>      general >>>    ira: Add live_subreg problem and apply to ira pass >>>    ira: Support subreg live range track >>>    ira: Support subreg copy >>>    ira: Add all nregs >= 2 pseudos to tracke subreg list >>>    lra: Apply live_subreg df_problem to lra pass >>>    lra: Support subreg live range track and conflict detect >>> >> Thank you very much for addressing subreg RA.  It is a big work.  I >> wanted to address this long time ago but have no time to do this by >> myself. >> >> I tried to evaluate your patches on x86-64 (i7-9700k) release mode >> GCC. I used -O3 for SPEC2017 compilation. >> >> Here are the results: >> >>                 baseline baseline(+patches) >> specint2017:  8.51 vs 8.58 (+0.8%) >> specfp2017:   21.1 vs 21.1 (+0%) >> compile time: 2426.41s vs 2580.58s (+6.4%) >> >> Spec2017 average code size change: -0.07% >> >> Improving specint by 0.8% is impressive for me. >> >> Unfortunately, it is achieved by decreasing compilation speed by 6.4% >> (although on smaller benchmark I saw only 3% slowdown). I don't know >> how but we should mitigate this speed degradation.  May be we can find >> a hot spot in the new code (but I think it is not a linear search >> pointed by Richard Biener as the object vectors most probably contain >> 1-2 elements) and this code spot can be improved, or we could use this >> only for -O3/fast, or the code can be function or target dependent. >> >> I also find GCC consumes more memory with the patches. May be it can >> be improved too (although I am not sure about this). > > Thanks for the specint performance data. I'll do my best to get the > compile time and memory issues fixed. I'm very curious to know if the > way used to solve the subreg coalesce problem makes sense to you? > >> I'll start to review the patches on the next week.  I don't expect >> that I'll find something serious to reject the patches but again we >> should work on mitigation of the compilation speed problem.  We can >> fill a new PR for this and resolve the problem during the release cycle. > -- Best, Lehua (RiVAI) lehua.ding@rivai.ai