From: Mike Stump <mikestump@comcast.net>
To: Richard Sandiford <richard.sandiford@arm.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] testsuite: Allow general skips/requires in PCH tests
Date: Thu, 26 Oct 2023 08:30:04 -0700 [thread overview]
Message-ID: <0CD47294-336D-4E7F-B6D5-0E3DFE535F6A@comcast.net> (raw)
In-Reply-To: <mpty1fpimv8.fsf@arm.com>
On Oct 26, 2023, at 5:34 AM, Richard Sandiford <richard.sandiford@arm.com> wrote:
> dg-pch.exp handled dg-require-effective-target pch_supported_debug
> as a special case, by grepping the source code. This patch tries
> to generalise it to other dg-require-effective-targets, and to
> dg-skip-if.
>
> There also seemed to be some errors in check-flags. It used:
>
> lappend $args [list <elt>]
>
> which treats the contents of args as a variable name. I think
> it was supposed to be "lappend args" instead. From the later
> code, the element was supposed to be <elt> itself, rather than
> a singleton list containing <elt>.
>
> We can also save some time by doing the common early-exit first.
>
> Doing this removes the need to specify the dg-require-effective-target
> in both files. Tested by faking unsupported debug and checking that
> the tests were still correctly skipped.
>
> Tested on aarch64-linux-gnu. OK to install?
Ok.
prev parent reply other threads:[~2023-10-26 15:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 12:34 Richard Sandiford
2023-10-26 15:30 ` Mike Stump [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0CD47294-336D-4E7F-B6D5-0E3DFE535F6A@comcast.net \
--to=mikestump@comcast.net \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.sandiford@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).