From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=cXfx=GI=comcast.net=mikestump@sourceware.org>
Received: from resqmta-h1p-028593.sys.comcast.net (resqmta-h1p-028593.sys.comcast.net [IPv6:2001:558:fd02:2446::7])
	by sourceware.org (Postfix) with ESMTPS id 6448C3858D37
	for <gcc-patches@gcc.gnu.org>; Thu, 26 Oct 2023 15:30:09 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6448C3858D37
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=comcast.net
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=comcast.net
ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6448C3858D37
Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:558:fd02:2446::7
ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698334210; cv=none;
	b=MJ+UJ1IyOegkinUFWyMsk6jbZpX1aYEi+JBq+OMiQGggdxcMU4z3LfgtKwSr1ciPN74G1oha6mGOCcdCgcZbO/ytpp5iiC0ZIFtxc3/5HRUzPMqpqh8DAQjIZiLb/ji8WGhv/1pTirrUx89MJRoW3/Gq8mRXNbhQ6Cyrg/BNe5U=
ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key;
	t=1698334210; c=relaxed/simple;
	bh=ppAJxGH0734pIaMTzjH14rAr87Y897kHIDCMaAEgcKM=;
	h=DKIM-Signature:Mime-Version:Subject:From:Date:Message-Id:To; b=nYKPSEKzAihWwunvi54umr2o7U+BD3yWLpor7HW2rfT6FP8wjPjooPaJkqlCIIzh3KhOPFCZfMdQjnEz3uhGyteVuGR+nI6KBw+ZV3sdx/Mv9/CITNHiEbQ+AeQuHfS/UZCgT2m2QmH9tOCRXa8pk/IC67PRKoeVvoObnyFZX2I=
ARC-Authentication-Results: i=1; server2.sourceware.org
Received: from resomta-h1p-028509.sys.comcast.net ([96.102.179.194])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 256/256 bits)
	(Client did not present a certificate)
	by resqmta-h1p-028593.sys.comcast.net with ESMTP
	id vysNq8GhNQHtiw2JDq1Wjl; Thu, 26 Oct 2023 15:30:07 +0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net;
	s=20190202a; t=1698334207;
	bh=nDbToshBCmOKsPBIToTeY6XhmR0XMw42fTfuwv1xTQ0=;
	h=Received:Received:Content-Type:Mime-Version:Subject:From:Date:
	 Message-Id:To:Xfinity-Spam-Result;
	b=Fxu96gvMuT7c2Fbe0lTZhfZTGDpp+SGxQqLr6dIirETvOR7Jhi70hXXrqXhSpotkT
	 t7Fc9NL4pSDB5gafqIl+jP+sZqXEUMwNDyXd1Cmsc5i1wvkEJR3g0/SQxz4vh3Asb+
	 UTECkXg1/njMGJ9qdX0KV1uZOOP1ptTfRytfE56qTTq5CGk9LSS3vFV3T0lChYJH6l
	 bgBhqkwkVdqpLdKXLuopXXHmALp10c7VwcQ9oWca1b8kVhXfrP77KTyteayuzjeB2q
	 sUOMeSq+8ZLI0/2+L4/mbs8ih/qGMnZmNMLfYHK+o1EKyfX2f7LLtjKXKO3iaEOa3N
	 6YZEjuly78D/w==
Received: from smtpclient.apple
 ([IPv6:2601:644:907f:7c80:f584:7ec1:fbed:dc91])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 256/256 bits)
	(Client did not present a certificate)
	by resomta-h1p-028509.sys.comcast.net with ESMTPSA
	id w2JAqAkSgiF5bw2JCqitHK; Thu, 26 Oct 2023 15:30:06 +0000
Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.4\))
Subject: Re: [PATCH] testsuite: Allow general skips/requires in PCH tests
From: Mike Stump <mikestump@comcast.net>
In-Reply-To: <mpty1fpimv8.fsf@arm.com>
Date: Thu, 26 Oct 2023 08:30:04 -0700
Cc: gcc-patches@gcc.gnu.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <0CD47294-336D-4E7F-B6D5-0E3DFE535F6A@comcast.net>
References: <mpty1fpimv8.fsf@arm.com>
To: Richard Sandiford <richard.sandiford@arm.com>
X-Mailer: Apple Mail (2.3696.120.41.1.4)
X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

On Oct 26, 2023, at 5:34 AM, Richard Sandiford =
<richard.sandiford@arm.com> wrote:
> dg-pch.exp handled dg-require-effective-target pch_supported_debug
> as a special case, by grepping the source code.  This patch tries
> to generalise it to other dg-require-effective-targets, and to
> dg-skip-if.
>=20
> There also seemed to be some errors in check-flags.  It used:
>=20
>    lappend $args [list <elt>]
>=20
> which treats the contents of args as a variable name.  I think
> it was supposed to be "lappend args" instead.  =46rom the later
> code, the element was supposed to be <elt> itself, rather than
> a singleton list containing <elt>.
>=20
> We can also save some time by doing the common early-exit first.
>=20
> Doing this removes the need to specify the dg-require-effective-target
> in both files.  Tested by faking unsupported debug and checking that
> the tests were still correctly skipped.
>=20
> Tested on aarch64-linux-gnu.  OK to install?

Ok.=