From: "juzhe.zhong@rivai.ai" <juzhe.zhong@rivai.ai>
To: 丁乐华 <lehua.ding@rivai.ai>, gcc-patches <gcc-patches@gcc.gnu.org>
Cc: jeffreyalaw <jeffreyalaw@gmail.com>, pan2.li <pan2.li@intel.com>
Subject: Re: [PATCH V2] RISC-V: Remove duplicate `#include "riscv-vector-switch.def"`
Date: Tue, 13 Jun 2023 18:59:56 +0800 [thread overview]
Message-ID: <0D0074E35140CBB1+2023061318595644772220@rivai.ai> (raw)
In-Reply-To: <20230613105909.820090-1-lehua.ding@rivai.ai>
[-- Attachment #1: Type: text/plain, Size: 1647 bytes --]
LGTM.
Thanks.
Will merge it soon.
juzhe.zhong@rivai.ai
From: Lehua Ding
Date: 2023-06-13 18:59
To: gcc-patches; juzhe.zhong
Subject: [PATCH V2] RISC-V: Remove duplicate `#include "riscv-vector-switch.def"`
Hi,
This patch remove the duplicate `#include "riscv-vector-switch.def"` statement
and add #undef for ENTRY and TUPLE_ENTRY macros later.
Best,
Lehua
gcc/ChangeLog:
* config/riscv/riscv-v.cc (struct mode_vtype_group): Remove duplicate #include.
(ENTRY): Undef.
(TUPLE_ENTRY): Undef.
---
gcc/config/riscv/riscv-v.cc | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/gcc/config/riscv/riscv-v.cc b/gcc/config/riscv/riscv-v.cc
index e1b85a5af91f..09c2abcbc623 100644
--- a/gcc/config/riscv/riscv-v.cc
+++ b/gcc/config/riscv/riscv-v.cc
@@ -1210,7 +1210,6 @@ struct mode_vtype_group
ratio_for_min_vlen64[MODE##mode] = RATIO_FOR_MIN_VLEN64; \
vlmul_for_for_vlen128[MODE##mode] = VLMUL_FOR_MIN_VLEN128; \
ratio_for_for_vlen128[MODE##mode] = RATIO_FOR_MIN_VLEN128;
-#include "riscv-vector-switch.def"
#define TUPLE_ENTRY(MODE, REQUIREMENT, SUBPART_MODE, NF, VLMUL_FOR_MIN_VLEN32, \
RATIO_FOR_MIN_VLEN32, VLMUL_FOR_MIN_VLEN64, \
RATIO_FOR_MIN_VLEN64, VLMUL_FOR_MIN_VLEN128, \
@@ -1224,6 +1223,8 @@ struct mode_vtype_group
vlmul_for_for_vlen128[MODE##mode] = VLMUL_FOR_MIN_VLEN128; \
ratio_for_for_vlen128[MODE##mode] = RATIO_FOR_MIN_VLEN128;
#include "riscv-vector-switch.def"
+#undef ENTRY
+#undef TUPLE_ENTRY
}
};
--
2.36.3
next prev parent reply other threads:[~2023-06-13 11:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-13 10:59 Lehua Ding
2023-06-13 10:59 ` juzhe.zhong [this message]
2023-06-13 11:07 ` Lehua Ding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0D0074E35140CBB1+2023061318595644772220@rivai.ai \
--to=juzhe.zhong@rivai.ai \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=lehua.ding@rivai.ai \
--cc=pan2.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).