From: Mike Stump <mikestump@comcast.net>
To: Tobias Burnus <burnus@net-b.de>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,
gfortran <fortran@gcc.gnu.org>,
Alessandro Fanfarillo <fanfarillo@ing.uniroma2.it>
Subject: Re: [Patch, Fortran + Testsuite] Fix coarray handling in modules
Date: Fri, 02 Jan 2015 20:47:00 -0000 [thread overview]
Message-ID: <0D163B01-6939-4FD4-B7EB-23695CD71538@comcast.net> (raw)
In-Reply-To: <54A680CA.90509@net-b.de>
On Jan 2, 2015, at 3:28 AM, Tobias Burnus <burnus@net-b.de> wrote:
> As found by Alessandro: Statically allocated coarrays in declared in the specification part of a module didn't work (link-time failure). The reason was that the associated coarray token was wrongly mangled and not a public tree.
>
> I additionally propagated the dg-compile-aux-modules support to caf.dg (currently unused).
> OK for the trunk?
So, I usually let the fortran people review and comment on things like this. They do a great job and seems pretty straight forward.
I looked at it and didn’t see anything that was objectionable to me. Seems usual and customary.
next prev parent reply other threads:[~2015-01-02 20:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-02 11:28 Tobias Burnus
2015-01-02 13:14 ` FX
2015-01-02 20:47 ` Mike Stump [this message]
2019-02-28 17:19 ` Thomas Schwinge
2019-03-21 19:34 ` Thomas Schwinge
2015-01-03 10:22 Dominique Dhumieres
2015-01-03 20:50 ` Tobias Burnus
2015-01-03 21:48 ` Dominique d'Humières
2015-01-03 22:30 ` Tobias Burnus
2015-01-03 23:04 ` Dominique d'Humières
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0D163B01-6939-4FD4-B7EB-23695CD71538@comcast.net \
--to=mikestump@comcast.net \
--cc=burnus@net-b.de \
--cc=fanfarillo@ing.uniroma2.it \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).