* [PATCH] MIPS: For micromips allow near-far-3.c test to use the jals instruction to call near_func
@ 2015-07-06 13:20 Andrew Bennett
2015-07-06 13:26 ` Moore, Catherine
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Bennett @ 2015-07-06 13:20 UTC (permalink / raw)
To: gcc-patches
Cc: Matthew Fortune, Moore, Catherine (Catherine_Moore@mentor.com)
Hi,
The near-far-3.c test is failing for micromips because it is expecting the call
to near_func to be performed by a jal instruction, but for micromips this is done
by a jals instruction.
I have updated the expected test output to deal with this case. I have tested
this on the mips-mti-elf target using mips32r2/{-mno-micromips/-mmicromips}
test options and there are no new regressions.
The patch and ChangeLog are below.
Ok to commit?
Many thanks,
Andrew
testsuite/
* gcc.target/mips/near-far-3.c: Allow the call to near_func to use
the jals instruction.
diff --git a/gcc/testsuite/gcc.target/mips/near-far-3.c b/gcc/testsuite/gcc.target/mips/near-far-3.c
index d4d48b1..ea151bc 100644
--- a/gcc/testsuite/gcc.target/mips/near-far-3.c
+++ b/gcc/testsuite/gcc.target/mips/near-far-3.c
@@ -13,5 +13,5 @@ NOMIPS16 int test4 () { return normal_func (); }
/* { dg-final { scan-assembler-not "\tj\tlong_call_func\n" } } */
/* { dg-final { scan-assembler-not "\tj\tfar_func\n" } } */
-/* { dg-final { scan-assembler "\tj(|al)\tnear_func\n" } } */
+/* { dg-final { scan-assembler "\tj(|al|als)\tnear_func\n" } } */
/* { dg-final { scan-assembler-not "\tj\tnormal_func\n" } } */
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] MIPS: For micromips allow near-far-3.c test to use the jals instruction to call near_func
2015-07-06 13:20 [PATCH] MIPS: For micromips allow near-far-3.c test to use the jals instruction to call near_func Andrew Bennett
@ 2015-07-06 13:26 ` Moore, Catherine
2015-07-06 14:17 ` Andrew Bennett
0 siblings, 1 reply; 3+ messages in thread
From: Moore, Catherine @ 2015-07-06 13:26 UTC (permalink / raw)
To: Andrew Bennett, gcc-patches; +Cc: Matthew Fortune
> -----Original Message-----
> From: Andrew Bennett [mailto:Andrew.Bennett@imgtec.com]
> Sent: Monday, July 06, 2015 9:20 AM
> To: gcc-patches@gcc.gnu.org
> Cc: Matthew Fortune; Moore, Catherine
> Subject: [PATCH] MIPS: For micromips allow near-far-3.c test to use the jals
> instruction to call near_func
>
> Hi,
>
> The near-far-3.c test is failing for micromips because it is expecting the call to
> near_func to be performed by a jal instruction, but for micromips this is done
> by a jals instruction.
>
> I have updated the expected test output to deal with this case. I have tested
> this on the mips-mti-elf target using mips32r2/{-mno-micromips/-
> mmicromips}
> test options and there are no new regressions.
>
> The patch and ChangeLog are below.
>
> Ok to commit?
>
> testsuite/
> * gcc.target/mips/near-far-3.c: Allow the call to near_func to use
> the jals instruction.
>
>
OK.
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] MIPS: For micromips allow near-far-3.c test to use the jals instruction to call near_func
2015-07-06 13:26 ` Moore, Catherine
@ 2015-07-06 14:17 ` Andrew Bennett
0 siblings, 0 replies; 3+ messages in thread
From: Andrew Bennett @ 2015-07-06 14:17 UTC (permalink / raw)
To: Moore, Catherine, gcc-patches; +Cc: Matthew Fortune
> OK.
Committed as SVN 225457.
Regards,
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-07-06 14:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-06 13:20 [PATCH] MIPS: For micromips allow near-far-3.c test to use the jals instruction to call near_func Andrew Bennett
2015-07-06 13:26 ` Moore, Catherine
2015-07-06 14:17 ` Andrew Bennett
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).