From: Mike Stump <mikestump@comcast.net>
To: "gcc-patches@gcc.gnu.org Patches" <gcc-patches@gcc.gnu.org>
Subject: fix up hot/cold partitioning on ports that don't have long conditional branches
Date: Fri, 22 Apr 2011 02:54:00 -0000 [thread overview]
Message-ID: <0DF7E8C3-0E32-45F7-AA64-3551505A061A@comcast.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 191 bytes --]
This patch fixes up hot/cold partitioning on ports that don't have long conditional branches. I'll note that the entire file has lots of other jump optimizations that are suspect.
Ok?
[-- Attachment #2: reorg-cold-jumps.diffs.txt --]
[-- Type: text/plain, Size: 2700 bytes --]
2011-04-21 Mike Stump <mikestump@comcast.net>
* reorg.c (relax_delay_slots): Don't delete a jump that crosses a
section boundary.
(follow_jumps): Don't replace a short conditional jump with a
long conditional jump when the port doesn't have long
conditional jumps.
(fill_slots_from_thread): Pass insn to follow_jumps.
(relax_delay_slots): Likewise.
Index: reorg.c
===================================================================
--- reorg.c (revision 1301)
+++ reorg.c (working copy)
@@ -2509,7 +2509,7 @@
since that tells caller to avoid changing the insn. */
static rtx
-follow_jumps (rtx label)
+follow_jumps (rtx label, rtx jump)
{
rtx insn;
rtx next;
@@ -2529,6 +2529,16 @@
{
rtx tem;
+ /* If a label crosses a section boundary and we're thinking
+ about changing a conditional jump to be a conditional jump
+ across that boundary, don't do it if the port doesn't have
+ long conditional branches. We can however jump to the label
+ just before we cross such a boundary. */
+ if (!HAS_LONG_COND_BRANCH
+ && find_reg_note (insn, REG_CROSSING_JUMP, NULL_RTX)
+ && (condjump_p (jump) || condjump_in_parallel_p (jump)))
+ return value;
+
/* If we have found a cycle, make the insn jump to itself. */
if (JUMP_LABEL (insn) == label)
return label;
@@ -2991,7 +3001,7 @@
&& redirect_with_delay_list_safe_p (insn,
JUMP_LABEL (new_thread),
delay_list))
- new_thread = follow_jumps (JUMP_LABEL (new_thread));
+ new_thread = follow_jumps (JUMP_LABEL (new_thread), new_thread);
if (new_thread == 0)
label = find_end_label ();
@@ -3342,12 +3352,13 @@
&& (condjump_p (insn) || condjump_in_parallel_p (insn))
&& (target_label = JUMP_LABEL (insn)) != 0)
{
- target_label = skip_consecutive_labels (follow_jumps (target_label));
+ target_label = skip_consecutive_labels (follow_jumps (target_label, insn));
if (target_label == 0)
target_label = find_end_label ();
if (target_label && next_active_insn (target_label) == next
- && ! condjump_in_parallel_p (insn))
+ && ! condjump_in_parallel_p (insn)
+ && find_reg_note (insn, REG_CROSSING_JUMP, NULL_RTX) == NULL_RTX)
{
delete_jump (insn);
continue;
@@ -3492,7 +3503,7 @@
{
/* If this jump goes to another unconditional jump, thread it, but
don't convert a jump into a RETURN here. */
- trial = skip_consecutive_labels (follow_jumps (target_label));
+ trial = skip_consecutive_labels (follow_jumps (target_label, delay_insn));
if (trial == 0)
trial = find_end_label ();
next reply other threads:[~2011-04-22 1:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-22 2:54 Mike Stump [this message]
2011-04-22 13:23 ` Eric Botcazou
2011-04-22 22:54 ` Mike Stump
2011-04-27 14:56 ` Mike Stump
2011-05-09 10:34 ` Eric Botcazou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0DF7E8C3-0E32-45F7-AA64-3551505A061A@comcast.net \
--to=mikestump@comcast.net \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).