From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by sourceware.org (Postfix) with ESMTPS id EB1C53858014 for ; Fri, 10 Dec 2021 16:15:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EB1C53858014 Received: by mail-wm1-x334.google.com with SMTP id 137so7220212wma.1 for ; Fri, 10 Dec 2021 08:15:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=yCJ3mjMGgd8Q/CcwYKjwrUZbY4NUpA53rOP/ttxd9vE=; b=YJ14J4XsKxoWwcSoI8QdscGsusBvcta2y1wxgdBa6xA10sOEoF2idoOevl7Ll7YAwX 7fzJjAzcdlsGGgCYtE6PC3GEicDl6pBMlTppDp3bQBqBcHOE/OQGV9eaVsc7I+hKNepA mrMVvi3f0ppOzszCEJmUG3GxdHJqpz4WAO8blvwr4182ZGpb29Afm0DhzQBuBwgGed3s se7D1Zq8e3mqde6gHTGS6FFWmaHhhTDnoMK7KG5EU981b5c7eRYp/0jm+CNm4go/A3wW 52hbNeoyPRw+kYH1QGHCW82hQFvNtNZ+JyXOnuire4e3FkeM3kjg9bZpNsGbToQa2tH7 OzTg== X-Gm-Message-State: AOAM532ywJbUOGLfPqim+M8We5o4agxZ9M9k/Jja9E0zfBmiaB+u1Qmb rnPJkEfIYLQlZc3qlmpLcUNd6A== X-Google-Smtp-Source: ABdhPJyQZSbhkdrbchYN9i/1wAxgS80XR/S9TdQpklvLcb5rJefXa6klpGBxNoFE7KGhFHnlLb4JkQ== X-Received: by 2002:a05:600c:4e45:: with SMTP id e5mr17708509wmq.43.1639152952813; Fri, 10 Dec 2021 08:15:52 -0800 (PST) Received: from smtpclient.apple ([2a02:2ab8:224:1:5018:c84a:9614:761d]) by smtp.gmail.com with ESMTPSA id p5sm3229070wrd.13.2021.12.10.08.15.52 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 Dec 2021 08:15:52 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.100.0.2.22\)) Subject: Re: [PATCH] Define _C99 in libstdc++ vxworks/os_defines.h From: Olivier Hainque In-Reply-To: Date: Fri, 10 Dec 2021 17:15:51 +0100 Cc: Olivier Hainque , Rasmus Villemoes , libstdc++ , gcc-patches Content-Transfer-Encoding: 7bit Message-Id: <0FE98CF1-19DE-41A5-9A6D-A54B25D6F29E@adacore.com> References: <3a28a096-3aec-7270-5e7b-9b8a54e4c7b9@prevas.dk> To: Jonathan Wakely X-Mailer: Apple Mail (2.3654.100.0.2.22) X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=unavailable autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Dec 2021 16:15:55 -0000 > On 10 Dec 2021, at 16:42, Jonathan Wakely wrote: > > > OK to commit then, thanks. > > The comment is a bit misleading though: > > +// libstdc++ relies on C99 features for virtually all versions of C++, > +// up to at least C++98. > +#undef _C99 > +#define _C99 1 > > The "up to" seems backwards, I'd expect it to say "down to" or "as far > back as at least C++98". > > But there's nothing older than C++98 anyway, so this just means "all > versions", there's no "virtually" about it. > > Please just say "libstdc++ relies on C99 features for all versions of C++". Sure, thanks Jonathan. Yes, I agree the comment is confused. I hesitated between a couple of perspectives and just mixed things up. Thanks for your prompt review! Olivier