From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com [IPv6:2607:f8b0:4864:20::52f]) by sourceware.org (Postfix) with ESMTPS id 7C23F3955626; Thu, 17 Nov 2022 03:30:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7C23F3955626 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pg1-x52f.google.com with SMTP id o13so817319pgu.7; Wed, 16 Nov 2022 19:30:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2kH2NQ7yMp7p4WJ6cqieYa8h0C+QcEyLycl93GsxG/I=; b=dnV66vL8SMnMPY8Jjch1/cJ7Zo4g6s1o93QoxJrjX/PVYjH2utET+t0rYMrlBzdxUw uvhA5Rh/SUlUUIaEvXlw9ZWgmGf93a29QBnRlqenr+Dm92T506jgtskKNN5/6PQvInD2 /ln1wGffctTt/U8/Is73NJxd+UISty97S8sxbHC6N7fl6UpnDm2KdYuGnsjRUc1LrjGb MQLtVqP+MH89XJTfBel+zc2jL75lyN2T65GgHVeAHeSdV0Ufkpv3vlpR37nC5agIaW5c Hwrc/KbnYnnDefz6x6Q5yo2x3D8LDkJTE072TaCu5DfzJ+r1LQ+9/785aV47Pzh+HM+C vA4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2kH2NQ7yMp7p4WJ6cqieYa8h0C+QcEyLycl93GsxG/I=; b=g9tMpdHaFqlm4MGOFI2InCuSjsVoZZ3r1gpUzOh1Qe6MNlx4BetVZXr9nsiNvbykMd jO4eiTN7sOos3NzHd0Rs/LVOPLt1YfKRO5yV/WgPldEGKovtvT+z1pyY4rhDnvLsH7oI 7k2Y5M5Dy03k6RR3DG7WtVJbB1UFbaEElwTXu3hzmr+qHBFVkepy051/LyeqdZ9T9KKN T1WjVZ/Ib5IUg5fTuQ31G08pIGpUcakhEGWpp8WPtyX3f5T7otdiz/98IKRxw+pOlWVq r9MaRcxWjm7boHnzwaNUwijnf/Q1DZ0hqRgspPwr0NjVn+sp/PgAmcVDhPrccU+4AsN2 fjcg== X-Gm-Message-State: ANoB5pk8FWOUn3XKxH+PL5hxX2Oxqe+5hnZMz53mK9KoNWfcWV7v2sEe 1GSEBLWAASxNUSlvnEwop8U= X-Google-Smtp-Source: AA0mqf5c3NHe+TQuFGSDjPeLG0H3oR9nFkKRPNAzNaMtjg5OrC6stquz6PQ+JySUSCPrDUZyOo/I2w== X-Received: by 2002:a63:1f1f:0:b0:458:6f51:ff7b with SMTP id f31-20020a631f1f000000b004586f51ff7bmr397199pgf.153.1668655826218; Wed, 16 Nov 2022 19:30:26 -0800 (PST) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id k35-20020a17090a14a600b00205d70ccfeesm2379698pja.33.2022.11.16.19.30.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Nov 2022 19:30:25 -0800 (PST) Message-ID: <0a518a16-500e-5535-c298-9aebede74446@gmail.com> Date: Wed, 16 Nov 2022 20:30:23 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH 4/5] value-range: Add as_string diagnostics helper Content-Language: en-US To: Andrew Pinski , Bernhard Reutner-Fischer Cc: gcc-patches@gcc.gnu.org, Bernhard Reutner-Fischer , fortran@gcc.gnu.org, Andrew MacLeod , Aldy Hernandez References: <20221112234543.95441-1-aldot@gcc.gnu.org> <20221112234543.95441-5-aldot@gcc.gnu.org> From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-8.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/12/22 16:55, Andrew Pinski via Gcc-patches wrote: > On Sat, Nov 12, 2022 at 3:47 PM Bernhard Reutner-Fischer via > Gcc-patches wrote: >> gcc/ChangeLog: >> >> * value-range.cc (get_bound_with_infinite_markers): New static helper. >> (irange::as_string): New definition. >> * value-range.h: New declaration. >> >> --- >> Provide means to print a value range to a newly allocated buffer. >> The caller is responsible to free() the allocated memory. >> >> Bootstrapped and regtested on x86_86-unknown-linux with no regressions. >> Ok for trunk? >> >> Cc: Andrew MacLeod >> Cc: Aldy Hernandez >> --- >> gcc/value-range.cc | 56 ++++++++++++++++++++++++++++++++++++++++++++++ >> gcc/value-range.h | 3 +++ >> 2 files changed, 59 insertions(+) >> >> diff --git a/gcc/value-range.cc b/gcc/value-range.cc >> index a855aaf626c..51cd9a38d90 100644 >> --- a/gcc/value-range.cc >> +++ b/gcc/value-range.cc >> @@ -3099,6 +3099,62 @@ debug (const value_range &vr) >> fprintf (stderr, "\n"); >> } >> >> +/* Helper for irange::as_string(). Print a bound to an allocated buffer. */ >> +static char * > Can we start using std::string instead of char* here? If it makes the code easier to read/maintain, sure.  std::string isn't used heavily, but has crept into a few places, mostly in target files.  std::string isn't something we've pushed at all in terms of preferred practices. Jeff