From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.smtpout.orange.fr (smtp04.smtpout.orange.fr [80.12.242.126]) by sourceware.org (Postfix) with ESMTPS id 99603395561E for ; Sat, 17 Sep 2022 11:58:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 99603395561E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=orange.fr Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=orange.fr Received: from [192.168.1.17] ([86.215.174.255]) by smtp.orange.fr with ESMTPA id ZWTHoFJW6TyouZWTHoXqIs; Sat, 17 Sep 2022 13:58:56 +0200 X-ME-Helo: [192.168.1.17] X-ME-Auth: bW9yaW4tbWlrYWVsQG9yYW5nZS5mcg== X-ME-Date: Sat, 17 Sep 2022 13:58:56 +0200 X-ME-IP: 86.215.174.255 Message-ID: <0a979a6a-388d-c4e4-53db-032ed8fb9ca6@orange.fr> Date: Sat, 17 Sep 2022 13:58:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 From: Mikael Morin Subject: Re: [PATCH] Fortran: add IEEE_QUIET_* and IEEE_SIGNALING_* comparisons To: FX , Fortran Cc: gcc-patches@gcc.gnu.org References: <4E0DC1F3-FE18-4C6A-A767-E03A1BA6FCC6@gmail.com> Content-Language: en-US In-Reply-To: <4E0DC1F3-FE18-4C6A-A767-E03A1BA6FCC6@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,FREEMAIL_FROM,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,KAM_SHORT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Le 02/09/2022 à 13:37, FX via Fortran a écrit : > Hi, > > These operations were added to Fortran 2018, and correspond to well-defined IEEE comparison operations, with defined signaling semantics for NaNs. All are implemented in terms of GCC expressions and built-ins, with no library support needed. > > Bootstrapped and regtested on x86_64-linux, both 32- and 64-bit. Depends on a patch currently under review for the middle-end (https://gcc.gnu.org/pipermail/gcc-patches/2022-September/600840.html). > > OK to commit? > FX > Hello, the implementation looks good, but the tests lack checks regarding exception status. This is an important part, I think, and basically what makes a difference between the quiet and signaling variants. As the functions are elemental, a few checks with array values would be nice too. OK with these additional checks. Mikael