public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH] gcc: honour -ffile-prefix-map in ASM_MAP [PR93371]
@ 2022-08-29  9:29 Rasmus Villemoes
  2022-09-12  9:46 ` Rasmus Villemoes
  2022-11-01 20:11 ` Jeff Law
  0 siblings, 2 replies; 9+ messages in thread
From: Rasmus Villemoes @ 2022-08-29  9:29 UTC (permalink / raw)
  To: gcc-patches; +Cc: Vagrant Cascadian, Rasmus Villemoes

-ffile-prefix-map is supposed to be a superset of -fmacro-prefix-map
and -fdebug-prefix-map. However, when building .S or .s files, gas is
not called with the appropriate --debug-prefix-map option when
-ffile-prefix-map is used.

While the user can specify -fdebug-prefix-map when building assembly
files via gcc, it's more ergonomic to also support -ffile-prefix-map;
especially since for .S files that could contain the __FILE__ macro,
one would then also have to specify -fmacro-prefix-map.

gcc:
	PR driver/93371
	* gcc.cc (ASM_MAP): Honour -ffile-prefix-map.
---

I've tested that this works as expected, both by looking at how gas is
now invoked, and by running 'strings' on the generated .o file. But I
don't know how to add something to the testsuite for this.

I stumbled on this since it came up on the U-Boot mailing list:
https://lore.kernel.org/u-boot/4ed9f811-5244-54ef-b58e-83dba51510e4@prevas.dk/
.

 gcc/gcc.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/gcc.cc b/gcc/gcc.cc
index b6d562a92f0..44eafc60187 100644
--- a/gcc/gcc.cc
+++ b/gcc/gcc.cc
@@ -878,7 +878,7 @@ proper position among the other output files.  */
 #endif
 
 #ifdef HAVE_AS_DEBUG_PREFIX_MAP
-#define ASM_MAP " %{fdebug-prefix-map=*:--debug-prefix-map %*}"
+#define ASM_MAP " %{ffile-prefix-map=*:--debug-prefix-map %*} %{fdebug-prefix-map=*:--debug-prefix-map %*}"
 #else
 #define ASM_MAP ""
 #endif
-- 
2.37.2


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2022-11-16  3:50 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-29  9:29 [PATCH] gcc: honour -ffile-prefix-map in ASM_MAP [PR93371] Rasmus Villemoes
2022-09-12  9:46 ` Rasmus Villemoes
2022-09-27  6:54   ` Rasmus Villemoes
2022-10-17 10:00     ` Rasmus Villemoes
2022-11-01 20:11 ` Jeff Law
2022-11-02 12:35   ` Rasmus Villemoes
2022-11-02 15:45     ` Jeff Law
2022-11-03 13:29       ` Rasmus Villemoes
2022-11-16  3:50         ` Jeff Law

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).