From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x534.google.com (mail-pg1-x534.google.com [IPv6:2607:f8b0:4864:20::534]) by sourceware.org (Postfix) with ESMTPS id 3224A3858C52 for ; Mon, 14 Nov 2022 16:55:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3224A3858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pg1-x534.google.com with SMTP id f3so4326476pgc.2 for ; Mon, 14 Nov 2022 08:55:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=APo5C9lqCieKSTKAx5w+CG3ul6WDYoVwK7ipTB9sLus=; b=lY3vjyirb4E1PJOV/x36pZCpEEfID+hjxwzKjEi9NvPI243LDB/viYvgeHQAhnUbsY zxm+GguiPK8D6x+cDWIOOJFB14fMKM48GLfJdTF0YLhUpYEdvE7C3xfcMOj+KOA2gD4W 5quG6AeaX9iYVlrj7azesDjwKhXlyvAJ1aYY5WHlZ+0xhsL+BwhICIwCewbVKJZ+ZPbm EYwclRqecU6yutLFWuj7vJjnPiLkapwQlPcfklF+rjcVeX+GMANRKoySEihJ8HrVzEhT Fcz8mdKv/OW+NGbRHM1jEamkV7yWE+z4skW4AHjsLtmfsgd1rYIBm5CAPbyhAG0w77rc 6XVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=APo5C9lqCieKSTKAx5w+CG3ul6WDYoVwK7ipTB9sLus=; b=t1Jc6MRTVfEbUp3kf03huZ3nsCALFetHK4mx5IYNMZ0pBNTKL1zphmphEE9LJHtce2 3MK/ma/Rq60uqgpyrKPdimRkv/HLR59Mr8t4ESzJXsAmHvJuQAEmDOo8VTznVl/dRBlO fUHdOfkRuBWpLJcdmt5Tas5bgTMiDmRS50B+HRBakWosspCgy5L1mF5BlwdhCzHX9/l2 Cho9v1eN28Y7Jd0i/VztZ839Ubv/4Tsc6X+FwvN/iY2kKE3Zj9aWwmDhyGVb24hXZ+PE /64xuXJe3X8CyyPp2vi01Er9uUivVhIJdeDhNUj9Q37dSwYGLcDegNLAzOAxbCO3Rzr0 FwJQ== X-Gm-Message-State: ANoB5pn74+uiwMQ9xkwK2v3tkDLuQO3BJvMAkxKb6/MFUCsMZ5ALYe7X qyVj1uGFxsatNVOLKeRcRVw= X-Google-Smtp-Source: AA0mqf47/eq04xzhe8ITjd27/EIwHHTlNLX/zeTm7S8UdSlhQhAp1BMlMILKATONKW5tuQDSFVBs5w== X-Received: by 2002:a05:6a00:44ce:b0:571:2b7c:6693 with SMTP id cv14-20020a056a0044ce00b005712b7c6693mr14404264pfb.48.1668444917095; Mon, 14 Nov 2022 08:55:17 -0800 (PST) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id y28-20020aa7943c000000b0056328e516f4sm7192859pfo.148.2022.11.14.08.55.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Nov 2022 08:55:16 -0800 (PST) Message-ID: <0adf06b6-4daf-f090-59d3-2e548b651005@gmail.com> Date: Mon, 14 Nov 2022 09:55:14 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH 2/7] riscv: bitmanip/zbb: Add prefix/postfix and enable visiblity Content-Language: en-US To: Christoph Muellner , gcc-patches@gcc.gnu.org, Kito Cheng , Jim Wilson , Palmer Dabbelt , Andrew Waterman , Philipp Tomsich , Vineet Gupta References: <20221113230521.712693-1-christoph.muellner@vrull.eu> <20221113230521.712693-3-christoph.muellner@vrull.eu> From: Jeff Law In-Reply-To: <20221113230521.712693-3-christoph.muellner@vrull.eu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_MANYTO,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/13/22 16:05, Christoph Muellner wrote: > From: Christoph Müllner > > INSNs are usually postfixed by a number representing the argument count. > Given the instructions will be used in a later commit, let's make them > visible, but add a "riscv_" prefix to avoid conflicts with standard > INSNs. > > gcc/ChangeLog: > > * config/riscv/bitmanip.md (*_not): Rename INSN. > (riscv__not3): Rename INSN. > (*xor_not): Rename INSN. > (xor_not3): Rename INSN. Not strictly necessary, but given how often I've seen ports expose an insn with a standard name, but ever so slightly different semantics and the ensuing code correctness issues, I like the idea of prefixing. OK jeff