From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by sourceware.org (Postfix) with ESMTPS id EC4B9385802E for ; Mon, 25 Oct 2021 18:44:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EC4B9385802E Received: by mail-pl1-x634.google.com with SMTP id n11so8562857plf.4 for ; Mon, 25 Oct 2021 11:44:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=zkwe1/CFiYrFstekO2YOgUdOp+Eu5EbQwmWoEdKDdYE=; b=sgaW+LVfDuvnG7Vz478YBDEsTE56py8fURYbNEjm+5r8pifnBrj3lFE0GhpXsTo5yF kBsWVwB1uC8nNU1J2YL/e4um6NwW8diSz4zc4+tNk3mIQLbzy1xV7TLQEtyYqGatgOiN 7GiDo/9b9mVdU7U/mrIZjj5ZgaiPkvyvhyGDW3CqYqbJ1ipP5tbd8D9RlTsTGTWt1zQV radsMO3rA3+ph+vYaepxYpvq4qzERQmjDOjhIszeReMQnXBT5ZbyXQfh5XZBAirCI1oD vPpjqLwfwjcHmC3JeajD7bo+miItI8UXd3O7imXiuyWBK4JztWC0McGkwRLzyhXhKgoO bK0g== X-Gm-Message-State: AOAM532LkOiwx0i2Al5lT5VwM2+7A57Wa5x98XY0K4V6walKkoyOR+Qc aApmUu9Yri4am5WZ1FBPXaIIIOHEn4g= X-Google-Smtp-Source: ABdhPJwyKQRiNlVgVbzepAtfQLmaC9xhWhB73w3NuLVv+8RubXVTsCaRaljnOAokfUSD5y3G8nRV3w== X-Received: by 2002:a17:90a:e7cc:: with SMTP id kb12mr11594121pjb.176.1635187466749; Mon, 25 Oct 2021 11:44:26 -0700 (PDT) Received: from [172.31.0.175] (c-98-202-48-222.hsd1.ut.comcast.net. [98.202.48.222]) by smtp.gmail.com with ESMTPSA id gn1sm5656532pjb.34.2021.10.25.11.44.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Oct 2021 11:44:26 -0700 (PDT) Subject: Re: [PATCH] [PR testsuite/102857] Tweak ssa-dom-thread-7.c for aarch64. To: Aldy Hernandez Cc: GCC patches References: <20211023091428.99315-1-aldyh@redhat.com> From: Jeff Law Message-ID: <0b392ae1-316a-2f13-3b98-8912d17ff277@gmail.com> Date: Mon, 25 Oct 2021 12:44:25 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211023091428.99315-1-aldyh@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Oct 2021 18:44:29 -0000 On 10/23/2021 3:14 AM, Aldy Hernandez wrote: > First, ssa-dom-thread-7 was looking at a dump file that was not > being generated. This probably happened in the detangling of the VRP > threader from VRP, and I didn't notice because the test came back as > with UNRESOLVED instead of FAIL. > > Second, aarch64 gets far more threads than other architectures (20 > versus 12). The difference is sufficiently different to make the > regex awkward. > > We already have special casing for aarch64 in other parts of this > test, so perhaps it's simplest to have an arch specific test > for the thread3 count. > > I don't know perhaps there's a better way. I wake up with chills in > the middle of the night thinking about this test ;-). > > Tested on x86-64 Linux and aarch64 Linux. > > OK? > > gcc/testsuite/ChangeLog: > > PR testsuite/102857 > * gcc.dg/tree-ssa/ssa-dom-thread-7.c: Add -fdump-tree-vrp2-stats. > Tweak for aarch64. OK jeff