From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from nh501-vm10.bullet.mail.kks.yahoo.co.jp (nh501-vm10.bullet.mail.kks.yahoo.co.jp [183.79.56.140]) by sourceware.org (Postfix) with SMTP id AE21E3857811 for ; Sat, 11 Jun 2022 08:31:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AE21E3857811 Received: from [183.79.100.139] by nh501.bullet.mail.kks.yahoo.co.jp with NNFMP; 11 Jun 2022 08:31:52 -0000 Received: from [183.79.100.134] by t502.bullet.mail.kks.yahoo.co.jp with NNFMP; 11 Jun 2022 08:31:52 -0000 Received: from [127.0.0.1] by omp503.mail.kks.yahoo.co.jp with NNFMP; 11 Jun 2022 08:31:52 -0000 X-Yahoo-Newman-Property: ymail-3 X-Yahoo-Newman-Id: 880295.58329.bm@omp503.mail.kks.yahoo.co.jp Received: (qmail 59553 invoked by alias); 11 Jun 2022 08:31:52 -0000 Received: from unknown (HELO ?192.168.2.3?) (175.177.45.176 with ) by smtp6008.mail.ssk.ynwp.yahoo.co.jp with SMTP; 11 Jun 2022 08:31:52 -0000 X-YMail-JAS: DgtWEl8VM1nWxGDuf6dvfRVLl0.rb5NvIu0EI6Wjh_iKR51.AaEzToVcc_Zw6M5cjpPEGwb6tx4pqmdAQacox4rodJdqRPheEuR_gr7Xw82mA3Ju2uobl1aFzEaqmBk1eBHqxVSFRw-- X-Apparently-From: X-YMail-OSG: lmw7cXAVM1nxPjtMVm82vOOt8UN5QfSuznVVsviHhuxTcZA Xm2yWF2CCqLaT6Zmx2AwkOu.LJw2gomEljKBDKuA_GJFOHWbUzxzcygKMMRP 7S1MMovwYWvFCsrdaZXx69XjCpCQc7040.ImgMhnnnpPi71_zQwE7GtwuuKZ loxynHNwo5vAz6qQuKRmbQaOGoOxAWMnSk_bJ1uk_4VbjlMEL8Y3kssICOeU wiNJg2vRochu8vXe98gmIPLQKUyOVeN6u970BAkclYSY022fqPh9w3IK7ZNG qzpzXfC1WcOHR3gUJxcLYvZ_CyvOhluvqYrrtEH5sCWBrGzpWGWpySBbTYm6 HOEz5V.LM8HmPl4HCLpr6joboPOqaABXKE0Uv6apJgKP2EklJs03gnAbfXdU sp27xjoFpyTETDPjjwDt9..VkLeoeMk34zCR5drYEm4wL5RZMhr8s05HvR8o rmSQFSL_QLk3bkTQkqR_4Py92g87evsZxE4dt99o8t_1EpdlqzNn8_a.TXkI 9YT8O1T8Q5ZAShC_YSyU5iNppaiI5V2lsxUYhx7C6l0HDSZi0EzVe0ZZ237v sAYQ8nNdnUKuHB.nOJ4sORXvM.ZrzAMuYECxy.GVp0hCvW9br1tfMYf.Sd1u p_NIFpmaA.zHJ9a.8q7242CfHyZ7Smy8JJmyHeuIn2ZnMDNAfAwPyldSEJqB p3y.gDiiWQIgx63M4n.KTXEjj0CHFfMk1sd3_rZ.pR4HNK8ibLao_srkSfkJ LqIdKY8ga3W2nL7Yik6mS1aGeRHoJVb9fbG6.fa_sVWh2ozSi44z1trpExRT RgebKostUxz0CcI4EV_miJnEmg2bbIIqiDGV2PdrGG74NwJ0KZKDmQiH15FD da9RxHZbJ_cZ5w0JWFYUWPiBFVL0u9xLYn3CWUA8Ajuwo41J0R3odVlKR000 KfDbMmOc716Ig5XM6GQ-- Message-ID: <0b7a3a36-cbdf-e812-4c04-533b15c9963b@yahoo.co.jp> Date: Sat, 11 Jun 2022 17:31:16 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 From: Takayuki 'January June' Suwa Subject: Re: [PATCH v2 4/4] xtensa: Improve constant synthesis for both integer and floating-point To: Max Filippov References: <200341ff-4907-c6da-07cb-86b9b4588f84@yahoo.co.jp> Content-Language: en-US Cc: GCC Patches In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, WEIRD_PORT autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Jun 2022 08:31:57 -0000 On 2022/06/11 16:58, Max Filippov wrote: > Hi Suwa-san, hi! > this change results in a bunch of ICEs in the tests like this: > during RTL pass: split2 > gcc/gcc/testsuite/gcc.c-torture/compile/20120727-1.c: In function 'f': > gcc/gcc/testsuite/gcc.c-torture/compile/20120727-1.c:13:1: internal > compiler error: in gen_split_5, at config/xtensa/xtensa.md:1186 [from config/xtensa/xtensa.md] if (GET_MODE (x) == SFmode) REAL_VALUE_TO_TARGET_SINGLE (*CONST_DOUBLE_REAL_VALUE (x), l[0]); else if (GET_MODE (x) == DFmode) REAL_VALUE_TO_TARGET_DOUBLE (*CONST_DOUBLE_REAL_VALUE (x), l); else gcc_unreachable (); // line 1186 x = gen_rtx_REG (SImode, REGNO (operands[0])); umm, i don't know how 'XEXP (operands[1], 0)' can be neither SFmode nor DFmode... please tell me that test piece of code, and/or apply the below patch and reply what the compiler print to stderr: --- gcc/config/xtensa/xtensa.md +++ gcc/config/xtensa/xtensa.md @@ -1183,7 +1183,10 @@ else if (GET_MODE (x) == DFmode) REAL_VALUE_TO_TARGET_DOUBLE (*CONST_DOUBLE_REAL_VALUE (x), l); else - gcc_unreachable (); + { + print_rtl_single (stderr, x); + gcc_unreachable (); + } x = gen_rtx_REG (SImode, REGNO (operands[0])); if (! xtensa_constantsynth (x, l[i])) emit_move_insn (x, GEN_INT (l[i]));