From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by sourceware.org (Postfix) with ESMTPS id D8EE5393C84B for ; Thu, 24 Jun 2021 05:01:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D8EE5393C84B Received: by mail-pl1-x635.google.com with SMTP id v12so2308639plo.10 for ; Wed, 23 Jun 2021 22:01:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language; bh=JlBopJCUvcyHSUNYKsjlonncM7WR2UwEWNHCuuzBIMM=; b=ZM0v6he209+RkKGMVNwvPM92nIfM1jJekHWTOQrYUIyfKC5oIA06vEoDqo1grJW72A i8yQCAJerz9axC0kzyq2yNvilf7sy1VE9vTCB8WJnkWL6DZ30iiFzfFrKs5Dy5REQoxk UWsuzLwSWgnQ8SQOfSAJb/puiWQn5qLX+/ngSaRY12qF4AM8eyZiiuY9q3nSevNj8QRP hzxC8lASVstnVHLy53T9BtBK8ofIlg0+gqi2/3Iumibx2dQMcK3Q+A+Ng/Jj7N4xDJW2 bBDRB14Lq+XCq3lwbmBJ+8hsZdo32u4zKvkuyDHSHX0RuCqog1Kewxm55WuOwntShVyc mBug== X-Gm-Message-State: AOAM533LKRf0ac0SrtX9JNQBcOhugSpjwVoqUUcmIzu1nzMzN61JEpIt nW+zFffBeIEWkJBMmy313mT+JFv8E8swNw== X-Google-Smtp-Source: ABdhPJx6G5PvEmyWTjw9QRXEJUv132KPXwFFPNCdRslnK80OddDcK8kXB/ao7IryGYt2ssKhUbZOAQ== X-Received: by 2002:a17:90a:fb95:: with SMTP id cp21mr3376989pjb.28.1624510864793; Wed, 23 Jun 2021 22:01:04 -0700 (PDT) Received: from [192.168.1.39] (65-130-74-37.slkc.qwest.net. [65.130.74.37]) by smtp.gmail.com with ESMTPSA id p45sm1393784pfw.19.2021.06.23.22.01.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Jun 2021 22:01:04 -0700 (PDT) Subject: Re: [PATCH 12/13] v2 Remove TREE_NO_WARNING and gimple*no_warning* APIs To: Martin Sebor , gcc-patches References: <92db3776-af59-fa20-483b-aa67b17d0751@gmail.com> <47d06c821a53f5bd2246f0fca2c9a693bff6b882.camel@redhat.com> <3a5ea83c-0d91-d123-f537-f8f1223df890@gmail.com> <9902ab65-65a7-a40f-7b4e-864e6c3250dc@gmail.com> From: Jeff Law Message-ID: <0b89f0ac-bd41-f467-1c6f-6effb9d2cb66@gmail.com> Date: Wed, 23 Jun 2021 23:01:01 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: <9902ab65-65a7-a40f-7b4e-864e6c3250dc@gmail.com> Content-Language: en-US X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, HTML_MESSAGE, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jun 2021 05:01:07 -0000 On 6/4/2021 3:43 PM, Martin Sebor via Gcc-patches wrote: > The attached patch removes the definitions of the TREE_NO_WARNING macro > and the gimple_get_no_warning_p() and gimple_set_no_warning() functions. > > gcc-no-warning-remove-api.diff > > Remove legacy TREE_NO_WARNING amd gimple_*no_warning* APIs. > > gcc/ChangeLog: > > * tree.h (TREE_NO_WARNING): Remove. > * gimple.h (gimple_no_warning_p): Remove. > (gimple_suppress_warning): Same. Is there any value in marking these as poisoned?  We've done that for some macros in the past, but we haven't been consistent with it.    If you think it's worth poisoning, the place to do that is system.h. Approved with or without poisoning once prereqs are approved. jeff