From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) by sourceware.org (Postfix) with ESMTPS id 670FB3854551 for ; Fri, 18 Nov 2022 19:52:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 670FB3854551 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x42d.google.com with SMTP id g62so5836708pfb.10 for ; Fri, 18 Nov 2022 11:52:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=TauUuu1pmpNvXLU8V7ad8SVhS1BfJQtluJvr2wCtcDE=; b=duk9rHzfGKWoXUkz5BelcLuB1BhGhMJnmb4gX2vAeHzRpTO0ulgWPx3HnVcZ5lVG2B v7Yuyf8KhKuUpGrtIAPVBhPoDzkOIzuGlsaE+zW3gwJRaF5G84XVA4EBka9SCOK7X19Z tbGmU7NGtLwe5yYXnlTGKBC8GwFc1VWzDVTy8JCKpqdeygjWdsyS/zC9VHDanxtuZSaZ ixtAMfSqVKdlYsgCAaFkit27og0LhURcm8jC47yZi2gTc3Fm1fOypgz+9iBnZ8zaU2gy H9Iqm+CMLIhzp/uTvu1YKIIb5GSSyvpJ6EpSWEC9TY2oskZO+pWjntX7aAQSHV2r4OCe tdRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TauUuu1pmpNvXLU8V7ad8SVhS1BfJQtluJvr2wCtcDE=; b=EgXGkT1+ssANM8E9xS9YLyzNfGeDWVqyYLQKb8VvTsORSeBbXRloOUOlTAcif1IOYU MmUITjWwr5/5S3jnmiX5/lDVa8+8fa4fKcl7KGTuUeT3paKlcPTx0X/YNcZHvX5XLHbp EJO0BMc1LEpR3F/lgQ8+jsRmQppn8Md4Jc8GXFPStFrLb9bAU4MS194GWpvKgQSEZBA9 0bgj2NCfmYPvnJPDPwJrcWXSAIodFK2AW26dV8yeWS1GdnHwUUjgC9gd8NgIrK7PNOgp xzlXzBZkeEdaOvq+0UOsfCjwp0mopokFfCCJkRyX0bnJlJn+kTPzbeY9QItsqkz8FUEz VdCw== X-Gm-Message-State: ANoB5pnvOCbWwx7nfrZvaVPDKHGuiysa6w6IDFhy+31E6dO7xdjQFapb /C9glM3p8r+Mo03/e6xAl4M= X-Google-Smtp-Source: AA0mqf5b64I23J92im/BKIcDGt1l6wJUNr9L1R0E9UZWC5yNArQr3Kd4+Jh7JmFSMkv3sjZO0rhwKg== X-Received: by 2002:a63:54e:0:b0:476:df12:2a71 with SMTP id 75-20020a63054e000000b00476df122a71mr7710152pgf.563.1668801125156; Fri, 18 Nov 2022 11:52:05 -0800 (PST) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id s27-20020aa78bdb000000b0056c704abca7sm3522008pfd.220.2022.11.18.11.52.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Nov 2022 11:52:04 -0800 (PST) Message-ID: <0ba55dec-3d59-a63e-5e5d-c99cf89f64ca@gmail.com> Date: Fri, 18 Nov 2022 12:52:02 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH] RISC-V: Optimize slli(.uw)? + addw + zext.w into sh[123]add + zext.w Content-Language: en-US To: Philipp Tomsich , gcc-patches@gcc.gnu.org Cc: Christoph Muellner , Palmer Dabbelt , Kito Cheng , Vineet Gupta , Jeff Law References: <20221108195730.2701496-1-philipp.tomsich@vrull.eu> From: Jeff Law In-Reply-To: <20221108195730.2701496-1-philipp.tomsich@vrull.eu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/8/22 12:57, Philipp Tomsich wrote: > gcc/ChangeLog: > > * config/riscv/bitmanip.md: Handle corner-cases for combine > when chaining slli(.uw)? + addw > > gcc/testsuite/ChangeLog: > > * gcc.target/riscv/zba-shNadd-04.c: New test. OK. Something to consider.  We're gaining a lot of (subreg:SI (reg:DI) 0) kinds of operands. Would it make sense to make an operand predicate that accepted (reg:SI) or (subreg:SI (reg:DI) 0)? It will reduce my compaints about subregs :-)  But the real reason I'm suggesting we consider adding such a predicate is, AFIACT, it it gives combine a chance to eliminate the subreg.  I haven't actually tested this, but it seems like it might be worth a quick experiment independent of these patches (and probably targeted towards gcc-14 rather than gcc-13). jeff