From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) by sourceware.org (Postfix) with ESMTPS id BED173858C1F for ; Tue, 2 May 2023 16:41:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BED173858C1F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pg1-x52a.google.com with SMTP id 41be03b00d2f7-51452556acdso2682119a12.2 for ; Tue, 02 May 2023 09:41:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683045677; x=1685637677; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=e7Bo4GZS3+n35VZo0qruSdmcjH6BXomDOd3u2Y8IDZs=; b=qvKVKH6YF+V20FBH5UzZyvk3qWT2UHQrVa/IEPVUXEtESo5dfjQxIbW0Gx8+abb3GK 8Zjf+niLADt4OvG9WSOYPufcbQ1cbuxIvfd7dJz2zacKAmCQA82g/ZXFiGrNdg4eXTLJ hgyQh5eQp6fv2PJbYwN5hF8lcdFmwXg2pYlMQQMgbXUkaSHyUAR8AIW/uGn7Z3ev6+d/ nRvFnkx+XkD7gWjyYBXcH1Bc9MY3YOQGZqIVTirCkhTD2E6BgBvEKHZHvs4MpDl3+n1Z 4ypGU94psu9Ic/FUV7NxWJawReqUkRSBZP0EL701WvnjzMhFv8qQ0QNVhIieKAsS5kMV 5NCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683045677; x=1685637677; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=e7Bo4GZS3+n35VZo0qruSdmcjH6BXomDOd3u2Y8IDZs=; b=DjH3CoJ3o17N+dKpiSwg1mhxVjYyPErmbSTIG3iCMZTJDMXL8/02zl69ckZeIxSCkt 7sBf+63fhPJuq4L2twlZpYzdqIzMjrMSqB0Tc2B5LVPo5UScoe0sPzURL111TIvTWoB5 rL8QAHpVrGBY8qkq64dj7pkLicq0KGTrRzEvpQJvDu8o3wz8e2LkCkWj6MK6435ju0cL VlarhKDDA9wRwprF7oTwAQwwaeMpu/eB6bimqtqw54bk98bzreeD8y4SqgTVAt9F7qD3 p9dHKnvNaOdcKRsTAvGqubyGa7cwyPzo25KH/Qgsv50htxhLCQSpYuEYYHQIhzhElwHd 9kXA== X-Gm-Message-State: AC+VfDw2CIzIza88bVZT6CJzw1cjg+TxHiG92upe8nQMwtPxD+PnzAAK ChawrbJKYyMrnGBEpifLmrk= X-Google-Smtp-Source: ACHHUZ4nDER6ixDkt79GDMvhqg/jIL8gr2QWOYuBXgMxRs+G1Ln6fvlXCTJJJD8qJ+q2Lqj//s/uZA== X-Received: by 2002:a17:902:ce8f:b0:1a9:5c3f:6a75 with SMTP id f15-20020a170902ce8f00b001a95c3f6a75mr21270483plg.69.1683045677444; Tue, 02 May 2023 09:41:17 -0700 (PDT) Received: from ?IPV6:2601:681:8600:13d0::99f? ([2601:681:8600:13d0::99f]) by smtp.gmail.com with ESMTPSA id n23-20020a170902969700b001aaec7a2a62sm4819589plp.188.2023.05.02.09.41.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 May 2023 09:41:16 -0700 (PDT) Message-ID: <0bd369c5-cd8b-fa67-ef12-a3ee264f6a64@gmail.com> Date: Tue, 2 May 2023 10:41:15 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [committed] Enable LRA on several ports Content-Language: en-US To: Hans-Peter Nilsson , Jeff Law Cc: gcc-patches@gcc.gnu.org References: <91be1ec3-de85-04cc-0d9f-d3aa69f075dc@ventanamicro.com> <20230502032401.A270320418@pchp3.se.axis.com> From: Jeff Law In-Reply-To: <20230502032401.A270320418@pchp3.se.axis.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/1/23 21:24, Hans-Peter Nilsson via Gcc-patches wrote: > >> There may be >> minor code quality regressions or there may be minor code quality >> improvements -- I'm leaving that for the port maintainers to own going >> forward. > > Right; I noticed performance regressions, and didn't want to > commit anything that knowingly degraded performance. I did > follow the traces but fell into the rabbit-hole of > rtx_costs. That's the main reason I didn't push a "-mlra" > option or remove the TARGET_LRA_P for CRIS. (My story and I > stick to it.) > > But thanks I guess, it saves me a commit, but (to all!) > please sync check_effective_target_lra for targets you > "convert". ...oops, it's just CRIS and hppa there (wot, not > converted?) Well, I'd say that my plan would be to deprecate any target that is not converted by the end of this development cycle. So the change keeps cris from falling into that bucket. I wasn't aware of check_effective_target_lra. Thanks. I'll make sure to get that updated as we go forward. jeff