From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 46D603858401 for ; Mon, 15 Aug 2022 15:05:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 46D603858401 Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 27FEOiqE010592 for ; Mon, 15 Aug 2022 15:05:54 GMT Received: from ppma04ams.nl.ibm.com (63.31.33a9.ip4.static.sl-reverse.com [169.51.49.99]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3hyqvth4rk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 15 Aug 2022 15:05:53 +0000 Received: from pps.filterd (ppma04ams.nl.ibm.com [127.0.0.1]) by ppma04ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 27FEoJjF010789 for ; Mon, 15 Aug 2022 15:05:51 GMT Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by ppma04ams.nl.ibm.com with ESMTP id 3hx3k9a4bu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 15 Aug 2022 15:05:51 +0000 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 27FF5maq29098460 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 15 Aug 2022 15:05:48 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 67A4E4C044; Mon, 15 Aug 2022 15:05:48 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3DFD34C040; Mon, 15 Aug 2022 15:05:48 +0000 (GMT) Received: from [9.171.8.169] (unknown [9.171.8.169]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTP; Mon, 15 Aug 2022 15:05:48 +0000 (GMT) Message-ID: <0bdaaa1b-9387-5309-f89a-5800e3925238@linux.ibm.com> Date: Mon, 15 Aug 2022 17:05:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] s390: Add -munroll-only-small-loops. Content-Language: en-US To: Robin Dapp , GCC Patches References: <4166b06c-7713-2d4a-3c86-54e99f4a9f53@linux.ibm.com> From: Andreas Krebbel In-Reply-To: <4166b06c-7713-2d4a-3c86-54e99f4a9f53@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: JLTo3d7YHlpLMAG804EooxxA04ezRxGX X-Proofpoint-ORIG-GUID: JLTo3d7YHlpLMAG804EooxxA04ezRxGX X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-08-15_08,2022-08-15_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 clxscore=1015 priorityscore=1501 adultscore=0 lowpriorityscore=0 mlxscore=0 spamscore=0 malwarescore=0 phishscore=0 impostorscore=0 mlxlogscore=999 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000 definitions=main-2208150059 X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, KAM_SHORT, NICE_REPLY_A, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Aug 2022 15:05:57 -0000 On 8/12/22 12:00, Robin Dapp wrote: > Hi, > > inspired by Power we also introduce -munroll-only-small-loops. This > implies activating -funroll-loops and -munroll-only-small-loops at -O2 > and above. > > Bootstrapped and regtested. > > This introduces one regression in gcc.dg/sms-compare-debug-1.c but > currently dumps for sms are broken as well. The difference is in the > location of some INSN_DELETED notes so I would consider this a minor issue. > > Is it OK? > > Regards > Robin > > gcc/ChangeLog: > > * common/config/s390/s390-common.cc: Enable -funroll-loops and > -munroll-only-small-loops for OPT_LEVELS_2_PLUS_SPEED_ONLY. > * config/s390/s390.cc (s390_loop_unroll_adjust): Do not unroll > loops larger than 12 instructions. > (s390_override_options_after_change): Set unroll options. > (s390_option_override_internal): Likewise. > * config/s390/s390.opt: Document munroll-only-small-loops. > > gcc/testsuite/ChangeLog: > > * gcc.target/s390/vector/vec-copysign.c: Do not unroll. > * gcc.target/s390/zvector/autovec-double-quiet-uneq.c: Dito. > * gcc.target/s390/zvector/autovec-double-signaling-ltgt.c: Dito. > * gcc.target/s390/zvector/autovec-float-quiet-uneq.c: Dito. > * gcc.target/s390/zvector/autovec-float-signaling-ltgt.c: Dito. Ok. Thanks! Andreas