From: Alexander Monakov <amonakov@ispras.ru>
To: "Arsen Arsenović" <arsen@aarsen.me>
Cc: exactlywb@ispras.ru, gcc-patches@gcc.gnu.org
Subject: Re: [RFC PATCH] Detecting lifetime-dse issues via Valgrind
Date: Sun, 12 Nov 2023 11:07:59 +0300 (MSK) [thread overview]
Message-ID: <0c0b254a-7791-5c71-10ac-393108ce5375@ispras.ru> (raw)
In-Reply-To: <86edgvq5y2.fsf@aarsen.me>
[-- Attachment #1: Type: text/plain, Size: 569 bytes --]
On Sat, 11 Nov 2023, Arsen Arsenović wrote:
> > +#else
> > +# define VALGRIND_MAKE_MEM_UNDEFINED(ptr, sz) __builtin_trap ()
> > +#endif
> > +
> > +void __valgrind_make_mem_undefined (void *ptr, unsigned long sz)
> > +{
> > + VALGRIND_MAKE_MEM_UNDEFINED (ptr, sz);
> > +}
>
> Would it be preferable to have a link-time error here if missing?
Indeed, thank you for the suggestion, will keep that in mind for resending.
That will allow to notice the problem earlier, and the user will be able
to drop in this snippet in their project to resolve the issue.
Alexander
next prev parent reply other threads:[~2023-11-12 8:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-24 14:11 exactlywb
2023-11-11 22:25 ` [RFC PATCH] Detecting lifetime-dse issues via Valgrind [PR66487] Sam James
2023-11-12 9:00 ` Alexander Monakov
2023-11-12 9:05 ` Sam James
2023-11-12 22:53 ` Sam James
2023-11-15 9:58 ` Daniil Frolov
2023-11-11 22:26 ` [RFC PATCH] Detecting lifetime-dse issues via Valgrind Arsen Arsenović
2023-11-12 8:07 ` Alexander Monakov [this message]
2023-11-13 12:00 ` Richard Biener
2023-11-13 14:29 ` Alexander Monakov
2023-11-13 16:25 ` Richard Biener
2023-11-21 7:52 ` Alexander Monakov
2023-11-21 7:59 ` Alexander Monakov
2023-11-21 8:02 ` Richard Biener
2023-11-21 8:56 ` Alexander Monakov
2023-11-21 9:40 ` Richard Biener
2023-11-21 21:42 ` Hans-Peter Nilsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c0b254a-7791-5c71-10ac-393108ce5375@ispras.ru \
--to=amonakov@ispras.ru \
--cc=arsen@aarsen.me \
--cc=exactlywb@ispras.ru \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).