public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeff Law <jeffreyalaw@gmail.com>
To: Eric Botcazou <botcazou@adacore.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Handle addresses of more constants in IPA-CP
Date: Sat, 11 Nov 2023 11:32:25 -0700	[thread overview]
Message-ID: <0cc2153e-9ee3-4666-ae94-79ccd54267f9@gmail.com> (raw)
In-Reply-To: <2245595.iZASKD2KPV@fomalhaut>



On 11/11/23 05:11, Eric Botcazou wrote:
> Hi,
> 
> IPA-CP can currently handle addresses of scalar constants (CONST_DECL) so this
> extends that to addresses of constants in the pool (DECL_IN_CONSTANT_POOL).
> Again this is helpful for so-called fat pointers in Ada, i.e. objects that are
> semantically pointers but represented by structures made up of two pointers.
> 
> This also moves the unused function print_ipcp_constant_value from ipa-cp.cc
> to ipa-prop.cc and renames it.
> 
> I have an LTO testcase for which this makes a difference, but it's large so
> not really suitable for the testsuite.
> 
> Bootstrapped/regtested on x86-64/Linux, OK for the mainline?
> 
> 
> 2023-11-11  Eric Botcazou  <ebotcazou@adacore.com>
> 
> 	* ipa-cp.cc (print_ipcp_constant_value): Move to...
> 	(values_equal_for_ipcp_p): Deal with VAR_DECLs from the
> 	constant pool.
> 	* ipa-prop.cc (ipa_print_constant_value): ...here.  Likewise.
> 	(ipa_print_node_jump_functions_for_edge): Call the function
> 	ipa_print_constant_value to print IPA_JF_CONST elements.
> 
OK
jeff

  reply	other threads:[~2023-11-11 18:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-11 12:11 Eric Botcazou
2023-11-11 18:32 ` Jeff Law [this message]
2024-11-14 12:48 ` [PATCH] ipa-cp: Fix constant dumping Martin Jambor
2024-11-14 13:07   ` Eric Botcazou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0cc2153e-9ee3-4666-ae94-79ccd54267f9@gmail.com \
    --to=jeffreyalaw@gmail.com \
    --cc=botcazou@adacore.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).