From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x12f.google.com (mail-il1-x12f.google.com [IPv6:2607:f8b0:4864:20::12f]) by sourceware.org (Postfix) with ESMTPS id 616E53858D38 for ; Sat, 11 Nov 2023 18:32:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 616E53858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 616E53858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::12f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699727548; cv=none; b=hyBtMDtskLFasUCaswjtvDa3785Cc6kHtUpXbQCoApUxiF41zFU09VvaWC64Iw1wb1pJ+gf0LhCkp9t58S7JrtmeqyuLC/ZX0nJ29RYb3gGjbqGFAad/V+UzRPsPl3vDM0TSUyla16RCZCEm6ct0Su5EOfMUNH9ioaB4bcvyQ/o= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699727548; c=relaxed/simple; bh=A8KuVXf4sVCTTn+48o8vGKFKDwbrd6Q200DyNVI8aio=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=O9QoNQCZX34PprRATeHcp16Unxv1BcCeKKu4onrDG5HsZBt8tAVb+xKY+czHHqQLUAvj7u5REJVy5JWJfs3UfCT7rPxM2lAc+NavmkS8SG93qgoPQBdXzows2H1R9fyakuSaQFKQI25v1pfHzgAwKwzNyPWoFOjeRbSmFvhVfbQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-il1-x12f.google.com with SMTP id e9e14a558f8ab-3574f99d236so12098325ab.2 for ; Sat, 11 Nov 2023 10:32:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699727546; x=1700332346; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=v/gvJOaO5JZnN3h7J6f/z9Jr0p+74TPLTxuGaJXk6vQ=; b=F3fTmCCojPjyk681P0+FQB/sQhtXSIjlvBKyw0PTq7S1S0bmBNWjx160aPQ8fHFQWM ukUmepvM2763mvLS7WXmGMe6fFY3rum78cLNQDZaV/N8JBQUBXvJYjJ7kDEcwMs34fWl wEkeTlsgrVpV4oEusmjAUyCjNM4HngqeW06yT+kA4Yo0gu7n44Ik9pahhVcjIdQToFbD t2oygLPCiRtTMGEEcpe4GQtfpdJZnXWskX/4YZ+4ZPz7ub4KxXwmhkzwdODR/6+0ttPT AMk7WP02ZJKLZqqpgjYvtx/sj5qs2gylMuPcPHEijTKr24nqol+t88uvHzt0Yeqx6ndw cj6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699727546; x=1700332346; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=v/gvJOaO5JZnN3h7J6f/z9Jr0p+74TPLTxuGaJXk6vQ=; b=ZrinAUfD/OiZgZNhJO7wHZRg82eMCHtKpFCVRckz582PiguBg1eeQWhK+jGgRQ/4YW 7c+Yn5W/rb6AS6LAfnd/yXYnhnFDr5foagGb1fC+bsjOuC0QBjbIuJjkLfkSPPziJ6c5 mNsYL8dJaWlgYjO/RuG1XRmMMipvKpawjeHL0E/UH4oZ+Q4OLfZCkQYR4yOFZJujANPJ xhFNZT0zINbI7xXTTvTG0Oy7VFTycirMi9W66Ivv6BS7TZJbIIohDyHQxfTPSUMnFeb4 GR2rbQoL8qpTPXDLtJzY5THfJPJt0ftXGt53DeTekyu1x5UMTItQS8M/BGkuyvYcQROy teiw== X-Gm-Message-State: AOJu0YwUNf7a+KfFD6RyDyA97A7ek0LGfGvMg6aCyVb5JF6A0cZ7DIkW 8v8UcDzeOXk5AuRiQ5yIyj8= X-Google-Smtp-Source: AGHT+IGVXJIwE8FtbIILWiPnStOwdNKc0jXsFF8S4gSwBsTnoi22HcDGCkCE/vcxAxNxS+0utRxPQA== X-Received: by 2002:a05:6e02:20e5:b0:359:311b:490e with SMTP id q5-20020a056e0220e500b00359311b490emr3676996ilv.2.1699727546526; Sat, 11 Nov 2023 10:32:26 -0800 (PST) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id p5-20020a92d285000000b0035163fb9f9fsm578369ilp.43.2023.11.11.10.32.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 11 Nov 2023 10:32:26 -0800 (PST) Message-ID: <0cc2153e-9ee3-4666-ae94-79ccd54267f9@gmail.com> Date: Sat, 11 Nov 2023 11:32:25 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Handle addresses of more constants in IPA-CP Content-Language: en-US To: Eric Botcazou , gcc-patches@gcc.gnu.org References: <2245595.iZASKD2KPV@fomalhaut> From: Jeff Law In-Reply-To: <2245595.iZASKD2KPV@fomalhaut> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/11/23 05:11, Eric Botcazou wrote: > Hi, > > IPA-CP can currently handle addresses of scalar constants (CONST_DECL) so this > extends that to addresses of constants in the pool (DECL_IN_CONSTANT_POOL). > Again this is helpful for so-called fat pointers in Ada, i.e. objects that are > semantically pointers but represented by structures made up of two pointers. > > This also moves the unused function print_ipcp_constant_value from ipa-cp.cc > to ipa-prop.cc and renames it. > > I have an LTO testcase for which this makes a difference, but it's large so > not really suitable for the testsuite. > > Bootstrapped/regtested on x86-64/Linux, OK for the mainline? > > > 2023-11-11 Eric Botcazou > > * ipa-cp.cc (print_ipcp_constant_value): Move to... > (values_equal_for_ipcp_p): Deal with VAR_DECLs from the > constant pool. > * ipa-prop.cc (ipa_print_constant_value): ...here. Likewise. > (ipa_print_node_jump_functions_for_edge): Call the function > ipa_print_constant_value to print IPA_JF_CONST elements. > OK jeff