From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by sourceware.org (Postfix) with ESMTPS id CD4173899035 for ; Tue, 15 Nov 2022 16:23:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CD4173899035 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x436.google.com with SMTP id 140so13103866pfz.6 for ; Tue, 15 Nov 2022 08:23:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ifuz38Bks3eJuJx4IHOM0bx/HYlyuvCVRqFJwYG9cno=; b=dHE0393T/4c79DVxfsNjPOA67lWZXzPHy1zLYYz3RrbSWgy1PMcTT6lsG6coXjRXkU 4+bBw09GgdQ8aRrFjzaQxJQz40QbrzS5mugCF+3v9Wv5/1jhgxLy0Zg0WPRIRpk7HsMO AsWrIFfpF6scoIGl05Ovy5mag4l0mne0C1gLe1eWYscFGmKa3dgq/MaU/KfrTPGSdqjq 6ta97UgaaXWcOuGxVPLBcQMZp0ccwnndTK8ALuZRPxjEIAmQRyL4mNFxoKs1OfywjhEK 510a3Y3QgR70481uyQeJfbh7btqbkAq+wgU8q+WjfjEwooaq4PUXvem5G8QFBM84WSPu fV1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ifuz38Bks3eJuJx4IHOM0bx/HYlyuvCVRqFJwYG9cno=; b=PkIJZOmqGiOFzt3LLH04Ltwpx8UePGpHn2E9QDKjlfxi4Lvx7O4FbKsGK5jTljW+DM 9+hJykyC1ktF3wa26dzIzLMP5lfeJkxiLjVrz4cb+V3p4Mw7QKENi4Xh9ktei2Eebdv9 hb4jICMhvkBFFV79r8m9EPKVUhCisA3b6DrmtkERVFOy4JrggWYyU3Xafm/Djge1C51G /r888AMXj7xV3/InghfilMcj2IKvdSch5LK33e4V7gADduAnpZ4DLD43VvZFhFbFWRmO iocjGbsjDddRJCSgTE5jXF9Bd+k6mgtb4+NVisqmMNfsxGm+teHIEgNpRez1FzGQkawh xSAA== X-Gm-Message-State: ANoB5pl4Kl6pqR8k6Jk1SZQU7hWSRQJMWJVaeZEgRMkHAozZ59oSxKrb At3Pl5LakVAUVj5t0m4Iaks= X-Google-Smtp-Source: AA0mqf718wrFd/1VyJApaznfAUIFcdqjHSnn1Pj0wIHUKOBkU2gkt9UtURbfO8RsFFW/qzMWghsz6Q== X-Received: by 2002:a65:62c7:0:b0:434:1b1b:5706 with SMTP id m7-20020a6562c7000000b004341b1b5706mr16337227pgv.226.1668529385616; Tue, 15 Nov 2022 08:23:05 -0800 (PST) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id u2-20020a170902714200b00185402cfedesm10015997plm.246.2022.11.15.08.23.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Nov 2022 08:23:04 -0800 (PST) Message-ID: <0cc619a4-1ab5-8778-b3db-bff6c37af768@gmail.com> Date: Tue, 15 Nov 2022 09:23:03 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH]middle-end: replace GET_MODE_WIDER_MODE with GET_MODE_NEXT_MODE Content-Language: en-US To: Tamar Christina , Tamar Christina via Gcc-patches , nd , "rguenther@suse.de" , "jlaw@ventanamicro.com" , richard.sandiford@arm.com References: From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-8.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,KAM_MANYTO,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/15/22 07:54, Richard Sandiford via Gcc-patches wrote: > Tamar Christina writes: >>> -----Original Message----- >>> From: Richard Sandiford >>> Sent: Tuesday, November 15, 2022 11:59 AM >>> To: Tamar Christina via Gcc-patches >>> Cc: Tamar Christina ; nd ; >>> rguenther@suse.de; jlaw@ventanamicro.com >>> Subject: Re: [PATCH]middle-end: replace GET_MODE_WIDER_MODE with >>> GET_MODE_NEXT_MODE >>> >>> Tamar Christina via Gcc-patches writes: >>>> Hi All, >>>> >>>> After the fix to the addsub patch yesterday for bootstrap I had only >>> regtested on x86. >>>> While looking today it seemed the new tests were failing, this was >>>> caused by a change in the behavior of the GET_MODE_WIDER_MODE >>> macro on trunk. >>>> This patch fixes that issue. Sorry for the mess, have rebased all branches >>> now. >>>> Bootstrapped Regtested on aarch64-none-linux-gnu and no issues. >>>> >>>> Ok for master? >>>> >>>> Thanks, >>>> Tamar >>>> >>>> gcc/ChangeLog: >>>> >>>> * match.pd: Replace GET_MODE_WIDER_MODE with >>>> GET_MODE_NEXT_MODE. >>>> >>>> --- inline copy of patch -- >>>> diff --git a/gcc/match.pd b/gcc/match.pd index >>>> >>> 1b0ab7cf60fa4772fbe8304c622b0b8fab1bdefa..28191a992039c6f3a1dab5f7c0 >>> e3 >>>> 5dd58dc47092 100644 >>>> --- a/gcc/match.pd >>>> +++ b/gcc/match.pd >>>> @@ -7997,7 +7997,7 @@ and, >>>> machine_mode wide_mode; >>>> } >>>> (if (sel.series_p (0, 2, 0, 2) >>>> - && GET_MODE_WIDER_MODE (vec_mode).exists (&wide_mode) >>>> + && GET_MODE_NEXT_MODE (vec_mode).exists (&wide_mode) >>>> && VECTOR_MODE_P (wide_mode) >>>> && (GET_MODE_UNIT_BITSIZE (vec_mode) * 2 >>>> == GET_MODE_UNIT_BITSIZE (wide_mode))) >>> Does anything guarantee that the next mode will be the right one? >>> It think it would be safer to replace the last three && conditions with: >>> >>> && GET_MODE_2XWIDER_MODE (GET_MODE_INNER (vec_mode)).exists >>> (&wide_elt_mode) >>> && multiple_p (GET_MODE_NUNITS (vec_mode), 2, &wide_nunits) >>> && related_vector_mode (vec_mode, wide_elt_mode, >>> wide_nunits).exists (&wide_mode) >> I see, respun patch accordingly. > LGTM, but I'm nervous when it comes to match.pd stuff so I'd prefer > Richi or Jeff to have the final say. It's just a matter of finding that 2X wider mode to make the transformation possible.  So I don't see any concerns here. jeff