From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by sourceware.org (Postfix) with ESMTPS id 767033857C7D for ; Tue, 12 Jul 2022 18:49:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 767033857C7D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f52.google.com with SMTP id v67-20020a1cac46000000b003a1888b9d36so7292784wme.0 for ; Tue, 12 Jul 2022 11:49:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6dccT0cpp4u4oPM51ElkHPMtUEiR0Bjpk1cW3oEX08Y=; b=IgHdMtRwqNQXKvTTd2yAJRVsXh2EOL4hXt81w1ggS7D6nGRWgQeelRJ09OT8+oYvIH fY2gfMCvSoGz00DfkErPPc/VC9mcTuveUIcntWtasZ+f2Se6gApINDtpi1idTqeP6RCQ VNVo+XqpWVTQN+6+qcWIYEJN9GP4S1Ou1CZMFD5aaPT1sxayzqliG4RFUHRDBG8OzZiR 1Jviii0W8w0RU0CLFeq7ypUmFFqPxf3SvUV3T2899VnjxK17jT/XnnJjViFoRq0dFeAQ lqR29M8Fkisw+OMyx1dGTS/dJ5lpPUqN59QNxSWC7kTeEmihuNW6/siARg7DRonNoGDG 918Q== X-Gm-Message-State: AJIora/+LbTmUNUcG9Db4hmb/Y9P4zZHtLAv0hz+8SxI9VnSN7hDguRW j8o1KFSGJGuOcoj22P+iXPpYe5kXeN8= X-Google-Smtp-Source: AGRyM1sJ2IIcLYcFfYeaQAmlJw0jsvZYxxzQhR/1WDN7BESiyrxV4W7GBbYkGSImY8QqXKlcdNBFCA== X-Received: by 2002:a05:600c:3491:b0:3a0:4d4a:2e2d with SMTP id a17-20020a05600c349100b003a04d4a2e2dmr5740901wmq.4.1657651792850; Tue, 12 Jul 2022 11:49:52 -0700 (PDT) Received: from ?IPv6:2001:8a0:f924:2600:209d:85e2:409e:8726? ([2001:8a0:f924:2600:209d:85e2:409e:8726]) by smtp.gmail.com with ESMTPSA id f12-20020a05600c4e8c00b003a2cf17a894sm14991470wmq.41.2022.07.12.11.49.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Jul 2022 11:49:52 -0700 (PDT) Subject: Re: [PATCH 1/2] Add gcc/make-unique.h To: David Malcolm , Jonathan Wakely Cc: gcc-patches References: <20220712002527.417444-1-dmalcolm@redhat.com> <03b8afc0-b917-e940-4995-9ba5493567c2@palves.net> <7f2ddb2d-da00-6852-339a-86c7d853087f@palves.net> <55f00de5-6c6b-51f3-01d4-5f7710e2c792@palves.net> From: Pedro Alves Message-ID: <0cd5abb1-6832-fa46-c0f3-7000dae97849@palves.net> Date: Tue, 12 Jul 2022 19:49:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jul 2022 18:49:56 -0000 On 2022-07-12 7:36 p.m., David Malcolm wrote: > On Tue, 2022-07-12 at 17:40 +0100, Pedro Alves wrote: >>> >> >> If that's the approach, then GCC should import std::unique_ptr, >> std::move, >> std::foo, std::bar into the gcc namespace too, no?  Are you really >> going >> to propose that? > > Pedro, it feels to me like you're constructing a strawman here. > Neither me nor Jonathan are proposing that. > See my other reply. I am actually appalled at how the conversion seems to have derailed. > I just want to be able to comfortably use std::unique_ptr in GCC in the > places for which it makes sense, and being able to use "make_unique" is > a part of that. My suggestion was simple: wrap your make_unique in namespace gcc, so that later on when we get to C++14, yanking it out causes as little churn as possible, with just a 3 letters for 3 letters replacement. I never thought this would be objectionable. If you don't want to do that, that's fine, the churn will happen in the future, but it's no big deal. You'll get to live with shorter make_unique for a few years (my bet is not forever). > > Hope this is constructive > Dave > >