From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by sourceware.org (Postfix) with ESMTPS id B796E3858D33 for ; Tue, 6 Jun 2023 11:58:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B796E3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-9741a0fd134so1000733966b.0 for ; Tue, 06 Jun 2023 04:58:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686052725; x=1688644725; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qHCOerCK6/nkoex/o918Ja8QUCiDNTdvVfNf6B8hRFE=; b=l76PxbZuk93RduTklxXz9R594VAmFM6UOCcOsj/bnNSy2Nw3XnpNTU8G5zAfNQ5gv+ v1eei8jQfkUJNI1cgDaL5SRwzwBHJldAQ1iWpGKyyyesF9QfeqnXo47Wzd9XKjubRNrV ycZvbo4RBOMOtRNhyaVaqbFnMCicjreOuLLs1vLFKmjnO9RKMWCHtoC2Oy0KcJHAx564 d/+if2HSplMLZ5PkEao+VshFzctMA4NgfzhGP4KifKJnb7DB1H1FqppvzbIWDCSGEKTx /LlNw1fTT/LLEfreMykAZDLXOyQ9qv0pNsSpwJ+5pjxey7GEblc4LnTStwel+uGpvA7U YHvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686052725; x=1688644725; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qHCOerCK6/nkoex/o918Ja8QUCiDNTdvVfNf6B8hRFE=; b=gCYKfWK1k/kwl5+j/VTdMHqhSDe2lnFVps6FYOiGccL/0XiFA0/2GY3E4lbrC1zON0 e4XAK13fgEiYvvbhvz9FkVSVfoxBzt4I5pWUIk9z8ttR0o1yR69AjsRv7Yn4wZOz0O99 ivGF3TPUpWXVDeoGQMN3qz2jfoOoh7rSaAqxxneNxSeht1ukpXUtV1TVWiQvLvQ1jR4m BSJETlwyN1EBNZCeQanh5htruLaz8upsVkdTcpg2Bi9f8KhgMDGspgXu0v5O6hvmE6Hq RG7cebDu5nGBgmUBLEjt61ShvOl4lgLU8h2e91bW0OrJC32RgxKQ9sjz8iXkQL/M/9V8 rD5Q== X-Gm-Message-State: AC+VfDxBeIi08XA2QFyVMnrJABBIUd2kii6TA60KIdyeXrVNCBqYcW+5 GRxHLkEPlWvwX+UPhqiO2bU= X-Google-Smtp-Source: ACHHUZ4M1QpGiEPc2wb/EsNIPEkA0bA3hK5EGQKh5gjfqMtNz7jqo7cueoR6rFM9thxXKC68u/lKqg== X-Received: by 2002:a17:907:7fa2:b0:94a:8291:a1e3 with SMTP id qk34-20020a1709077fa200b0094a8291a1e3mr2502348ejc.74.1686052725397; Tue, 06 Jun 2023 04:58:45 -0700 (PDT) Received: from [192.168.1.23] (ip-046-005-130-086.um12.pools.vodafone-ip.de. [46.5.130.86]) by smtp.gmail.com with ESMTPSA id t26-20020a1709066bda00b0096f6e2f4d9esm5438261ejs.83.2023.06.06.04.58.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Jun 2023 04:58:44 -0700 (PDT) Message-ID: <0ce06b4e-bf90-7733-c77e-f189cb90807e@gmail.com> Date: Tue, 6 Jun 2023 13:58:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Cc: rdapp.gcc@gmail.com, kito.cheng@gmail.com, kito.cheng@sifive.com, palmer@dabbelt.com, palmer@rivosinc.com, jeffreyalaw@gmail.com, pan2.li@intel.com Subject: Re: [PATCH] RISC-V: Add RVV vwmacc/vwmaccu/vwmaccsu combine lowering optmization Content-Language: en-US To: juzhe.zhong@rivai.ai, gcc-patches@gcc.gnu.org References: <20230606095847.171835-1-juzhe.zhong@rivai.ai> From: Robin Dapp In-Reply-To: <20230606095847.171835-1-juzhe.zhong@rivai.ai> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > + rtx ops[] = {operands[0], operands[1], operands[2], operands[3]}; > + riscv_vector::emit_vlmax_ternary_insn (code_for_pred_widen_mul_plus (, mode), > + riscv_vector::RVV_WIDEN_TERNOP, ops); ops is still there ;) No need for another revision though. > +;; This helps to match ext + fma to enhance the combine optimizations. No need for the "to enhance the...".