From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id DF9F43858434 for ; Thu, 24 Feb 2022 10:32:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DF9F43858434 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D5DC821155; Thu, 24 Feb 2022 10:32:53 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B16B613A79; Thu, 24 Feb 2022 10:32:53 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id lFpvKdVeF2JrPwAAMHmgww (envelope-from ); Thu, 24 Feb 2022 10:32:53 +0000 Content-Type: multipart/mixed; boundary="------------etFh0hyuWa6ZgwfYh6mG410O" Message-ID: <0ce14ee6-a677-76a9-7e7a-d99d3927bd8a@suse.de> Date: Thu, 24 Feb 2022 11:32:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [PATCH][libgomp, testsuite, nvptx] Add libgomp.c/declare-variant-3-sm*.c Content-Language: en-US To: Jakub Jelinek Cc: Tobias Burnus , gcc-patches References: <6b0f4fe5-06d4-5ede-5bd1-a53ed82f6d36@suse.de> <221e5215-3b8b-fa9f-4e7b-2faa86b8b991@codesourcery.com> <71e9c008-7ad1-c24f-76eb-6a03180525c4@suse.de> From: Tom de Vries In-Reply-To: X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Feb 2022 10:32:56 -0000 This is a multi-part message in MIME format. --------------etFh0hyuWa6ZgwfYh6mG410O Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/24/22 11:09, Jakub Jelinek wrote: > On Thu, Feb 24, 2022 at 11:01:22AM +0100, Tom de Vries wrote: >> [ was: Re: [Patch] nvptx: Add -mptx=6.0 + -misa=sm_70 ] >> >> On 2/24/22 09:29, Tom de Vries wrote: >>> I'll try to submit a patch with one or more test-cases. >> >> Hi, >> >> These test-cases exercise the omp declare variant construct using the >> available nvptx isas. >> >> OK for trunk? >> >> Thanks, >> - Tom > >> [libgomp, testsuite, nvptx] Add libgomp.c/declare-variant-3-sm*.c >> >> Add openmp test-cases that test the omp declare variant construct: >> ... >> #pragma omp declare variant (f30) match (device={isa("sm_30")}) >> ... >> using the available nvptx isas. >> >> On a Pascal board GT 1030 with sm_61, we have these unsupported: >> ... >> UNSUPPORTED: libgomp.c/declare-variant-3-sm70.c >> UNSUPPORTED: libgomp.c/declare-variant-3-sm75.c >> UNSUPPORTED: libgomp.c/declare-variant-3-sm80.c >> ... >> and on a Turing board T400 with sm_75, we have this only this one: >> ... >> UNSUPPORTED: libgomp.c/declare-variant-3-sm80.c >> ... >> >> Tested on x86_64 with nvptx accelerator. > > I think testing it through dg-do link tests with -fdump-tree-optimized > or so would be better, you wouldn't need access to actual hardware level > and checking in the dump what function is actually called for each case is > easy. > Done, expect for the sm_30 test which is still dg-do run (although I've added the compile time test) which should pass on all boards (since we don't support below sm_30). OK for trunk? Thanks, - Tom --------------etFh0hyuWa6ZgwfYh6mG410O Content-Type: text/x-patch; charset=UTF-8; name="0006-libgomp-testsuite-nvptx-Add-libgomp.c-declare-variant-3-sm-.c.patch" Content-Disposition: attachment; filename*0="0006-libgomp-testsuite-nvptx-Add-libgomp.c-declare-variant-3"; filename*1="-sm-.c.patch" Content-Transfer-Encoding: base64 W2xpYmdvbXAsIHRlc3RzdWl0ZSwgbnZwdHhdIEFkZCBsaWJnb21wLmMvZGVjbGFyZS12YXJp YW50LTMtc20qLmMKCkFkZCBvcGVubXAgdGVzdC1jYXNlcyB0aGF0IHRlc3QgdGhlIG9tcCBk ZWNsYXJlIHZhcmlhbnQgY29uc3RydWN0OgouLi4KICAjcHJhZ21hIG9tcCBkZWNsYXJlIHZh cmlhbnQgKGYzMCkgbWF0Y2ggKGRldmljZT17aXNhKCJzbV8zMCIpfSkKLi4uCnVzaW5nIHRo ZSBhdmFpbGFibGUgbnZwdHggaXNhcy4KCk9ubHkgdGhlIG9uZSBmb3Igc21fMzAgaXMgYSBk Zy1kbyBydW4gdGVzdC1jYXNlLCB0aGUgb3RoZXIgb25lcyBhcmUgZGctZG8KbGluay4KClRl c3RlZCBvbiB4ODZfNjQgd2l0aCBudnB0eCBhY2NlbGVyYXRvci4KCmxpYmdvbXAvQ2hhbmdl TG9nOgoKMjAyMi0wMi0yNCAgVG9tIGRlIFZyaWVzICA8dGRldnJpZXNAc3VzZS5kZT4KCgkq IHRlc3RzdWl0ZS9saWJnb21wLmMvZGVjbGFyZS12YXJpYW50LTMtc20zMC5jOiBOZXcgdGVz dC4KCSogdGVzdHN1aXRlL2xpYmdvbXAuYy9kZWNsYXJlLXZhcmlhbnQtMy1zbTM1LmM6IE5l dyB0ZXN0LgoJKiB0ZXN0c3VpdGUvbGliZ29tcC5jL2RlY2xhcmUtdmFyaWFudC0zLXNtNTMu YzogTmV3IHRlc3QuCgkqIHRlc3RzdWl0ZS9saWJnb21wLmMvZGVjbGFyZS12YXJpYW50LTMt c203MC5jOiBOZXcgdGVzdC4KCSogdGVzdHN1aXRlL2xpYmdvbXAuYy9kZWNsYXJlLXZhcmlh bnQtMy1zbTc1LmM6IE5ldyB0ZXN0LgoJKiB0ZXN0c3VpdGUvbGliZ29tcC5jL2RlY2xhcmUt dmFyaWFudC0zLXNtODAuYzogTmV3IHRlc3QuCgkqIHRlc3RzdWl0ZS9saWJnb21wLmMvZGVj bGFyZS12YXJpYW50LTMuaDogTmV3IGhlYWRlciBmaWxlLgoKLS0tCiAuLi4vdGVzdHN1aXRl L2xpYmdvbXAuYy9kZWNsYXJlLXZhcmlhbnQtMy1zbTMwLmMgICB8ICA3ICsrKwogLi4uL3Rl c3RzdWl0ZS9saWJnb21wLmMvZGVjbGFyZS12YXJpYW50LTMtc20zNS5jICAgfCAgNyArKysK IC4uLi90ZXN0c3VpdGUvbGliZ29tcC5jL2RlY2xhcmUtdmFyaWFudC0zLXNtNTMuYyAgIHwg IDcgKysrCiAuLi4vdGVzdHN1aXRlL2xpYmdvbXAuYy9kZWNsYXJlLXZhcmlhbnQtMy1zbTcw LmMgICB8ICA3ICsrKwogLi4uL3Rlc3RzdWl0ZS9saWJnb21wLmMvZGVjbGFyZS12YXJpYW50 LTMtc203NS5jICAgfCAgNyArKysKIC4uLi90ZXN0c3VpdGUvbGliZ29tcC5jL2RlY2xhcmUt dmFyaWFudC0zLXNtODAuYyAgIHwgIDcgKysrCiBsaWJnb21wL3Rlc3RzdWl0ZS9saWJnb21w LmMvZGVjbGFyZS12YXJpYW50LTMuaCAgICB8IDY2ICsrKysrKysrKysrKysrKysrKysrKysK IDcgZmlsZXMgY2hhbmdlZCwgMTA4IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9saWJn b21wL3Rlc3RzdWl0ZS9saWJnb21wLmMvZGVjbGFyZS12YXJpYW50LTMtc20zMC5jIGIvbGli Z29tcC90ZXN0c3VpdGUvbGliZ29tcC5jL2RlY2xhcmUtdmFyaWFudC0zLXNtMzAuYwpuZXcg ZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMC4uYWQxNjAyYzEzY2QKLS0tIC9k ZXYvbnVsbAorKysgYi9saWJnb21wL3Rlc3RzdWl0ZS9saWJnb21wLmMvZGVjbGFyZS12YXJp YW50LTMtc20zMC5jCkBAIC0wLDAgKzEsNyBAQAorLyogeyBkZy1kbyBydW4geyB0YXJnZXQg eyBvZmZsb2FkX3RhcmdldF9udnB0eCB9IH0gfSAqLworLyogeyBkZy1hZGRpdGlvbmFsLW9w dGlvbnMgIi1mb2ZmbG9hZD0tbWlzYT1zbV8zMCIgfSAqLworLyogeyBkZy1hZGRpdGlvbmFs LW9wdGlvbnMgIi1mb2ZmbG9hZD0tZmR1bXAtdHJlZS1vcHRpbWl6ZWQiIH0gKi8KKworI2lu Y2x1ZGUgImRlY2xhcmUtdmFyaWFudC0zLmgiCisKKy8qIHsgZGctZmluYWwgeyBzY2FuLW9m ZmxvYWQtdHJlZS1kdW1wICI9IGYzMCBcXChcXCk7IiAib3B0aW1pemVkIiB9IH0gKi8KZGlm ZiAtLWdpdCBhL2xpYmdvbXAvdGVzdHN1aXRlL2xpYmdvbXAuYy9kZWNsYXJlLXZhcmlhbnQt My1zbTM1LmMgYi9saWJnb21wL3Rlc3RzdWl0ZS9saWJnb21wLmMvZGVjbGFyZS12YXJpYW50 LTMtc20zNS5jCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwLi4xYTdj ZGEyNDU2YgotLS0gL2Rldi9udWxsCisrKyBiL2xpYmdvbXAvdGVzdHN1aXRlL2xpYmdvbXAu Yy9kZWNsYXJlLXZhcmlhbnQtMy1zbTM1LmMKQEAgLTAsMCArMSw3IEBACisvKiB7IGRnLWRv IGxpbmsgeyB0YXJnZXQgeyBvZmZsb2FkX3RhcmdldF9udnB0eCB9IH0gfSAqLworLyogeyBk Zy1hZGRpdGlvbmFsLW9wdGlvbnMgIi1mb2ZmbG9hZD0tbWlzYT1zbV8zNSIgfSAqLworLyog eyBkZy1hZGRpdGlvbmFsLW9wdGlvbnMgIi1mb2ZmbG9hZD0tZmR1bXAtdHJlZS1vcHRpbWl6 ZWQiIH0gKi8KKworI2luY2x1ZGUgImRlY2xhcmUtdmFyaWFudC0zLmgiCisKKy8qIHsgZGct ZmluYWwgeyBzY2FuLW9mZmxvYWQtdHJlZS1kdW1wICI9IGYzNSBcXChcXCk7IiAib3B0aW1p emVkIiB9IH0gKi8KZGlmZiAtLWdpdCBhL2xpYmdvbXAvdGVzdHN1aXRlL2xpYmdvbXAuYy9k ZWNsYXJlLXZhcmlhbnQtMy1zbTUzLmMgYi9saWJnb21wL3Rlc3RzdWl0ZS9saWJnb21wLmMv ZGVjbGFyZS12YXJpYW50LTMtc201My5jCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAw MDAwMDAwMDAwLi5hMzdiNWZkYWEyOAotLS0gL2Rldi9udWxsCisrKyBiL2xpYmdvbXAvdGVz dHN1aXRlL2xpYmdvbXAuYy9kZWNsYXJlLXZhcmlhbnQtMy1zbTUzLmMKQEAgLTAsMCArMSw3 IEBACisvKiB7IGRnLWRvIGxpbmsgeyB0YXJnZXQgeyBvZmZsb2FkX3RhcmdldF9udnB0eCB9 IH0gfSAqLworLyogeyBkZy1hZGRpdGlvbmFsLW9wdGlvbnMgIi1mb2ZmbG9hZD0tbWlzYT1z bV81MyIgfSAqLworLyogeyBkZy1hZGRpdGlvbmFsLW9wdGlvbnMgIi1mb2ZmbG9hZD0tZmR1 bXAtdHJlZS1vcHRpbWl6ZWQiIH0gKi8KKworI2luY2x1ZGUgImRlY2xhcmUtdmFyaWFudC0z LmgiCisKKy8qIHsgZGctZmluYWwgeyBzY2FuLW9mZmxvYWQtdHJlZS1kdW1wICI9IGY1MyBc XChcXCk7IiAib3B0aW1pemVkIiB9IH0gKi8KZGlmZiAtLWdpdCBhL2xpYmdvbXAvdGVzdHN1 aXRlL2xpYmdvbXAuYy9kZWNsYXJlLXZhcmlhbnQtMy1zbTcwLmMgYi9saWJnb21wL3Rlc3Rz dWl0ZS9saWJnb21wLmMvZGVjbGFyZS12YXJpYW50LTMtc203MC5jCm5ldyBmaWxlIG1vZGUg MTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwLi5hYjAyMmNkNzlmOQotLS0gL2Rldi9udWxsCisr KyBiL2xpYmdvbXAvdGVzdHN1aXRlL2xpYmdvbXAuYy9kZWNsYXJlLXZhcmlhbnQtMy1zbTcw LmMKQEAgLTAsMCArMSw3IEBACisvKiB7IGRnLWRvIGxpbmsgeyB0YXJnZXQgeyBvZmZsb2Fk X3RhcmdldF9udnB0eCB9IH0gfSAqLworLyogeyBkZy1hZGRpdGlvbmFsLW9wdGlvbnMgIi1m b2ZmbG9hZD0tbWlzYT1zbV83MCIgfSAqLworLyogeyBkZy1hZGRpdGlvbmFsLW9wdGlvbnMg Ii1mb2ZmbG9hZD0tZmR1bXAtdHJlZS1vcHRpbWl6ZWQiIH0gKi8KKworI2luY2x1ZGUgImRl Y2xhcmUtdmFyaWFudC0zLmgiCisKKy8qIHsgZGctZmluYWwgeyBzY2FuLW9mZmxvYWQtdHJl ZS1kdW1wICI9IGY3MCBcXChcXCk7IiAib3B0aW1pemVkIiB9IH0gKi8KZGlmZiAtLWdpdCBh L2xpYmdvbXAvdGVzdHN1aXRlL2xpYmdvbXAuYy9kZWNsYXJlLXZhcmlhbnQtMy1zbTc1LmMg Yi9saWJnb21wL3Rlc3RzdWl0ZS9saWJnb21wLmMvZGVjbGFyZS12YXJpYW50LTMtc203NS5j Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwLi43ZDA5MTk1ZDljNAot LS0gL2Rldi9udWxsCisrKyBiL2xpYmdvbXAvdGVzdHN1aXRlL2xpYmdvbXAuYy9kZWNsYXJl LXZhcmlhbnQtMy1zbTc1LmMKQEAgLTAsMCArMSw3IEBACisvKiB7IGRnLWRvIGxpbmsgeyB0 YXJnZXQgeyBvZmZsb2FkX3RhcmdldF9udnB0eCB9IH0gfSAqLworLyogeyBkZy1hZGRpdGlv bmFsLW9wdGlvbnMgIi1mb2ZmbG9hZD0tbWlzYT1zbV83NSIgfSAqLworLyogeyBkZy1hZGRp dGlvbmFsLW9wdGlvbnMgIi1mb2ZmbG9hZD0tZmR1bXAtdHJlZS1vcHRpbWl6ZWQiIH0gKi8K KworI2luY2x1ZGUgImRlY2xhcmUtdmFyaWFudC0zLmgiCisKKy8qIHsgZGctZmluYWwgeyBz Y2FuLW9mZmxvYWQtdHJlZS1kdW1wICI9IGY3NSBcXChcXCk7IiAib3B0aW1pemVkIiB9IH0g Ki8KZGlmZiAtLWdpdCBhL2xpYmdvbXAvdGVzdHN1aXRlL2xpYmdvbXAuYy9kZWNsYXJlLXZh cmlhbnQtMy1zbTgwLmMgYi9saWJnb21wL3Rlc3RzdWl0ZS9saWJnb21wLmMvZGVjbGFyZS12 YXJpYW50LTMtc204MC5jCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAw Li44OThhZTZlNGRhOAotLS0gL2Rldi9udWxsCisrKyBiL2xpYmdvbXAvdGVzdHN1aXRlL2xp YmdvbXAuYy9kZWNsYXJlLXZhcmlhbnQtMy1zbTgwLmMKQEAgLTAsMCArMSw3IEBACisvKiB7 IGRnLWRvIGxpbmsgeyB0YXJnZXQgeyBvZmZsb2FkX3RhcmdldF9udnB0eCB9IH0gfSAqLwor LyogeyBkZy1hZGRpdGlvbmFsLW9wdGlvbnMgIi1mb2ZmbG9hZD0tbWlzYT1zbV84MCIgfSAq LworLyogeyBkZy1hZGRpdGlvbmFsLW9wdGlvbnMgIi1mb2ZmbG9hZD0tZmR1bXAtdHJlZS1v cHRpbWl6ZWQiIH0gKi8KKworI2luY2x1ZGUgImRlY2xhcmUtdmFyaWFudC0zLmgiCisKKy8q IHsgZGctZmluYWwgeyBzY2FuLW9mZmxvYWQtdHJlZS1kdW1wICI9IGY4MCBcXChcXCk7IiAi b3B0aW1pemVkIiB9IH0gKi8KZGlmZiAtLWdpdCBhL2xpYmdvbXAvdGVzdHN1aXRlL2xpYmdv bXAuYy9kZWNsYXJlLXZhcmlhbnQtMy5oIGIvbGliZ29tcC90ZXN0c3VpdGUvbGliZ29tcC5j L2RlY2xhcmUtdmFyaWFudC0zLmgKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAw MDAwMDAuLjc3MmZjMjBhNTE5Ci0tLSAvZGV2L251bGwKKysrIGIvbGliZ29tcC90ZXN0c3Vp dGUvbGliZ29tcC5jL2RlY2xhcmUtdmFyaWFudC0zLmgKQEAgLTAsMCArMSw2NiBAQAorI3By YWdtYSBvbXAgZGVjbGFyZSB0YXJnZXQKK2ludAorZjMwICh2b2lkKQoreworICByZXR1cm4g MzA7Cit9CisKK2ludAorZjM1ICh2b2lkKQoreworICByZXR1cm4gMzU7Cit9CisKK2ludAor ZjUzICh2b2lkKQoreworICByZXR1cm4gNTM7Cit9CisKK2ludAorZjcwICh2b2lkKQorewor ICByZXR1cm4gNzA7Cit9CisKK2ludAorZjc1ICh2b2lkKQoreworICByZXR1cm4gNzU7Cit9 CisKK2ludAorZjgwICh2b2lkKQoreworICByZXR1cm4gODA7Cit9CisKKyNwcmFnbWEgb21w IGRlY2xhcmUgdmFyaWFudCAoZjMwKSBtYXRjaCAoZGV2aWNlPXtpc2EoInNtXzMwIil9KQor I3ByYWdtYSBvbXAgZGVjbGFyZSB2YXJpYW50IChmMzUpIG1hdGNoIChkZXZpY2U9e2lzYSgi c21fMzUiKX0pCisjcHJhZ21hIG9tcCBkZWNsYXJlIHZhcmlhbnQgKGY1MykgbWF0Y2ggKGRl dmljZT17aXNhKCJzbV81MyIpfSkKKyNwcmFnbWEgb21wIGRlY2xhcmUgdmFyaWFudCAoZjcw KSBtYXRjaCAoZGV2aWNlPXtpc2EoInNtXzcwIil9KQorI3ByYWdtYSBvbXAgZGVjbGFyZSB2 YXJpYW50IChmNzUpIG1hdGNoIChkZXZpY2U9e2lzYSgic21fNzUiKX0pCisjcHJhZ21hIG9t cCBkZWNsYXJlIHZhcmlhbnQgKGY4MCkgbWF0Y2ggKGRldmljZT17aXNhKCJzbV84MCIpfSkK K2ludAorZiAodm9pZCkKK3sKKyAgcmV0dXJuIDA7Cit9CisKKyNwcmFnbWEgb21wIGVuZCBk ZWNsYXJlIHRhcmdldAorCitpbnQKK21haW4gKHZvaWQpCit7CisgIGludCB2ID0gMDsKKwor ICAjcHJhZ21hIG9tcCB0YXJnZXQgbWFwKGZyb206dikKKyAgdiA9IGYgKCk7CisKKyAgaWYg KHYgPT0gMCkKKyAgICBfX2J1aWx0aW5fYWJvcnQgKCk7CisKKyAgX19idWlsdGluX3ByaW50 ZiAoIk52cHR4IGFjY2VsZXJhdG9yOiBzbV8lZFxuIiwgdik7CisKKyAgcmV0dXJuIDA7Cit9 Cg== --------------etFh0hyuWa6ZgwfYh6mG410O--