From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id B262B385DC31 for ; Wed, 30 Mar 2022 17:41:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B262B385DC31 Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 22UGOjEn029692; Wed, 30 Mar 2022 17:41:12 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 3f4s13uytg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 30 Mar 2022 17:41:12 +0000 Received: from m0098404.ppops.net (m0098404.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 22UHRUeb029892; Wed, 30 Mar 2022 17:41:11 GMT Received: from ppma02dal.us.ibm.com (a.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.10]) by mx0a-001b2d01.pphosted.com with ESMTP id 3f4s13uyt0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 30 Mar 2022 17:41:11 +0000 Received: from pps.filterd (ppma02dal.us.ibm.com [127.0.0.1]) by ppma02dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 22UHdXHO026642; Wed, 30 Mar 2022 17:41:10 GMT Received: from b01cxnp22035.gho.pok.ibm.com (b01cxnp22035.gho.pok.ibm.com [9.57.198.25]) by ppma02dal.us.ibm.com with ESMTP id 3f1tfa6cup-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 30 Mar 2022 17:41:10 +0000 Received: from b01ledav006.gho.pok.ibm.com (b01ledav006.gho.pok.ibm.com [9.57.199.111]) by b01cxnp22035.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 22UHfArs25100662 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 30 Mar 2022 17:41:10 GMT Received: from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 01A9AAC062; Wed, 30 Mar 2022 17:41:10 +0000 (GMT) Received: from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 86C8BAC05B; Wed, 30 Mar 2022 17:41:09 +0000 (GMT) Received: from lexx (unknown [9.160.85.114]) by b01ledav006.gho.pok.ibm.com (Postfix) with ESMTP; Wed, 30 Mar 2022 17:41:09 +0000 (GMT) Message-ID: <0ce7a113e2592c84f718be67c1f94b6ddda93eea.camel@vnet.ibm.com> Subject: Re: [PATCH 8/8] rs6000: Fix some missing built-in attributes [PR104004] From: will schmidt To: Bill Schmidt , gcc-patches@gcc.gnu.org Cc: dje.gcc@gmail.com, segher@kernel.crashing.org, jakub Date: Wed, 30 Mar 2022 12:41:09 -0500 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-18.el8) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: tcgycDG_kDzMEPJvZV7Bo5XvIwhd5hNX X-Proofpoint-GUID: vyB4tj23tY9FISwOQaF5xN1C45Hano_o X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.850,Hydra:6.0.425,FMLib:17.11.64.514 definitions=2022-03-30_06,2022-03-30_01,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 malwarescore=0 clxscore=1015 priorityscore=1501 mlxscore=0 spamscore=0 lowpriorityscore=0 impostorscore=0 suspectscore=0 mlxlogscore=999 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2203300086 X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Mar 2022 17:41:15 -0000 On Fri, 2022-01-28 at 11:50 -0600, Bill Schmidt via Gcc-patches wrote: > PR104004 caught some misses on my part in converting to the new > built-in > function infrastructure. In particular, I forgot to mark all of the > "nosoft" > built-ins, and one of those should also have been marked "no32bit". > > Bootstrapped and tested on powerpc64le-linux-gnu with no regressions. > Is this okay for trunk? > > Thanks, > Bill > Hi, The patch here seems reasonable to me. There are comments/subsequent pings that include commentary about additional test coverage. I see all of the builtins referenced here appear to be touched by the existing test gcc.target/powerpc/test_fpscr_drn_builtin.c . I could create a variation of that test forcing ! hard_dfp in case that would help, though i'm uncertain the value there. Thanks -Will > > 2022-01-27 Bill Schmidt > > gcc/ > * config/rs6000/rs6000-builtin.def (MFFSL): Mark nosoft. > (MTFSB0): Likewise. > (MTFSB1): Likewise. > (SET_FPSCR_RN): Likewise. > (SET_FPSCR_DRN): Mark nosoft and no32bit. > --- > gcc/config/rs6000/rs6000-builtins.def | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/gcc/config/rs6000/rs6000-builtins.def > b/gcc/config/rs6000/rs6000-builtins.def > index c8f0cf332eb..98619a649e3 100644 > --- a/gcc/config/rs6000/rs6000-builtins.def > +++ b/gcc/config/rs6000/rs6000-builtins.def > @@ -215,7 +215,7 @@ > ; processors, this builtin automatically falls back to mffs on older > ; platforms. Thus it appears here in the [always] stanza. > double __builtin_mffsl (); > - MFFSL rs6000_mffsl {} > + MFFSL rs6000_mffsl {nosoft} > > ; This is redundant with __builtin_pack_ibm128, as it requires long > ; double to be __ibm128. Should probably be deprecated. > @@ -226,10 +226,10 @@ > MFTB rs6000_mftb_di {32bit} > > void __builtin_mtfsb0 (const int<0,31>); > - MTFSB0 rs6000_mtfsb0 {} > + MTFSB0 rs6000_mtfsb0 {nosoft} > > void __builtin_mtfsb1 (const int<0,31>); > - MTFSB1 rs6000_mtfsb1 {} > + MTFSB1 rs6000_mtfsb1 {nosoft} > > void __builtin_mtfsf (const int<0,255>, double); > MTFSF rs6000_mtfsf {} > @@ -238,7 +238,7 @@ > PACK_IF packif {} > > void __builtin_set_fpscr_rn (const int[0,3]); > - SET_FPSCR_RN rs6000_set_fpscr_rn {} > + SET_FPSCR_RN rs6000_set_fpscr_rn {nosoft} > > const double __builtin_unpack_ibm128 (__ibm128, const int<0,1>); > UNPACK_IF unpackif {} > @@ -2969,7 +2969,7 @@ > PACK_TD packtd {} > > void __builtin_set_fpscr_drn (const int[0,7]); > - SET_FPSCR_DRN rs6000_set_fpscr_drn {} > + SET_FPSCR_DRN rs6000_set_fpscr_drn {nosoft,no32bit} > > const unsigned long long __builtin_unpack_dec128 (_Decimal128, \ > const int<0,1>);