From: "Martin Liška" <mliska@suse.cz>
To: Nathan Sidwell <nathan@acm.org>, gcc-patches@gcc.gnu.org
Cc: hubicka@ucw.cz
Subject: Re: [PATCH 0/8] GCOV improvements
Date: Fri, 28 Apr 2017 12:16:00 -0000 [thread overview]
Message-ID: <0cecddcc-12ee-8b7f-6e75-947e58ff53d0@suse.cz> (raw)
In-Reply-To: <9d4c64ec-bea3-ba4d-c6bc-760af42850d5@acm.org>
On 04/28/2017 01:49 PM, Nathan Sidwell wrote:
> On 04/28/2017 05:26 AM, marxin wrote:
>> Hi.
>>
>> Following patch series improves the infrastructure, fixes couple of issues
>> and hopefully improves also documentation of the functionality.
>> I decided to split the changes into various patches to make it easier
>> for reviewers.
>
> thanks for doing this. I think I've reviewed all of them, but they turned up in my inbox this morning with funky dates from the past few days.
Hi.
I thank you for very fast review. Yep, you replied all of them. It's caused by fact that commiter date != author date in git.
Next time, I'll be more patient and eventually run rebase that will modify that ([1]).
I'm planning to include the simple ones (not requesting infrastructure changes) to backport.
What's your opinion about doc changes, should I include that as well?
[1] http://stackoverflow.com/questions/1579643/change-timestamps-while-rebasing-git-branch/7352870#7352870
Martin
>
> nathan
>
next prev parent reply other threads:[~2017-04-28 11:57 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-28 9:31 marxin
2017-04-28 9:31 ` [PATCH 5/8] Make gcno more precise about BBs really belonging to a line (PR gcov-profile/79891) marxin
2017-04-28 11:47 ` Nathan Sidwell
2017-04-28 13:06 ` Martin Liška
2017-04-28 9:31 ` [PATCH 2/8] Remove .gcno file when compilation does not success (PR driver/56469) marxin
2017-04-28 12:00 ` Nathan Sidwell
2017-04-28 9:31 ` [PATCH 1/8] gcno file: do not stream block flags (PR gcov-profile/80031) marxin
2017-04-28 11:48 ` Nathan Sidwell
2017-04-28 9:31 ` [PATCH 6/8] Fix format_gcov to not print misleading values (PR gcov-profile/53915) marxin
2017-04-28 11:38 ` Nathan Sidwell
2017-04-28 9:31 ` [PATCH 4/8] Introduce new option -w which shows verbose informations marxin
2017-04-28 11:41 ` Nathan Sidwell
2017-04-28 10:58 ` [PATCH 7/8] Sort options of gcov, gcov-dump and gcov-tool both in --help and documentation marxin
2017-04-28 11:32 ` Nathan Sidwell
2017-04-28 11:25 ` [PATCH 8/8] Enhance documentation of gcov marxin
2017-04-28 11:35 ` Nathan Sidwell
2017-04-29 3:20 ` Martin Sebor
2018-07-22 8:40 ` Gerald Pfeifer
2017-04-28 11:26 ` [PATCH 3/8] Simplify representation of locations of a block marxin
2017-04-28 11:57 ` Nathan Sidwell
2017-04-28 16:40 ` Martin Sebor
2017-04-28 17:48 ` Nathan Sidwell
2017-05-02 15:38 ` [PATCH] Fix documentation and a ctor in gcov.c Martin Liška
2017-05-03 13:20 ` Nathan Sidwell
2017-04-28 19:13 ` [PATCH 3/8] Simplify representation of locations of a block Pedro Alves
2017-04-28 19:46 ` Martin Sebor
2017-04-28 20:07 ` Pedro Alves
2017-04-28 12:03 ` [PATCH 0/8] GCOV improvements Nathan Sidwell
2017-04-28 12:16 ` Martin Liška [this message]
2017-04-29 16:31 ` Gerald Pfeifer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0cecddcc-12ee-8b7f-6e75-947e58ff53d0@suse.cz \
--to=mliska@suse.cz \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
--cc=nathan@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).