From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 928E63858404 for ; Wed, 6 Jul 2022 15:29:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 928E63858404 Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-478-atL-uyOZNoSiDb-IrwBpvw-1; Wed, 06 Jul 2022 11:29:42 -0400 X-MC-Unique: atL-uyOZNoSiDb-IrwBpvw-1 Received: by mail-qk1-f198.google.com with SMTP id 194-20020a3704cb000000b006af069d1e0aso14889765qke.15 for ; Wed, 06 Jul 2022 08:29:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=t55kOTCv+xhH9LUh2nLNASe2qPSUtnUc2Jd3feJj5GE=; b=UVfV1fL33MeDrNoiE27CmM3uoEAr/5v3xrRtjxKefLZnPqvZziJpIyHJyDkQipTnnY Jrc+mvzaMl+22ErDvnENgH2r0tkNaRjeyC0IzJVnfL7YyuBLoppvvaTUwjENDYtjZfZQ i5rOyI3FnJEpIAV4/XgQ3nshf9h1/j3TXgr7cpmTl/N8bk381iX/UgjHFBar+BxOlKM/ m+8qgrqsAIui8s4SDvzOuoxV0vnUa9mvmOi+q3DnkAqhRaOpQr2c/DXD9+zuzpCgcnhG mPVLArqs0IKNm3CzQyhKA/CmSmOP4ForIQjs9dJhYFqZy9u6lLuip6B3OtVuSRnyQWTM w+WA== X-Gm-Message-State: AJIora8oV2F47/xOHL2C7nZfCzY0pIBX2zapIGv+47acj5t0TWZJK+93 lmeXiJyVvBTlVBEwZO27a8vLAvgzZ+UrKCxDaFDeLJ9mx5uRyQNT9kKQi22yKk9lhkt/n4sRkkV cvDNs6letaRA0Y/Vicw== X-Received: by 2002:a37:4644:0:b0:6af:271e:a510 with SMTP id t65-20020a374644000000b006af271ea510mr28260834qka.515.1657121381728; Wed, 06 Jul 2022 08:29:41 -0700 (PDT) X-Google-Smtp-Source: AGRyM1v/bh0rLnLCNHg6yPF97D0A5rOSJdofQcgru1BLnmAKiYCDzjNDThiiiO58A2dOARg/ILQXnQ== X-Received: by 2002:a37:4644:0:b0:6af:271e:a510 with SMTP id t65-20020a374644000000b006af271ea510mr28260823qka.515.1657121381492; Wed, 06 Jul 2022 08:29:41 -0700 (PDT) Received: from t14s.localdomain (c-73-69-212-193.hsd1.nh.comcast.net. [73.69.212.193]) by smtp.gmail.com with ESMTPSA id f8-20020ac84988000000b002f93ece0df3sm24184928qtq.71.2022.07.06.08.29.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Jul 2022 08:29:40 -0700 (PDT) Message-ID: <0d0420acd29e5b6ab8459d2ff11bc15bbbd27394.camel@redhat.com> Subject: Re: [PATCH 2/3] analyzer: reorder initialization of state m_invalid in sm-fd.cc [PR106184] From: David Malcolm To: mirimnan017@gmail.com, gcc-patches@gcc.gnu.org Cc: Immad Mir , Immad Mir Date: Wed, 06 Jul 2022 11:29:39 -0400 In-Reply-To: References: <20220706142543.3790-1-mirimmad@outlook.com> User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00, BODY_8BITS, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Jul 2022 15:29:44 -0000 On Wed, 2022-07-06 at 19:55 +0530, Immad Mir wrote: > From: Immad Mir > > This patch reorders the initialization of state m_invalid in sm-fd.cc > to conform with standard practice in C++. Might want to reword to say that the order of the initializers is now the same as the ordering of the fields in the class decl, or somesuch. I think I already approved this; it's OK to push this to trunk. Thanks Dave > > > gcc/analyzer/ChangeLog: >         PR analyzer/106184 >         * sm-fd.cc (fd_state_machine): Change ordering of > initialization >         of state m_invalid. > > Signed-off-by: Immad Mir > --- >  gcc/analyzer/sm-fd.cc | 5 +++-- >  1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/gcc/analyzer/sm-fd.cc b/gcc/analyzer/sm-fd.cc > index 8196d33223a..8e4300b06e2 100644 > --- a/gcc/analyzer/sm-fd.cc > +++ b/gcc/analyzer/sm-fd.cc > @@ -551,11 +551,12 @@ fd_state_machine::fd_state_machine (logger > *logger) >        m_unchecked_read_write (add_state ("fd-unchecked-read-write")), >        m_unchecked_read_only (add_state ("fd-unchecked-read-only")), >        m_unchecked_write_only (add_state ("fd-unchecked-write-only")), > -      m_invalid (add_state ("fd-invalid")), >        m_valid_read_write (add_state ("fd-valid-read-write")), >        m_valid_read_only (add_state ("fd-valid-read-only")), >        m_valid_write_only (add_state ("fd-valid-write-only")), > -      m_closed (add_state ("fd-closed")), m_stop (add_state ("fd- > stop")) > +      m_invalid (add_state ("fd-invalid")), > +      m_closed (add_state ("fd-closed")), > +      m_stop (add_state ("fd-stop")) >  { >  } >