From: Jeff Law <jeffreyalaw@gmail.com>
To: Robin Dapp <rdapp.gcc@gmail.com>,
gcc-patches <gcc-patches@gcc.gnu.org>,
palmer <palmer@dabbelt.com>, Kito Cheng <kito.cheng@gmail.com>,
"juzhe.zhong@rivai.ai" <juzhe.zhong@rivai.ai>
Subject: Re: [PATCH] RISC-V: Add autovec FP widening/narrowing.
Date: Mon, 26 Jun 2023 15:55:18 -0600 [thread overview]
Message-ID: <0d3411d6-bee4-db3a-a0eb-e679059f5f23@gmail.com> (raw)
In-Reply-To: <89b515c2-df12-156e-c116-02f711a911d5@gmail.com>
On 6/26/23 12:58, Robin Dapp wrote:
> Hi,
>
> this patch adds FP widening and narrowing autovec expanders as well as
> tests. Conceptually similar to integer extension/truncation, we emulate
> _Float16 -> double by two vfwcvts and double -> _Float16 by two vfncvts.
>
> Optimizations to create widening operations will be added separately.
>
> Regards
> Robin
>
> gcc/ChangeLog:
>
> * config/riscv/autovec.md (extend<v_double_trunc><mode>2): New
> expander.
> (extend<v_quad_trunc><mode>2): Dito.
> (trunc<mode><v_double_trunc>2): Dito.
> (trunc<mode><v_quad_trunc>2): Dito.
> * config/riscv/vector-iterators.md: Add VQEXTF and HF to
> V_QUAD_TRUNC and v_quad_trunc.
It looks like you fixed the type of trunc<mode><vdouble_trunc>2 to be a
narrowing vector shift from just a vector shift. This isn't reflected
in the ChangeLog.
I wasn't aware that "Dito" was an accepted spelling. I had to look it
up ;-)
OK with the ChangeLog fixed.
jeff
prev parent reply other threads:[~2023-06-26 21:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-26 18:58 Robin Dapp
2023-06-26 21:55 ` 钟居哲
2023-06-26 21:55 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d3411d6-bee4-db3a-a0eb-e679059f5f23@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=juzhe.zhong@rivai.ai \
--cc=kito.cheng@gmail.com \
--cc=palmer@dabbelt.com \
--cc=rdapp.gcc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).