From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from xry111.site (xry111.site [89.208.246.23]) by sourceware.org (Postfix) with ESMTPS id 218553858D28 for ; Thu, 23 Nov 2023 08:54:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 218553858D28 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=xry111.site Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=xry111.site ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 218553858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=89.208.246.23 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700729693; cv=none; b=ZEE5SpfElc3dbzgO2Vd/wGgfXPpxOfXugk/rUjEqLyim7p7HISvd+wUhymOaK3TmRbJk5k3mT1xpoTMo2e0l2J/ipf7h+EOIr98kvqkx4YNryPt3bdRnXVlUeMCb+8PtjT+IviU5Es8339y8C64WrI+dUa/PyfF/vTc5FCO0S54= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700729693; c=relaxed/simple; bh=XnCuZo16C8Jdxb3rqf+B3MK5FI3kHpoUVfUogo3Fj04=; h=DKIM-Signature:Message-ID:Subject:From:To:Date:MIME-Version; b=e46lO0wXA9vSPAZnxaRt10IKD3HjfEn2VbdfDyFY8fXoxWeUWAqaBRU5DXvxsPZJ0iMTi6Vbc1HEWkhCxOynQfV+lETnzVBY5jySPqRmWq35BpbyxCxzAuub61uavkF2dMna6qiH1AoAQa0l73u9iSAk/nVGPbqpYlu0yczzaiU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xry111.site; s=default; t=1700729690; bh=XnCuZo16C8Jdxb3rqf+B3MK5FI3kHpoUVfUogo3Fj04=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=OvneASheoGBDnIDw5NtHezZ0PH9JXE3TrBBcvG70TucrWZTQonsbDff0+Qd3V+C5/ 17JAXWxixgmdW5GCTMExjI2jM30Mtoij/31rtZhK6Yw0AvngxmzkqwedgL62Hx2Cru epcbwlH7BjSklFLQYTWLUNk+GovjmE5v3gC2K2Ic= Received: from [127.0.0.1] (unknown [IPv6:2001:470:683e::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) (Authenticated sender: xry111@xry111.site) by xry111.site (Postfix) with ESMTPSA id 483B466B3A; Thu, 23 Nov 2023 03:54:49 -0500 (EST) Message-ID: <0d3597435bb49e534ef00300ea80c3a4934fe757.camel@xry111.site> Subject: Re: [PATCH v3 1/5] LoongArch: Fix usage of LSX and LASX frint/ftint instructions [PR112578] From: Xi Ruoyao To: chenglulu , gcc-patches@gcc.gnu.org Cc: i@xen0n.name, xuchenghua@loongson.cn Date: Thu, 23 Nov 2023 16:54:46 +0800 In-Reply-To: References: <20231120004728.205167-1-xry111@xry111.site> <20231120004728.205167-2-xry111@xry111.site> <2d1c9d59544d15ef7fba07d758431da840cc0bfe.camel@xry111.site> Autocrypt: addr=xry111@xry111.site; prefer-encrypt=mutual; keydata=mDMEYnkdPhYJKwYBBAHaRw8BAQdAsY+HvJs3EVKpwIu2gN89cQT/pnrbQtlvd6Yfq7egugi0HlhpIFJ1b3lhbyA8eHJ5MTExQHhyeTExMS5zaXRlPoiTBBMWCgA7FiEEkdD1djAfkk197dzorKrSDhnnEOMFAmJ5HT4CGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQrKrSDhnnEOPHFgD8D9vUToTd1MF5bng9uPJq5y3DfpcxDp+LD3joA3U2TmwA/jZtN9xLH7CGDHeClKZK/ZYELotWfJsqRcthOIGjsdAPuDgEYnkdPhIKKwYBBAGXVQEFAQEHQG+HnNiPZseiBkzYBHwq/nN638o0NPwgYwH70wlKMZhRAwEIB4h4BBgWCgAgFiEEkdD1djAfkk197dzorKrSDhnnEOMFAmJ5HT4CGwwACgkQrKrSDhnnEOPjXgD/euD64cxwqDIqckUaisT3VCst11RcnO5iRHm6meNIwj0BALLmWplyi7beKrOlqKfuZtCLbiAPywGfCNg8LOTt4iMD Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.1 MIME-Version: 1.0 X-Spam-Status: No, score=-0.2 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,LIKELY_SPAM_FROM,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 2023-11-23 at 15:31 +0800, chenglulu wrote: > I modified this code to use define_expand: >=20 > =C2=A0=C2=A0=C2=A0=C2=A0 (define_expand "fix_trunc2" > =C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 [(set (match_operand: 0 "register= _operand" "=3Df") > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0 (fix: (match_operand:FVEC 1 "register_operand" "f")))] > =C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 "" > =C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0 { > =C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 emit_insn (gen__= vftintrz__ ( > =C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 operands[0], oper= ands[1])); > =C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 DONE; > =C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0 } > =C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0 [(set_attr "type" "simd_fcvt") > =C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0 (set_attr "mode" "")]) For float x[4]; int y[4]; void test() { for (int i =3D 0; i < 4; i++) y[i] =3D __builtin_rintf(x[i]); } it produces la.local $r12,.LANCHOR0 vld $vr0,$r12,0 vfrint.s $vr0,$vr0 vftintrz.w.s $vr0,$vr0 vst $vr0,$r12,16 jr $r1 But with a define_insn or define_insn_and_split: la.local $r12,.LANCHOR0 vld $vr0,$r12,0 vftint.w.s $vr0,$vr0 vst $vr0,$r12,16 jr $r1 (Our scalar code also generates sub-optimal frint.s-ftintxx.w.s sequences. I guess should fix the scalar code later as well.) --=20 Xi Ruoyao School of Aerospace Science and Technology, Xidian University