From: Xi Ruoyao <xry111@xry111.site>
To: Joseph Myers <joseph@codesourcery.com>
Cc: gcc-patches@gcc.gnu.org, chenglulu <chenglulu@loongson.cn>,
i@xen0n.name, xuchenghua@loongson.cn
Subject: Re: [PATCH v2 2/6] LoongArch: genopts: Add infrastructure to generate code for new features in ISA evolution
Date: Tue, 21 Nov 2023 08:00:43 +0800 [thread overview]
Message-ID: <0d3b2d5dc3a192952d03d874d2330759b9e97033.camel@xry111.site> (raw)
In-Reply-To: <74823bfa-1b5c-1790-9fc6-ab97adc1a515@codesourcery.com>
On Mon, 2023-11-20 at 23:15 +0000, Joseph Myers wrote:
> On Sat, 18 Nov 2023, Xi Ruoyao wrote:
>
> > diff --git a/gcc/config/loongarch/loongarch-def.h b/gcc/config/loongarch/loongarch-def.h
> > index b319cded456..6123c8e0f19 100644
> > --- a/gcc/config/loongarch/loongarch-def.h
> > +++ b/gcc/config/loongarch/loongarch-def.h
> > @@ -46,6 +46,7 @@ along with GCC; see the file COPYING3. If not see
> > #ifndef LOONGARCH_DEF_H
> > #define LOONGARCH_DEF_H
> >
> > +#include <stdint.h>
> > #include "loongarch-tune.h"
> >
> > #ifdef __cplusplus
>
> This has broken libgcc builds when target libc isn't yet available.
>
> In file included from /scratch/jmyers/glibc-bot/src/gcc/libgcc/../gcc/config/loongarch/loongarch-def.h:49,
> from /scratch/jmyers/glibc-bot/src/gcc/libgcc/../gcc/config/loongarch/loongarch-opts.h:24,
> from ../.././gcc/options.h:8,
> from ../.././gcc/tm.h:49,
> from /scratch/jmyers/glibc-bot/src/gcc/libgcc/libgcc2.c:29:
> /scratch/jmyers/glibc-bot/build/compilers/loongarch64-linux-gnu-lp64d/gcc-first/gcc/include/stdint.h:9:16: fatal error: stdint.h: No such file or directory
> 9 | # include_next <stdint.h>
> | ^~~~~~~~~~
> compilation terminated.
> make[3]: *** [Makefile:505: _muldi3.o] Error 1
>
> https://sourceware.org/pipermail/libc-testresults/2023q4/012109.html
>
> My guess would be that the definitions needing <stdint.h> are not actually
> needed in code built for the target, and so there should be more
>
> #if !defined(IN_LIBGCC2) && !defined(IN_TARGET_LIBS) && !defined(IN_RTS)
>
> conditions like the one already present in loongarch-opts.h, to avoid
> depending on a target header like this being present.
Ah, makes sense. I thought stdint.h was usable without libc but it's
not true.
The only use for stdint.h is in struct loongarch_isa (using int64_t for
a 64-bit bitset). This struct is not used by target code.
I'll test building a cross compiler from x86_64 with stdint.h and struct
loongarch_isa guarded with the ifdef.
--
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University
next prev parent reply other threads:[~2023-11-21 0:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-17 20:43 [PATCH v2 0/6] Add LoongArch v1.1 div32 and ld-seq-sa support Xi Ruoyao
2023-11-17 20:43 ` [PATCH v2 1/6] LoongArch: Fix internal error running "gcc -march=native" on LA664 Xi Ruoyao
2023-11-17 20:43 ` [PATCH v2 2/6] LoongArch: genopts: Add infrastructure to generate code for new features in ISA evolution Xi Ruoyao
2023-11-20 23:15 ` Joseph Myers
2023-11-21 0:00 ` Xi Ruoyao [this message]
2023-11-21 3:09 ` Pushed: LoongArch: Fix libgcc build failure when libc is not available (was Re: genopts: Add infrastructure to generate code for new features in ISA evolution) Xi Ruoyao
2023-11-21 14:16 ` Jeff Law
2023-11-17 20:43 ` [PATCH v2 3/6] LoongArch: Add evolution features of base ISA revisions Xi Ruoyao
2023-11-17 20:43 ` [PATCH v2 4/6] LoongArch: Take the advantage of -mdiv32 if it's enabled Xi Ruoyao
2023-11-17 20:43 ` [PATCH v2 5/6] LoongArch: Don't emit dbar 0x700 if -mld-seq-sa Xi Ruoyao
2023-11-17 20:43 ` [PATCH v2 6/6] LoongArch: Add fine-grained control for LAM_BH and LAMCAS Xi Ruoyao
2023-11-18 8:13 ` [PATCH v2 0/6] Add LoongArch v1.1 div32 and ld-seq-sa support chenglulu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d3b2d5dc3a192952d03d874d2330759b9e97033.camel@xry111.site \
--to=xry111@xry111.site \
--cc=chenglulu@loongson.cn \
--cc=gcc-patches@gcc.gnu.org \
--cc=i@xen0n.name \
--cc=joseph@codesourcery.com \
--cc=xuchenghua@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).