From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20001 invoked by alias); 9 Aug 2019 21:34:26 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 19991 invoked by uid 89); 9 Aug 2019 21:34:25 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 09 Aug 2019 21:34:24 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 88472821D1; Fri, 9 Aug 2019 21:34:23 +0000 (UTC) Received: from localhost.localdomain (ovpn-112-27.rdu2.redhat.com [10.10.112.27]) by smtp.corp.redhat.com (Postfix) with ESMTP id 83FB1600CC; Fri, 9 Aug 2019 21:34:21 +0000 (UTC) Subject: Re: [PATCH 2/2][MIPS][RFC] Emit .note.GNU-stack for hard-float linux targets. To: Dragan Mladjenovic , "gcc-patches@gcc.gnu.org" Cc: Jakub Jelinek , Matthew Fortune , Joseph Myers , "Maciej W . Rozycki" , Faraz Shahbazker References: <1565001657-5145-1-git-send-email-dmladjenovic@wavecomp.com> <1565002149-5397-1-git-send-email-dmladjenovic@wavecomp.com> From: Jeff Law Openpgp: preference=signencrypt Message-ID: <0da5c1c6-3146-9981-2c86-733a20e3140e@redhat.com> Date: Fri, 09 Aug 2019 21:38:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <1565002149-5397-1-git-send-email-dmladjenovic@wavecomp.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-08/txt/msg00658.txt.bz2 On 8/5/19 4:49 AM, Dragan Mladjenovic wrote: > From: "Dragan Mladjenovic" > > libgcc/ChangeLog: > > 2019-08-05 Dragan Mladjenovic > > * config/mips/gnustack.h: Check for TARGET_LIBC_GNUSTACK also. > > gcc/ChangeLog: > > 2019-08-05 Dragan Mladjenovic > > * config.in: Regenerated. > * config/mips/linux.h (NEED_INDICATE_EXEC_STACK): Define to 1 > for TARGET_LIBC_GNUSTACK. > * configure: Regenerated. > * configure.ac: Define TARGET_LIBC_GNUSTACK if glibc version is > found 2.31 or greater. My only concern here is the configure bits. So for example, will it do the right thing if you're cross-compiling to a MIPS linux target? If so, how? If not, do we need to make it a first class configure option so that it can be specified when building cross MIPS linux toolchains? jeff