public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Peter Bergner <bergner@linux.ibm.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Segher Boessenkool <segher@kernel.crashing.org>,
	GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] rs6000: MMA builtin usage ICEs when used in a #pragma omp parallel and using -fopenmp [PR100777]
Date: Mon, 14 Jun 2021 17:00:25 -0500	[thread overview]
Message-ID: <0dcd209c-8947-deb9-732c-b0d8df241eff@linux.ibm.com> (raw)
In-Reply-To: <20210614170840.GI7746@tucnak>

On 6/14/21 12:08 PM, Jakub Jelinek wrote:
> On Wed, May 26, 2021 at 04:16:31PM -0500, Peter Bergner via Gcc-patches wrote:
>> Using an MMA builtin within an openmp parallel code block leads to an SSA
>> verification ICE on the temporaries we create while expanding the MMA builtins
>> at gimple time.  The solution is to use create_tmp_reg_or_ssa_name(), which
>> knows when to create either an SSA or register temporary.
>>
>> This fixes the ICE and bootstraps and regtests with no regressions.
>> Ok for trunk?
> 
> LGTM.

Ok, pushed to trunk.



>> The same ICE occurs in GCC 11 and GCC 10.  Ok to backport to those release
>> branches after some burn in on trunk?
> 
> Yes.

Ok, I'll let it bake on trunk for a little while before backporting
to the release branches.  Thanks!

Peter





      reply	other threads:[~2021-06-14 22:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-26 21:16 Peter Bergner
2021-06-14 17:08 ` Jakub Jelinek
2021-06-14 22:00   ` Peter Bergner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0dcd209c-8947-deb9-732c-b0d8df241eff@linux.ibm.com \
    --to=bergner@linux.ibm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    --cc=segher@kernel.crashing.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).