From: Jeff Law <law@redhat.com>
To: Olivier Hainque <hainque@adacore.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Cc: Jerome Lambourg <lambourg@adacore.com>,
Douglas B Rupp <rupp@adacore.com>
Subject: Re: [PATCH, Makefile] improve libsubdir variable transmission to sub-makes on Windows
Date: Tue, 31 Oct 2017 01:20:00 -0000 [thread overview]
Message-ID: <0e3bba4e-c5f5-aab6-a2c3-212098bfc6d1@redhat.com> (raw)
In-Reply-To: <CF3F8281-CB7F-4C87-A24A-81DAE3519F4D@adacore.com>
On 09/01/2017 02:42 AM, Olivier Hainque wrote:
> Hello,
>
> To convey the value of libsubdir to sub-makes, gcc/Makefile.in has
>
> # Flags to pass to recursive makes.
> # CC is set by configure.
> # ??? The choices here will need some experimenting with.
>
> export AR_FOR_TARGET
> ...
> export libsubdir
>
> then:
>
> FLAGS_TO_PASS = \
> ...
> (libsubdir not here)
>
> This is not working well on cygwin environments where environment
> variable names are translated to uppercase (so sub-makes evaluating
> the variable with the lowercase name don't get the value).
>
> The attached patch is a suggestion to address this by simply adding
> "libsubdir" to the list of explicit FLAGS_TO_PASS.
>
> Used in-house for a while, with gcc-6 on a wide variety of host/target
> configurations.
>
> Bootstrapped and regression tested with mainline on x86_64-linux.
>
> OK to commit ?
>
> Thanks in advance,
>
> With Kind Regards,
>
> Olivier
>
> 2017-09-01 Jerome Lambourg <lambourg@adacore.com>
>
> * Makefile.in (FLAGS_TO_PASS): Add libsubdir.
OK.
Jeff
next prev parent reply other threads:[~2017-10-31 1:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-01 8:42 Olivier Hainque
2017-09-11 14:30 ` [PING, Makefile] improve libsubdir variable transmission to sub-makes (for Windows) Olivier Hainque
2017-09-11 15:28 ` Michael Haubenwallner
2017-09-11 16:11 ` Olivier Hainque
2017-09-25 7:33 ` [PING#2, Makefile] improve libsubdir variable transmission to sub-makes on Windows Olivier Hainque
2017-10-04 7:49 ` [PING#3, " Olivier Hainque
2017-10-26 8:44 ` [PING#4, Makefile] improve libsubdir variable transmission to sub-makes Olivier Hainque
2017-10-31 1:20 ` Jeff Law [this message]
2017-10-31 9:31 ` [PATCH, Makefile] improve libsubdir variable transmission to sub-makes on Windows Olivier Hainque
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e3bba4e-c5f5-aab6-a2c3-212098bfc6d1@redhat.com \
--to=law@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hainque@adacore.com \
--cc=lambourg@adacore.com \
--cc=rupp@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).