[PATCH, Makefile] improve libsubdir variable transmission to sub-makes on Windows

[PATCH, Makefile] improve libsubdir variable transmission to sub-makes on Windows

[Olivier Hainque]

[-- Attachment #1: Type: text/plain, Size: 945 bytes --]

Hello,

To convey the value of libsubdir to sub-makes, gcc/Makefile.in has

  # Flags to pass to recursive makes.
  # CC is set by configure.
  # ??? The choices here will need some experimenting with.

  export AR_FOR_TARGET
  ...
  export libsubdir

then:

  FLAGS_TO_PASS = \
  ...
  (libsubdir not here)

This is not working well on cygwin environments where environment
variable names are translated to uppercase (so sub-makes evaluating
the variable with the lowercase name don't get the value).

The attached patch is a suggestion to address this by simply adding
"libsubdir" to the list of explicit FLAGS_TO_PASS.

Used in-house for a while, with gcc-6 on a wide variety of host/target
configurations.

Bootstrapped and regression tested with mainline on x86_64-linux.

OK to commit ?

Thanks in advance,

With Kind Regards,

Olivier

2017-09-01  Jerome Lambourg  <lambourg@adacore.com>

	* Makefile.in (FLAGS_TO_PASS): Add libsubdir.



[-- Attachment #2: gcc-libsubdir.diff --]
[-- Type: application/octet-stream, Size: 289 bytes --]

--- a/gcc/Makefile.in
+++ b/gcc/Makefile.in
@@ -1161,6 +1161,7 @@ FLAGS_TO_PASS = \
 	"libexecsubdir=$(libexecsubdir)" \
 	"datarootdir=$(datarootdir)" \
 	"datadir=$(datadir)" \
+	"libsubdir=$(libsubdir)" \
 	"localedir=$(localedir)"
 #\f
 # Lists of files for various purposes.

Re: [PING, Makefile] improve libsubdir variable transmission to sub-makes (for Windows)

[Olivier Hainque]

Hello,

Ping for https://gcc.gnu.org/ml/gcc-patches/2017-09/msg00017.html

>   Makefile.in:
>   ...
>   export libsubdir
> 
> This is not working well on cygwin environments where environment
> variable names are translated to uppercase (so sub-makes evaluating
> the variable with the lowercase name don't get the value).

> 2017-09-01  Jerome Lambourg  <lambourg@adacore.com>
> 
> 	* Makefile.in (FLAGS_TO_PASS): Add libsubdir.

Thanks much in advance!

With Kind Regards,

Olivier

Re: [PING, Makefile] improve libsubdir variable transmission to sub-makes (for Windows)

[Michael Haubenwallner]

Hi Oliver,

On 09/11/2017 04:30 PM, Olivier Hainque wrote:
> Hello,
> 
> Ping for https://gcc.gnu.org/ml/gcc-patches/2017-09/msg00017.html
> 
>>   Makefile.in:
>>   ...
>>   export libsubdir
>>
>> This is not working well on cygwin environments where environment
>> variable names are translated to uppercase (so sub-makes evaluating
>> the variable with the lowercase name don't get the value).

just wondering if you can't update your Cygwin setup, as turning environment
variables to uppercase is not done by default in recent Cygwin any more, see
https://cygwin.com/cygwin-ug-net/using-cygwinenv.html

/haubi/

Re: [PING, Makefile] improve libsubdir variable transmission to sub-makes (for Windows)

[Olivier Hainque]

Hello Michael,

> On Sep 11, 2017, at 17:28 , Michael Haubenwallner <michael.haubenwallner@ssi-schaefer.com> wrote:

>>>  Makefile.in:
>>>  ...
>>>  export libsubdir
>>> 
>>> This is not working well on cygwin environments where environment
>>> variable names are translated to uppercase (so sub-makes evaluating
>>> the variable with the lowercase name don't get the value).
> 
> just wondering if you can't update your Cygwin setup, as turning environment
> variables to uppercase is not done by default in recent Cygwin any more, see
> https://cygwin.com/cygwin-ug-net/using-cygwinenv.html

Thanks for your input and for the pointer! Maybe we could update our
environment locally and forget about it. This might be useful for other
contexts as well.

Now it might be difficult, if not impossible, for some people, so if passing
the variable through an explicit assignment is expected to work as well, the
change would remain of interest IMO, just removing a dependency on a particular
environment setup.

With Kind Regards,

Olivier

[PING#2, Makefile] improve libsubdir variable transmission to sub-makes on Windows

[Olivier Hainque]

Hello,

Ping #2 for https://gcc.gnu.org/ml/gcc-patches/2017-09/msg00017.html

>  Makefile.in:
>  ...
>  export libsubdir
> 
> This is not working well on cygwin environments where environment
> variable names are translated to uppercase (so sub-makes evaluating
> the variable with the lowercase name don't get the value).

> 2017-09-01  Jerome Lambourg  <lambourg@adacore.com>
> 
> 	* Makefile.in (FLAGS_TO_PASS): Add libsubdir.

Thanks much in advance!

With Kind Regards,

Olivier

[PING#3, Makefile] improve libsubdir variable transmission to sub-makes on Windows

[Olivier Hainque]

Hello,

Ping #3 for https://gcc.gnu.org/ml/gcc-patches/2017-09/msg00017.html

please.

Took the liberty to cc a maintainer.

Thanks much in advance!

With Kind Regards,

Olivier

> On Sep 25, 2017, at 08:49 , Olivier Hainque <hainque@adacore.com> wrote:
> 
> Hello,
> 
> Ping #2 for https://gcc.gnu.org/ml/gcc-patches/2017-09/msg00017.html
> 
>> Makefile.in:
>> ...
>> export libsubdir
>> 
>> This is not working well on cygwin environments where environment
>> variable names are translated to uppercase (so sub-makes evaluating
>> the variable with the lowercase name don't get the value).
> 
>> 2017-09-01  Jerome Lambourg  <lambourg@adacore.com>
>> 
>> 	* Makefile.in (FLAGS_TO_PASS): Add libsubdir.
> 
> Thanks much in advance!
> 
> With Kind Regards,
> 
> Olivier
> 

[PING#4, Makefile] improve libsubdir variable transmission to sub-makes

[Olivier Hainque]

Hello,

ping #4, please.

https://gcc.gnu.org/ml/gcc-patches/2017-09/msg00017.html

Thanks much in advance,

Olivier


> On 04 Oct 2017, at 09:16, Olivier Hainque <hainque@adacore.com> wrote:
> 
> Hello,
> 
> Ping #3 for https://gcc.gnu.org/ml/gcc-patches/2017-09/msg00017.html
> 
> please.
> 
> Took the liberty to cc a maintainer.
> 
> Thanks much in advance!
> 
> With Kind Regards,
> 
> Olivier
> 
>> On Sep 25, 2017, at 08:49 , Olivier Hainque <hainque@adacore.com> wrote:
>> 
>> Hello,
>> 
>> Ping #2 for https://gcc.gnu.org/ml/gcc-patches/2017-09/msg00017.html
>> 
>>> Makefile.in:
>>> ...
>>> export libsubdir
>>> 
>>> This is not working well on cygwin environments where environment
>>> variable names are translated to uppercase (so sub-makes evaluating
>>> the variable with the lowercase name don't get the value).
>> 
>>> 2017-09-01  Jerome Lambourg  <lambourg@adacore.com>
>>> 
>>> 	* Makefile.in (FLAGS_TO_PASS): Add libsubdir.
>> 
>> Thanks much in advance!
>> 
>> With Kind Regards,
>> 
>> Olivier
>> 
> 

Re: [PATCH, Makefile] improve libsubdir variable transmission to sub-makes on Windows

[Jeff Law]

On 09/01/2017 02:42 AM, Olivier Hainque wrote:
> Hello,
> 
> To convey the value of libsubdir to sub-makes, gcc/Makefile.in has
> 
>   # Flags to pass to recursive makes.
>   # CC is set by configure.
>   # ??? The choices here will need some experimenting with.
> 
>   export AR_FOR_TARGET
>   ...
>   export libsubdir
> 
> then:
> 
>   FLAGS_TO_PASS = \
>   ...
>   (libsubdir not here)
> 
> This is not working well on cygwin environments where environment
> variable names are translated to uppercase (so sub-makes evaluating
> the variable with the lowercase name don't get the value).
> 
> The attached patch is a suggestion to address this by simply adding
> "libsubdir" to the list of explicit FLAGS_TO_PASS.
> 
> Used in-house for a while, with gcc-6 on a wide variety of host/target
> configurations.
> 
> Bootstrapped and regression tested with mainline on x86_64-linux.
> 
> OK to commit ?
> 
> Thanks in advance,
> 
> With Kind Regards,
> 
> Olivier
> 
> 2017-09-01  Jerome Lambourg  <lambourg@adacore.com>
> 
> 	* Makefile.in (FLAGS_TO_PASS): Add libsubdir.
OK.

Jeff

Re: [PATCH, Makefile] improve libsubdir variable transmission to sub-makes on Windows

[Olivier Hainque]

> On Oct 31, 2017, at 00:07 , Jeff Law <law@redhat.com> wrote:

>> 	* Makefile.in (FLAGS_TO_PASS): Add libsubdir.
> OK.

:-) Thanks Jeff!