From: Jerry DeLisle <jvdelisle@charter.net>
To: Jim Wilson <jim.wilson@linaro.org>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
fortran@gcc.gnu.org
Subject: Re: [PATCH, libgfortran] proposed fix for SPEC CPU2017 621.wrf_s failures
Date: Mon, 26 Jun 2017 04:14:00 -0000 [thread overview]
Message-ID: <0e5a0879-eea2-d5f2-e702-4f8b811be00f@charter.net> (raw)
In-Reply-To: <CABXYE2W97i1hxp=o17wjjezekDUzonLM3DjP2aHOfKMQd5=zSg@mail.gmail.com>
On 06/25/2017 05:50 PM, Jim Wilson wrote:
> As mentioned in bug 81195, I see openmp related failures due to a lack
> of locking of the newunit_stack and newunit_tos variables. The code
> locks when pushing onto the stack, but does not lock when popping from
> the stack. This can cause multiple threads to pop the same structure,
> which then eventually leads to an error.
>
> This patch was tested with an aarch64 bootstrap and make check. There
> were no regressions. It was also tested with a SPEC CPU2017 run, and
> solves the 621.wrf_s failure I get without the patch.
>
> gcc 7 has the same problem. gcc 6 is OK.
>
> Jim
>
OK to commit for trunk and 7. Thanks for spotting this,
Jerry
prev parent reply other threads:[~2017-06-26 4:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-26 0:50 Jim Wilson
2017-06-26 4:14 ` Jerry DeLisle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e5a0879-eea2-d5f2-e702-4f8b811be00f@charter.net \
--to=jvdelisle@charter.net \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jim.wilson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).