From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 108382 invoked by alias); 26 Jun 2017 04:14:12 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 108287 invoked by uid 89); 26 Jun 2017 04:14:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy= X-Spam-User: qpsmtpd, 2 recipients X-HELO: mtaout002-public.msg.strl.va.charter.net Received: from mtaout002-public.msg.strl.va.charter.net (HELO mtaout002-public.msg.strl.va.charter.net) (68.114.190.27) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 26 Jun 2017 04:14:09 +0000 Received: from impout003 ([68.114.189.18]) by mtaout002.msg.strl.va.charter.net (InterMail vM.9.00.023.01 201-2473-194) with ESMTP id <20170626041406.VCVJ7360.mtaout002.msg.strl.va.charter.net@impout003>; Sun, 25 Jun 2017 23:14:06 -0500 Received: from [192.168.2.11] ([96.41.215.23]) by impout003 with charter.net id dGE51v0020Wrkg001GE5vR; Sun, 25 Jun 2017 23:14:06 -0500 X-Authority-Analysis: v=2.2 cv=XZf59Mx5 c=1 sm=1 tr=0 a=salB9WdMPIDduBH7JsZfrA==:117 a=salB9WdMPIDduBH7JsZfrA==:17 a=IkcTkHD0fZMA:10 a=x7bEGLp0ZPQA:10 a=_bROsrK6PWQDim-egtMA:9 a=QEXdDO2ut3YA:10 X-Auth-id: anZkZWxpc2xlQGNoYXJ0ZXIubmV0 Subject: Re: [PATCH, libgfortran] proposed fix for SPEC CPU2017 621.wrf_s failures To: Jim Wilson , "gcc-patches@gcc.gnu.org" , fortran@gcc.gnu.org References: From: Jerry DeLisle Message-ID: <0e5a0879-eea2-d5f2-e702-4f8b811be00f@charter.net> Date: Mon, 26 Jun 2017 04:14:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-06/txt/msg01878.txt.bz2 On 06/25/2017 05:50 PM, Jim Wilson wrote: > As mentioned in bug 81195, I see openmp related failures due to a lack > of locking of the newunit_stack and newunit_tos variables. The code > locks when pushing onto the stack, but does not lock when popping from > the stack. This can cause multiple threads to pop the same structure, > which then eventually leads to an error. > > This patch was tested with an aarch64 bootstrap and make check. There > were no regressions. It was also tested with a SPEC CPU2017 run, and > solves the 621.wrf_s failure I get without the patch. > > gcc 7 has the same problem. gcc 6 is OK. > > Jim > OK to commit for trunk and 7. Thanks for spotting this, Jerry