From: Matthias Klose <doko@ubuntu.com>
To: sellcey@cavium.com, James Greenhalgh <james.greenhalgh@arm.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,
Richard Earnshaw <Richard.Earnshaw@arm.com>,
Marcus Shawcroft <Marcus.Shawcroft@arm.com>,
nd@arm.com, wookey@arm.com
Subject: Re: [Patch][Aarch64] Fix multi-arch support in ILP32 mode
Date: Thu, 21 Dec 2017 22:55:00 -0000 [thread overview]
Message-ID: <0e929edb-7c0f-2036-b6b2-1b36e0fae4ec@ubuntu.com> (raw)
In-Reply-To: <1513893541.5026.75.camel@cavium.com>
On 21.12.2017 22:59, Steve Ellcey wrote:
> On Thu, 2017-12-21 at 20:55 +0000, James Greenhalgh wrote:
>> On Thu, Dec 21, 2017 at 06:56:22PM +0000, Steve Ellcey wrote:
>>>
>>> This one line patch for multi-arch support on Aarch64 and ILP32 was
>>> submitted over a year ago and pinged a number of time since then,
>>> since no one has objected and since it is only one line I am going
>>> to check it in as an obvious fix.
>> I think this is not obvious, and worse incorrect. I contacted Andrew
>> off-list back in September to ask about this patch, the problem is
>> the
>> triplet used here:
>>
>>>
>>> -MULTILIB_OSDIRNAMES += mabi.ilp32=../libilp32
>>> +MULTILIB_OSDIRNAMES += mabi.ilp32=../libilp32$(call
>>> if_multiarch,:aarch64$(AARCH_BE)_ilp32-linux-gnu)
>> As far as I understand it from Linaro connect and conversations with
>> Debian/Ubuntu port maintainers, the correct triplet should be:
>>
>> Â aarch64-none-linux-gnu_ilp32
>>
>> If you're revisiting this patch, it is OK to go in, but please use the
>> agreed triplet.
well, it's called triplet, not quadruplet. No other multiarch tuple contains an
explicit vendor field. Do you really want to use that?
>> Thanks,
>> James
>
> OK, I fixed the triplet and checked it in.
hmm ...
Matthias
next prev parent reply other threads:[~2017-12-21 22:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-21 18:56 Steve Ellcey
2017-12-21 20:55 ` James Greenhalgh
2017-12-21 21:59 ` Steve Ellcey
2017-12-21 22:55 ` Matthias Klose [this message]
2017-12-21 23:18 ` Steve Ellcey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e929edb-7c0f-2036-b6b2-1b36e0fae4ec@ubuntu.com \
--to=doko@ubuntu.com \
--cc=Marcus.Shawcroft@arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=james.greenhalgh@arm.com \
--cc=nd@arm.com \
--cc=sellcey@cavium.com \
--cc=wookey@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).