From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 640DB3858C27 for ; Wed, 13 Oct 2021 11:59:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 640DB3858C27 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 27E1F201FA; Wed, 13 Oct 2021 11:59:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1634126380; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pfunmGkoN6r589zJB1ldUVEb3AxLWmlfom9qBTxLzpQ=; b=zJn1No1uNbb/YIiYwUnpxOKOnZv2rLwcgpCqnvkvoGqI2Cg8o4LVQB5Zvg1OExgbH9ju+d qTWqi5hqBOwoNRxZzvdBeuNkkYOJsKWzjP6yHdhuQjjyo/upSdj4Tu9fNfsuHngbaW9YxC LQgO3gO42gy7xZTnHZg2Wx+djv1Iruo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1634126380; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pfunmGkoN6r589zJB1ldUVEb3AxLWmlfom9qBTxLzpQ=; b=FJgpaMzqsAxfuUjl+Czhp445s24tLhaCZ8F1Y+21i7lcHdl+XvHGSbtwWi0Jg6ylk09mzO pWItfmNlqcM8luCg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 07B5A13CEC; Wed, 13 Oct 2021 11:59:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 9MXYACzKZmF/fgAAMHmgww (envelope-from ); Wed, 13 Oct 2021 11:59:40 +0000 Message-ID: <0ea9882e-8d7c-f6d4-9262-50e2b3ae5e6c@suse.cz> Date: Wed, 13 Oct 2021 13:59:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.2 Subject: Re: [PATCH] options: Fix variable tracking option processing. Content-Language: en-US To: Richard Biener Cc: GCC Patches References: <202e07b3-e8d5-85e2-c0a5-8a40a61d7175@suse.cz> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Oct 2021 11:59:42 -0000 On 10/13/21 10:47, Richard Biener wrote: > Let's split this;) The debug_inline_points part is OK. Fine. > > How can debug_variable_location_views be ever -1? But the > debug_variable_location_views part looks OK as well. It comes from here: gvariable-location-views=incompat5 Common Driver RejectNegative Var(debug_variable_location_views, -1) Init(2) but it's fine as using -gvariable-location-views=incompat5 leads to OPTION_SET_P(debug_variable_location_views) == true. > > More or less all parts that have the variable assigned in a single > place in gcc/ are OK (dwarf2out_as_locview_support). But the > main flag_var_tracking* cases need more thorough view, > maybe we can convert them to single-set code first? I don't think so, your have code like if (flag_var_tracking_assignments_toggle) flag_var_tracking_assignments = !flag_var_tracking_assignments; which makes it more complicated. Or do I miss something? Cheers, Martin