From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd34.google.com (mail-io1-xd34.google.com [IPv6:2607:f8b0:4864:20::d34]) by sourceware.org (Postfix) with ESMTPS id 401073858C2A for ; Tue, 26 Dec 2023 21:21:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 401073858C2A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 401073858C2A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d34 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703625688; cv=none; b=t/g0LU7fHWBiiL83EBB37A4tKBmIiNHmPZMk7H2a/e51Os1btWqFpC47I2XiBueJHO6bbYFe4a3KWfaXuE4lsdJZB4EasqUYE0yxnACkxQjm2TSWnAGIAdR7wmDziZtmycrexkUtmHIvUxsEjWsOBBFHCBf6Gye9207+nIN/isM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703625688; c=relaxed/simple; bh=PeM3qE2z2zBujrTQivkfLfYMArGjPPpQY8KBhc5G/xc=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=KfCklxu5DTEizn6d9+6IKkxltxsTyhEusnEtKNJnkj0XUZrBeJ0sAWjnkvn3SzVM7lY5mzND2qZXp+En2Hp5iQUmv4OvSMNaVt3JLTR6be+sihCEB9ZDaGVaNUxPMOTTjKHpQXgaVG3HkdEN05wlhwpsqXlDvllbHB/BtmAKQLY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-io1-xd34.google.com with SMTP id ca18e2360f4ac-7ba903342c2so345677039f.3 for ; Tue, 26 Dec 2023 13:21:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1703625684; x=1704230484; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=lLMR8dON2vqpgnywj/VUfhuQrYhm05qVRG7kcR7njns=; b=JetyfnNlvSaDH1S6Gr5Y+mj4RBjT1BNX75m2KAYysb998CfRW4U6JaWh3pUorniMmL Qo6Af6CPkOeprVLb4XKYNKQ6qEHcWVQmY76odZp5IYZxRjol6RfFCw2hh+ggJlspMPnj xJhvQ3574EoDe+Zo/WKyNeEvNCkM8PAKIuYxo7WEnaRrUBWlen1HfEvyf7UBz9zoBCHH d/7L3OAfFz+/qhb7LiIIKgQL5XLjLoYiDCbRqxXvab0sERVpFPA7tzf4QUpe2WoS6WWs dsXfCcjiR+3uTX2HrrNjw9KRH0op9EB/wKxFmhEjWKXOibDbtwL57NWwtY5j9/ezXdSd H16w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703625684; x=1704230484; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lLMR8dON2vqpgnywj/VUfhuQrYhm05qVRG7kcR7njns=; b=dtjEuXuUqcTRHAGI16kYqhba8/2Qhr9cfMEaq054dfGHL33YqB6YOKLDS6JnyzD15U bk2/B9iaZmR8u0PWWZoBipKdd9nIoBfdlNR6Pg+X1FI/1MAPClPYcgAkan6KCWiLKwyx X20zZxyJLkB+aUroT6L6lWME5FBb48i/OuvZI0gIpeLxUTgf1OUQ1ud7V/q5lO2I0QrK hGxsDFekT0B0zxri/hgfBvHUIlaMWc+fU/zTPidMY6PzwWf9NnV6vq3idXX+3aDoQwDP ExWtG4W1xnHWr/6pNPp0f0O1GwyvsSSj22V7v/VKyI6ZJO/rakN3q7P0fZWQKBnmobbV iCHg== X-Gm-Message-State: AOJu0YwepxzkYpzpxtIJmxYa4+amRwxCnpkL32qofJfmGC/w1egdPNNl 0jXvmZuQrN1OSiS4Q+4m/0IWmEq15Lfw5Q== X-Google-Smtp-Source: AGHT+IE/WxWkNoGkthYYnbDi5hH8Jq3cdb72zLfOdyPUAVMRhubwGXkIB24BVOGrk4PMWC2HJHZ6sQ== X-Received: by 2002:a05:6e02:350c:b0:360:a97:930b with SMTP id bu12-20020a056e02350c00b003600a97930bmr3443935ilb.94.1703625684550; Tue, 26 Dec 2023 13:21:24 -0800 (PST) Received: from [10.0.17.83] ([12.44.203.122]) by smtp.gmail.com with ESMTPSA id u10-20020a63140a000000b005c6e8fa9f24sm9869873pgl.49.2023.12.26.13.21.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Dec 2023 13:21:24 -0800 (PST) Message-ID: <0f3d2ef1-5a3c-4bd2-b841-47929e499785@rivosinc.com> Date: Tue, 26 Dec 2023 13:21:21 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3][RFC] RISC-V: Add vector related reservations Content-Language: en-US From: Edwin Lu To: Jeff Law , gcc-patches@gcc.gnu.org Cc: gnu-toolchain@rivosinc.com, kito.cheng@gmail.com, Robin Dapp References: <20231215185328.794425-1-ewlu@rivosinc.com> <20231215185328.794425-3-ewlu@rivosinc.com> <39a1a8fb-6d6f-4c81-a4df-5d658467e34f@gmail.com> <5f1b3ce3-e699-4fbc-b680-b56085af0df4@rivosinc.com> In-Reply-To: <5f1b3ce3-e699-4fbc-b680-b56085af0df4@rivosinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/20/2023 2:55 PM, Edwin Lu wrote: > On 12/20/2023 10:57 AM, Jeff Law wrote: >> >> >> On 12/15/23 11:53, Edwin Lu wrote: >>> This patch copies the vector reservations from generic-ooo.md and >>> inserts them into generic.md and sifive.md. The vector pipelines are >>> necessary to avoid an ICE from the assert I forgot to get clarification earlier but this patch would introduce many scan-dump failures for both vector and non-vector targets (https://github.com/ewlu/gcc-precommit-ci/issues/950#issuecomment-1858392181). I haven't identified any execution errors that would be introduced on mtune=rocket aside from one ICE which I'm currently working on fixing. Additionally, as mentioned in PR113035, there are significant testsuite differences between mtune=rocket and mtune=sifive-7-series. I haven't gone through all of the differences and I don't know if they are a problem with the patch or a result of the cost modeling assumptions. Is there a problem with the current way mtune=rocket is modeled with generic.md? Edwin