public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeff Law <law@redhat.com>
To: gcc-patches@gcc.gnu.org, richard.sandiford@linaro.org
Subject: Re: [7/10] Add a vect_unaligned_possible target selector
Date: Wed, 08 Nov 2017 22:32:00 -0000	[thread overview]
Message-ID: <0f9b5614-6ba2-b9ad-0a38-a5664af1ce92@redhat.com> (raw)
In-Reply-To: <87mv43pc45.fsf@linaro.org>

On 11/03/2017 10:20 AM, Richard Sandiford wrote:
> This patch adds a target selector that says whether we can ever
> generate an "unaligned" accesses, where "unaligned" is relative
> to the target's preferred vector alignment.  This is already true if:
> 
>    vect_no_align && { ! vect_hw_misalign }
> 
> i.e. if the target doesn't have any alignment mechanism and also
> doesn't allow unaligned accesses.  It is also true (for the things
> tested by gcc.dg/vect) if the target only wants things to be aligned
> to an element; in that case every normal scalar access is "vector aligned".
> 
> 
> 2017-11-03  Richard Sandiford  <richard.sandiford@linaro.org>
> 	    Alan Hayward  <alan.hayward@arm.com>
> 	    David Sherwood  <david.sherwood@arm.com>
> 
> gcc/
> 	* doc/sourcebuild.texi (vect_unaligned_possible): Document.
> 
> gcc/testsuite/
> 	* lib/target-supports.exp
> 	(check_effective_target_vect_unaligned_possible): New proc.
> 	* gcc.dg/vect/slp-25.c: Extend XFAIL of peeling for alignment from
> 	vect_no_align && { ! vect_hw_misalign } to ! vect_unaligned_possible.
> 	* gcc.dg/vect/vect-multitypes-1.c: Likewise.
> 	* gcc.dg/vect/vect-109.c: XFAIL vectorisation of an unaligned
> 	access to ! vect_unaligned_possible.
> 	* gcc.dg/vect/vect-33.c: Likewise.
> 	* gcc.dg/vect/vect-42.c: Likewise.
> 	* gcc.dg/vect/vect-56.c: Likewise.
> 	* gcc.dg/vect/vect-60.c: Likewise.
> 	* gcc.dg/vect/vect-96.c: Likewise.
> 	* gcc.dg/vect/vect-peel-1.c: Likewise.
> 	* gcc.dg/vect/vect-27.c: Extend XFAIL of unaligned vectorization from
> 	vect_no_align && { ! vect_hw_misalign } to ! vect_unaligned_possible.
> 	* gcc.dg/vect/vect-29.c: Likewise.
> 	* gcc.dg/vect/vect-44.c: Likewise.
> 	* gcc.dg/vect/vect-48.c: Likewise.
> 	* gcc.dg/vect/vect-50.c: Likewise.
> 	* gcc.dg/vect/vect-52.c: Likewise.
> 	* gcc.dg/vect/vect-72.c: Likewise.
> 	* gcc.dg/vect/vect-75-big-array.c: Likewise.
> 	* gcc.dg/vect/vect-75.c: Likewise.
> 	* gcc.dg/vect/vect-77-alignchecks.c: Likewise.
> 	* gcc.dg/vect/vect-77-global.c: Likewise.
> 	* gcc.dg/vect/vect-78-alignchecks.c: Likewise.
> 	* gcc.dg/vect/vect-78-global.c: Likewise.
> 	* gcc.dg/vect/vect-multitypes-3.c: Likewise.
> 	* gcc.dg/vect/vect-multitypes-4.c: Likewise.
> 	* gcc.dg/vect/vect-multitypes-6.c: Likewise.
> 	* gcc.dg/vect/vect-peel-4.c: Likewise.
> 	* gcc.dg/vect/vect-peel-3.c: Likewise, and also for peeling
> 	for alignment.
OK.  Though I could see a need to one day provide a more concrete test
than "in some circumstances".

jeff

  reply	other threads:[~2017-11-08 22:31 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-03 16:14 [0/10] Vectoriser testsuite tweaks Richard Sandiford
2017-11-03 16:16 ` [1/10] Consistently use asm volatile ("" ::: "memory") in vect tests Richard Sandiford
2017-11-08 19:10   ` Jeff Law
2017-11-03 16:17 ` [2/10] Add VECTOR_BITS to tree-vect.h Richard Sandiford
2017-11-08 19:13   ` Jeff Law
2017-11-03 16:18 ` [4/10] Don't assume vect_multiple_sizes means 2 sizes Richard Sandiford
2017-11-08 19:21   ` Jeff Law
2017-11-03 16:18 ` [3/10] Add available_vector_sizes to target-supports.exp Richard Sandiford
2017-11-08 19:13   ` Jeff Law
2017-11-17 13:23     ` Christophe Lyon
2017-11-03 16:19 ` [5/10] Add vect_perm3_* target selectors Richard Sandiford
2017-11-08 19:49   ` Jeff Law
2017-11-03 16:20 ` [6/10] Add a vect_element_align_preferred target selector Richard Sandiford
2017-11-08 22:31   ` Jeff Law
2017-11-03 16:21 ` [8/10] Add a vect_variable_length " Richard Sandiford
2017-11-08 22:33   ` Jeff Law
2017-11-03 16:21 ` [7/10] Add a vect_unaligned_possible " Richard Sandiford
2017-11-08 22:32   ` Jeff Law [this message]
2017-11-03 16:22 ` [9/10] Add a vect_align_stack_vars " Richard Sandiford
2017-11-08 22:40   ` Jeff Law
2017-11-03 16:23 ` [10/10] Add a vect_masked_store " Richard Sandiford
2017-11-08 22:44   ` Jeff Law

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0f9b5614-6ba2-b9ad-0a38-a5664af1ce92@redhat.com \
    --to=law@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=richard.sandiford@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).