public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Lehua Ding" <lehua.ding@rivai.ai>
To: "Robin Dapp" <rdapp.gcc@gmail.com>,
	gcc-patches <gcc-patches@gcc.gnu.org>
Cc: "rdapp.gcc" <rdapp.gcc@gmail.com>,
	"juzhe.zhong" <juzhe.zhong@rivai.ai>,
	"kito.cheng" <kito.cheng@gmail.com>, palmer <palmer@rivosinc.com>,
	jeffreyalaw <jeffreyalaw@gmail.com>
Subject: Re: [PATCH] RISC-V: Fix testcase failed when default -mcmodel=medany
Date: Tue, 18 Jul 2023 16:43:40 +0800	[thread overview]
Message-ID: <1009A8E07E6305DA+tencent_31597DB05C4FCE002267D617ED8672D6DB0A@qq.com> (raw)
In-Reply-To: <e873b61f-cd69-9aca-272d-a6c241b26b5f@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 711 bytes --]

Hi Robin,


&gt;&nbsp;Wouldn't you rather want to adjust the test to not check for one register
&gt; number but 3 or 4 instead?

I think the purpose of this testcase is to check whether the modifications to
the stack frame are as expected, so it is necessary to specify exactly whether
three or four registers are saved. But I think its need to add another testcase
which use another option -mcmodel=medany&nbsp;for coverage.


&gt;&nbsp;There might be future changes in default behavior
&gt; that would invalidate the test as well.

Because -mcmodel is explicitly specified in the testcase, future changes
to the default value of -mcmodel will not cause the test case to fail.


Best,
Lehua

  reply	other threads:[~2023-07-18  9:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-18  7:42 Lehua Ding
2023-07-18  7:51 ` juzhe.zhong
2023-07-18  8:18 ` Robin Dapp
2023-07-18  8:43   ` Lehua Ding [this message]
2023-07-18 10:03     ` Robin Dapp
2023-07-19  3:12 Lehua Ding
2023-07-19  6:03 ` Robin Dapp
2023-07-19  7:20   ` =?gb18030?B?TGVodWEgRGluZw==?=

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1009A8E07E6305DA+tencent_31597DB05C4FCE002267D617ED8672D6DB0A@qq.com \
    --to=lehua.ding@rivai.ai \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jeffreyalaw@gmail.com \
    --cc=juzhe.zhong@rivai.ai \
    --cc=kito.cheng@gmail.com \
    --cc=palmer@rivosinc.com \
    --cc=rdapp.gcc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).