From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 5884A3858D28 for ; Tue, 1 Nov 2022 13:58:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5884A3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667311085; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type; bh=inh2h0m6d29I9bep5/qICtCJNVDrMTi3p5613xqOpnQ=; b=gib7F9j+iuWd9Ix3ssSQqiVfJ9jGMUI0pv/CQwRa0N6qMQvOapjW33gD+AyIQqi6kX9Um6 CI0mTD4kzQLS6HqvG6HuH8ZcTQQWpViaa8/zi2qcQ233EYRP7RvrhogmRT3fHRKRwqnTtc eJj+k2f+i7cOd0ikXPeBuqMFN8pxK68= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-672-XcO4B_TrOISfpbZdy7_h2Q-1; Tue, 01 Nov 2022 09:58:04 -0400 X-MC-Unique: XcO4B_TrOISfpbZdy7_h2Q-1 Received: by mail-qt1-f197.google.com with SMTP id s14-20020a05622a1a8e00b00397eacd9c1aso9958917qtc.21 for ; Tue, 01 Nov 2022 06:58:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=subject:from:cc:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MRysbvzTyL1t6KSXKdd0E+E5kzY6Cztv9NQto6+G9Vk=; b=Hr6pATRHDPuq9uCBiAj7ByZ86QfZV/sV29CU0tVIS1Als7AS3f+0ew1nLh7aY5jWX1 RUZPidCcSfY35Lh0kjYA1oZV0jLUZHDBAqYdiFm7Dm7B9D2HijIP0Swkd9QFSeaiUrqh 2QniQbgpfYyiUU4ZBHytzSTyTSrri6B+WlFR33VgmJSpa7Uiz3PvhuA+P/uv5jTUiCkP rlwc6kwY/irxz254O/kbtTPPYefAxNos6sK8bzhMHUdU2pkd5EFCzekn2PINEy8EJfrl qHQV8VCNPi4ahQDOJnObgichzIvu4gQhNmGwPl7SEDpkLbKZunesvWi0o0Ey8AD6u02Y Su/A== X-Gm-Message-State: ACrzQf3LZszQMFFtfcDvVAa1epmt7yu+UOu517BPq8RExkwyS1oSyb53 +n5kU2/RjUcGYhxddvdrlsu4SMbslwqMRo7b66PSiFJQ9kW9SQQ/xJav1IetrLZWP99Ia9Wun2T 2PGIDAZPm7OBm3wIIeSxDmVCCp7Lb05x0m9yiWqK6skyOPgHHhQ3zwW4kKQUOyS8t5eFYJQ== X-Received: by 2002:ad4:5962:0:b0:4bb:6c2f:cbc2 with SMTP id eq2-20020ad45962000000b004bb6c2fcbc2mr16080356qvb.101.1667311082968; Tue, 01 Nov 2022 06:58:02 -0700 (PDT) X-Google-Smtp-Source: AMsMyM62zqs3pe5ajxiAFqUOOTxGyLJDSbZx1QKUuGlf9eUFL4mJgMAq50YMLgI+ciWNW4JQrD4erA== X-Received: by 2002:ad4:5962:0:b0:4bb:6c2f:cbc2 with SMTP id eq2-20020ad45962000000b004bb6c2fcbc2mr16080337qvb.101.1667311082678; Tue, 01 Nov 2022 06:58:02 -0700 (PDT) Received: from ?IPV6:2607:fea8:a263:f600::72c3? ([2607:fea8:a263:f600::72c3]) by smtp.gmail.com with ESMTPSA id n13-20020a05620a222d00b006fa12a74c53sm6488574qkh.61.2022.11.01.06.58.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Nov 2022 06:58:02 -0700 (PDT) Message-ID: <100da11f-424c-71e0-1275-f161b94ffa46@redhat.com> Date: Tue, 1 Nov 2022 09:58:00 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 To: gcc-patches Cc: "hernandez, aldy" , Richard Biener , Jakub Jelinek , Jeff Law From: Andrew MacLeod Subject: [COMMITTED] Make ranger the vrp1 default. X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="------------YaHaU4OJiPCx3q0ZOVgK0sVw" Content-Language: en-US X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------YaHaU4OJiPCx3q0ZOVgK0sVw Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit This patch turns ranger on by default for the VRP1 pass. I needed to adjust gcc.dg/pr68217.c to scan for a better range ([-INF, -INF][0, 0]) than the original [-INF, 0] it was looking for. This also triggers the new __builtin_unreachable code in the ranger VRP pass, so I added a new testcase to show accumulated unreachables are combined properly.  tree-ssa/pr107009.c also verifies that a non-dominated unreachable call doesn't incorrectly affect the global range. Bootstrapped on x86_64-pc-linux-gnu with no regressions*. Pushed. * OK. no regressions is debatable.  I've been seeing the following spurious failure for the past few weeks.  Ranger made them pass for a while, then made them fail, so Ive been ignoring them. I took a quick look.  Basically, we optimize away an unnecessary statement feeding a condition based on a combination of what ranger calculates and results from loop analysis.  (The statement is not referenced in any debug statement).  That later causes a PHI to no longer been needed, and DCE2 removed the PHI and some other stuff, which then causes the debug_stmt to lose its reference.  /blame dce2 :-) < FAIL: gcc.dg/guality/pr54693-2.c   -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects  -DPREVENT_OPTIMIZATION line 21 x == 10 - i < FAIL: gcc.dg/guality/pr54693-2.c   -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects  -DPREVENT_OPTIMIZATION line 21 y == 20 - 2 * i < FAIL: gcc.dg/guality/pr54693-2.c   -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects  -DPREVENT_OPTIMIZATION line 21 z == 30 - 3 * i I choose to ignore this for now...  I want to get VRP1 turned to ranger by default and see if any issues show up.  I believe this removes the last remaining use of legacy vrp. Andrew --------------YaHaU4OJiPCx3q0ZOVgK0sVw Content-Type: text/plain; charset=UTF-8; name="0004" Content-Disposition: attachment; filename="0004" Content-Transfer-Encoding: base64 Y29tbWl0IGU3MzEwZTI0YjFjMGNhNjdiMWJiNTA3YzEzMzBiMmJmMzllNTllMzIKQXV0aG9yOiBB bmRyZXcgTWFjTGVvZCA8YW1hY2xlb2RAcmVkaGF0LmNvbT4KRGF0ZTogICBUdWUgT2N0IDI1IDE2 OjQyOjQxIDIwMjIgLTA0MDAKCiAgICBNYWtlIHJhbmdlciB2cnAxIGRlZmF1bHQuCiAgICAKICAg IFR1cm4gb24gcmFuZ2VyIGFzIHRoZSBkZWZhdWx0IHZycDEgcGFzcyBhbmQgYWRqdXN0IHRlc3Rj YXNlcy4KICAgIAogICAgICAgICAgICBnY2MvCiAgICAgICAgICAgICogcGFyYW1zLm9wdCAocGFy YW1fdnJwMV9tb2RlKTogTWFrZSByYW5nZXIgZGVmYXVsdC4KICAgIAogICAgICAgICAgICBnY2Mv dGVzdHN1aXRlLwogICAgICAgICAgICAqIGdjYy5kZy9wcjY4MjE3LmM6IFRlc3QgWy1JTkYsIC1J TkZdWzAsIDBdIGluc3RlYWQgb2YgWy1JTkYsIDBdLgogICAgICAgICAgICAqIGdjYy5kZy90cmVl LXNzYS92cnAtdW5yZWFjaGFibGUuYzogTmV3LiAgVGVzdCB1bnJlYWNoYWJsZSByZW1vdmFsLgoK ZGlmZiAtLWdpdCBhL2djYy9wYXJhbXMub3B0IGIvZ2NjL3BhcmFtcy5vcHQKaW5kZXggMzAwMTU2 NmU2NDEuLmEzNGZlZTE5M2ZjIDEwMDY0NAotLS0gYS9nY2MvcGFyYW1zLm9wdAorKysgYi9nY2Mv cGFyYW1zLm9wdApAQCAtMTE2Niw3ICsxMTY2LDcgQEAgQ29tbW9uIEpvaW5lZCBVSW50ZWdlciBW YXIocGFyYW1fdmVjdF9pbmR1Y3Rpb25fZmxvYXQpIEluaXQoMSkgSW50ZWdlclJhZ2UoMCwgMSkK IEVuYWJsZSBsb29wIHZlY3Rvcml6YXRpb24gb2YgZmxvYXRpbmcgcG9pbnQgaW5kdWN0aW9ucy4K IAogLXBhcmFtPXZycDEtbW9kZT0KLUNvbW1vbiBKb2luZWQgVmFyKHBhcmFtX3ZycDFfbW9kZSkg RW51bSh2cnBfbW9kZSkgSW5pdChWUlBfTU9ERV9WUlApIFBhcmFtIE9wdGltaXphdGlvbgorQ29t bW9uIEpvaW5lZCBWYXIocGFyYW1fdnJwMV9tb2RlKSBFbnVtKHZycF9tb2RlKSBJbml0KFZSUF9N T0RFX1JBTkdFUikgUGFyYW0gT3B0aW1pemF0aW9uCiAtLXBhcmFtPXZycDEtbW9kZT1bdnJwfHJh bmdlcl0gU3BlY2lmaWVzIHRoZSBtb2RlIFZSUDEgc2hvdWxkIG9wZXJhdGUgaW4uCiAKIC1wYXJh bT12cnAyLW1vZGU9CmRpZmYgLS1naXQgYS9nY2MvdGVzdHN1aXRlL2djYy5kZy9wcjY4MjE3LmMg Yi9nY2MvdGVzdHN1aXRlL2djYy5kZy9wcjY4MjE3LmMKaW5kZXggZWI0ZjE1ZTA0OGYuLjYwYzgw MTA2NzYwIDEwMDY0NAotLS0gYS9nY2MvdGVzdHN1aXRlL2djYy5kZy9wcjY4MjE3LmMKKysrIGIv Z2NjL3Rlc3RzdWl0ZS9nY2MuZGcvcHI2ODIxNy5jCkBAIC0xMCw0ICsxMCw0IEBAIGludCBmb28g KHZvaWQpCiAgICAgcmV0dXJuIDA7CiB9CiAKLS8qIHsgZGctZmluYWwgeyBzY2FuLXRyZWUtZHVt cCAiXFxcWy1JTkYsIDBcXFxdIiAidnJwMSIgfSB9ICovCisvKiB7IGRnLWZpbmFsIHsgc2Nhbi10 cmVlLWR1bXAgIlxcXFstSU5GLCAtSU5GXFxcXVxcXFswLCAwXFxcXSIgInZycDEiIH0gfSAqLwpk aWZmIC0tZ2l0IGEvZ2NjL3Rlc3RzdWl0ZS9nY2MuZGcvdHJlZS1zc2EvdnJwLXVucmVhY2hhYmxl LmMgYi9nY2MvdGVzdHN1aXRlL2djYy5kZy90cmVlLXNzYS92cnAtdW5yZWFjaGFibGUuYwpuZXcg ZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMC4uY2RjNTc0MDNjNmUKLS0tIC9kZXYv bnVsbAorKysgYi9nY2MvdGVzdHN1aXRlL2djYy5kZy90cmVlLXNzYS92cnAtdW5yZWFjaGFibGUu YwpAQCAtMCwwICsxLDQyIEBACisvKiB7IGRnLWRvIGNvbXBpbGUgfSAqLworLyogeyBkZy1vcHRp b25zICItTzIgLWZkdW1wLXRyZWUtdnJwMS1hbGlhcyAtZmR1bXAtdHJlZS12cnAyLWFsaWFzIiB9 ICovCisKK3ZvaWQgZGVhZCAodW5zaWduZWQgbik7Cit2b2lkIGFsaXZlICh1bnNpZ25lZCBuKTsK Kwordm9pZCBmdW5jICh1bnNpZ25lZCBuLCB1bnNpZ25lZCBtKQoreworICBpZiAobiA9PSAwKQor ICAgIF9fYnVpbHRpbl91bnJlYWNoYWJsZSgpOworICBpZiAobiA9PSAxKQorICAgIF9fYnVpbHRp bl91bnJlYWNoYWJsZSgpOworICBpZiAobiAmIDB4MSkKKyAgICBfX2J1aWx0aW5fdW5yZWFjaGFi bGUoKTsKKyAgaWYgKG4gPT0gMikKKyAgICBfX2J1aWx0aW5fdW5yZWFjaGFibGUoKTsKKyAgaWYg KG4gPT0gMykKKyAgICBfX2J1aWx0aW5fdW5yZWFjaGFibGUoKTsKKyAgaWYgKG4gJiAweDIpCisg ICAgX19idWlsdGluX3VucmVhY2hhYmxlKCk7CisgIGlmIChuID09IDQpCisgICAgX19idWlsdGlu X3VucmVhY2hhYmxlKCk7CisgIGlmIChuID09IDUpCisgICAgX19idWlsdGluX3VucmVhY2hhYmxl KCk7CisgIGlmIChuICYgMHg0KQorICAgIF9fYnVpbHRpbl91bnJlYWNoYWJsZSgpOworICBpZiAo biA9PSA2KQorICAgIF9fYnVpbHRpbl91bnJlYWNoYWJsZSgpOworICBpZiAobiA9PSA3KQorICAg IF9fYnVpbHRpbl91bnJlYWNoYWJsZSgpOworIGlmIChuIDw4KQorICAgZGVhZCAobik7CisgaWYg KG4gIT0gbSkKKyAgICBfX2J1aWx0aW5fdW5yZWFjaGFibGUoKTsKKyBhbGl2ZSAobik7CisgYWxp dmUgKG0pOworfQorCisvKiB7IGRnLWZpbmFsIHsgc2Nhbi10cmVlLWR1bXAtbm90ICJkZWFkIiAi dnJwMSIgfSB9ICovCisvKiB7IGRnLWZpbmFsIHsgc2Nhbi10cmVlLWR1bXAtdGltZXMgImJ1aWx0 aW5fdW5yZWFjaGFibGUiIDEgInZycDEiIH0gfSAqLworLyogeyBkZy1maW5hbCB7IHNjYW4tdHJl ZS1kdW1wLW5vdCAiYnVpbHRpbl91bnJlYWNoYWJsZSIgInZycDIiIH0gfSAqLworLyogeyBkZy1m aW5hbCB7IHNjYW4tdHJlZS1kdW1wLXRpbWVzICJmZmY4IiA0ICJ2cnAyIiB9IH0gKi8K --------------YaHaU4OJiPCx3q0ZOVgK0sVw--