From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2081.outbound.protection.outlook.com [40.107.20.81]) by sourceware.org (Postfix) with ESMTPS id E419D3858C31 for ; Wed, 13 Mar 2024 12:37:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E419D3858C31 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E419D3858C31 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.20.81 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1710333465; cv=pass; b=qPi2k82ub4FbAM1Za5M4gRETAOm7JGFCIhRTPL5SGJosvF1RA8r+Aij65qzBVhCrE6r3iGkqy0wVuCGCWB898wi/qDHFb1dyPUR/X+6kM957jd3OoYuaFCIiIzywopjTv4QO/hbkudUCIb3vrWQqkVYClZP9PpBybQeGOMxrtfU= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1710333465; c=relaxed/simple; bh=GXdcjb9eenfJiJVbu4Ril1G29f2qeJH9bdAcKNyiFf0=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=vZJZR9jXZba8FzzKq/61wzzdlpMTwW8Ru6CKfqY2MTvSLacpSKQPLpfzjYwyy0CKwZIZOdhTKJhUjesstyNS9ARL9F57Mym5Hc+/OfwL6jN424oRw2Hzemxv5u/IqVSCSQQP7EkRsKn55NxUz3yvZ2AiJqKzmFjwV58Wq/rDlnk= ARC-Authentication-Results: i=3; server2.sourceware.org ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=QmvHQE3m7eYFWh9u2L6r1kqgkhb8/ik1fwRmAN/S7KnTwAtxVUmCEg69h4x1RsNXHqBplmvZ+sE1PNOfjCQA3DCGscSUAEV28OLBqCnnu5+Qfjcqjfml8yoodvjypU0tdgIsddmBx3g1kZ9vIRs76yQQH64Iw0Nod89Sa2wVSbmn8eVxp3ZFDx/qRvlJccVJNsM4VGG4YtuYoRWcWkNgUDWP5ioaYH5mehmm5aEfn18o4Dy5h0r+/+40bZhohMqIJtEqypxX+jQY67JEb7dS43AaEHfn5qDfhIyIyYLzX6EnTW9OvWZPVy6Z1XUEEGXDLDHNpgpOM0aJKvc9Lo9cLA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uy6Q/hbSdFjV9/sYm7ArGJLp1AE1YXufDw+O0fK/j4o=; b=iIgfo5x5UcFWD+/SVljJr+A6rakAeEuN5Eta61TpP4rnI85FeuQ7o/20G7i05jMKgpK3qRBOCOTh6luYKuhtShCqcun8l/yVqU0DEvH28xmdEqxUFNs/9gmw0LJ/KQarP/LbX4EmyYKliOdeRy2l0YAvOh5RjJ91yDG+YX9GcctdLt2qQg/TIi4xudyswm1EBVPRSfXx487PISfa5qd84im6MQK53DFUhL561Sl0lCo+ApLKUDOMNCrZAr13mqu+hh4eoz4bedGhFvf9ZNVE+IKdP7yTh7eeVHQbJjbn39WkBGt4wyPy3ZyWyB72iFuACDi1BGdNeK4kmuQCU/3k9g== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=gcc.gnu.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uy6Q/hbSdFjV9/sYm7ArGJLp1AE1YXufDw+O0fK/j4o=; b=7WDlFyJx5FypXlArGf0QGlLgc9w2cH8ocEJi6YyIQud8yj9jUiGug+DoDbqeORw9R++I2wPNgjCQmrn9Tt7Wpj+jjnMyRe20cA4jOsAZXv1no3NFbo7eoHGkUeHPjYarAzwniWxi5ucPjWMoRcLaCI+kw0iTJM/M+swkWP5glQA= Received: from DB8PR06CA0038.eurprd06.prod.outlook.com (2603:10a6:10:120::12) by DU5PR08MB10704.eurprd08.prod.outlook.com (2603:10a6:10:521::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.36; Wed, 13 Mar 2024 12:37:39 +0000 Received: from DB5PEPF00014B8F.eurprd02.prod.outlook.com (2603:10a6:10:120:cafe::39) by DB8PR06CA0038.outlook.office365.com (2603:10a6:10:120::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.19 via Frontend Transport; Wed, 13 Mar 2024 12:37:39 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5PEPF00014B8F.mail.protection.outlook.com (10.167.8.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.12 via Frontend Transport; Wed, 13 Mar 2024 12:37:38 +0000 Received: ("Tessian outbound 5180408f3322:v276"); Wed, 13 Mar 2024 12:37:38 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 4161e63f29abdf6c X-CR-MTA-TID: 64aa7808 Received: from b247103ed69e.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7352D7A7-D28C-46AE-A2D5-E8C9DCE78F29.1; Wed, 13 Mar 2024 12:37:32 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b247103ed69e.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 13 Mar 2024 12:37:32 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kFL7F/I2vTu5eYCxnSmaBeo/3qq7vtIHgkd54Tnk4ymhSxtb9IKbvTG15FNqvHyY0gusf2hOFWQruFtIrXOAL5Wwga7hKYIhOalfkD8+Y/QFs7PfuS4MYEaf84fv5qAPGR1rp1eKLBfRDEEFUzNAlcsueRpShogroHASkZlL9cCEliOmeP5wBbqAnjvYbaTyCfPfAUANJRaUr7RHn12DKZW60rFBaecrT8Z2J7QLyPavj2ufbmuKQ001sz0/l3VX8Xq6LBUHtkAK9HlMphGjURt2mvQGS0Geeclp0P7OfQUq7JhGITkWEpFXvzaou83WjuijlZq+lX/7aAWxOfZzVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uy6Q/hbSdFjV9/sYm7ArGJLp1AE1YXufDw+O0fK/j4o=; b=d0Z6AB6vUeAEB1irBiw5/q65jfRFJ6A0Jwe5MRkg0OjGiaHTSXNjXHQiIQKGQMkXqBHaMpYRGfUIWlOarMaM8vepY+9Bez2o0VbaDh8/ry99laptTpdQ7ELZ6bYycOImXL+dd+gtvpVakjYrnOYxvwFqwarjO0r55CIrLmFGWwiWSsglmHuuZBc0dF3oqN0937ID6w36BwX4D+WZMMM39r+ttrbGfUotvYT7q0zN5GuYQbjMzNmbp8IaH4BhdMm11SOquDBgxu9MpAjQv6DX47wCRtn6cFmRdYBsMrKpGkQH5vj/m7ZyyQ9JDADTvD7DdGvZRPQCLPGrkHNhmhjKwQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uy6Q/hbSdFjV9/sYm7ArGJLp1AE1YXufDw+O0fK/j4o=; b=7WDlFyJx5FypXlArGf0QGlLgc9w2cH8ocEJi6YyIQud8yj9jUiGug+DoDbqeORw9R++I2wPNgjCQmrn9Tt7Wpj+jjnMyRe20cA4jOsAZXv1no3NFbo7eoHGkUeHPjYarAzwniWxi5ucPjWMoRcLaCI+kw0iTJM/M+swkWP5glQA= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB7079.eurprd08.prod.outlook.com (2603:10a6:20b:400::12) by AM9PR08MB6273.eurprd08.prod.outlook.com (2603:10a6:20b:2d7::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.19; Wed, 13 Mar 2024 12:37:30 +0000 Received: from AS8PR08MB7079.eurprd08.prod.outlook.com ([fe80::8b91:4189:f3ad:dd2a]) by AS8PR08MB7079.eurprd08.prod.outlook.com ([fe80::8b91:4189:f3ad:dd2a%3]) with mapi id 15.20.7386.017; Wed, 13 Mar 2024 12:37:29 +0000 Message-ID: <101360c8-863f-4953-97d0-c8467b207de5@arm.com> Date: Wed, 13 Mar 2024 18:07:25 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] vect: Call vect_convert_output with the right vecitype [PR114108] To: gcc-patches@gcc.gnu.org Cc: richard.sandiford@arm.com References: <20240307104400.1970528-1-tejas.belagod@arm.com> Content-Language: en-US From: Tejas Belagod In-Reply-To: <20240307104400.1970528-1-tejas.belagod@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PN2PR01CA0140.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:6::25) To AS8PR08MB7079.eurprd08.prod.outlook.com (2603:10a6:20b:400::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB7079:EE_|AM9PR08MB6273:EE_|DB5PEPF00014B8F:EE_|DU5PR08MB10704:EE_ X-MS-Office365-Filtering-Correlation-Id: deafd5e0-7cdf-4b26-818a-08dc435a5e65 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: L/X7Xz4Qcc1tcyz1V/GoCpiAWecAEd2i8wqsv7fNCUmxMs3/lYFUPdd/WsUXvNc1rRA8592KN7aoQMJvzsNZ1LjpU7vfuUbUCHWxQp+ZS7DJl4x5Y2bwr/QEC3P7NDK6fvHNy/VO35WvGE2hcaQjF6eIfTLxsoitSw/oSXVYDSmVI5VZ7+cAfXUsLtS44zP1uzr/0pPlBpz2FvZUZP/1AqyylAa1oA1DUOAGpr0ygn3rCkAeHK/cmtNqONWwCXY+dN8QriB5OkmRZPX8Gt+yDk3yOVNlenoJn7ru6gnLkztuogDPFgjZhSyTCFc5I7NPUvJr5H7E3bH3cgoZhXL8TTS24WtscdtbdVHQhDHn4En7B1o2McaZ603vZ5+Aph/BVN7GR+YYZrK6JUBIqWHXbVeuBzG80Ad15HkG5b86HUVgeOZR6JGQ8PcvJbxJuFUEczOaIhDEJYNwe6ZAQrmZOk9POBPnFyGFvO34/7tBsLscs8MQLgc4ia46ShuPXCdTnyI3a/XhykFxfVb++9Z1bohDJRcGHyZsuj0ZFPfaAOt+2KCylpu4kXK8bCz1FRD6G2EKdNn9cLnDKYK2o17RQav8cnqJpPsjrIL1rc3QF+s= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7079.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(1800799015);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6273 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5PEPF00014B8F.eurprd02.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 411acf17-0c54-40e4-9d54-08dc435a58d3 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: j+NPV6Uh/V6TiklNugeI2l/YIW0M2Xtc2pkg8xM868KweFwyPSn6m7CiyF2MoFQXMe9lqH6avQT9yC/j6HKC3yqJfahj/VIABj217khpaQzBJe+rrBs09fWFrrI1YIjVXoTHMChgbeus/FZ9wSnwnEORF2Ns/a0AtusDZbrQQwBRxVY0Wq+/r3PMgqeGJzFkoQNd0Ch/CFKaowkZ/Z8bJACLx4Wsjf7y5FLyJfsIRqxdDpHLwsA87QSiM6YuJVETYzStqvYAO+miKjGnOiw++FK8+o2zSnP61iou98FNxpTGV1BzBiVdjEdoTiaSviKmdgAQDuvs3y7MmPytj1MC3wscM7MLH+4DwuMIPl/O3YaOObIf4W8R7ODQlsaBrGIy2zFzdp5ir7CAbvaC0l1nOEXAAgT8InB6nYuufX+MSq+6F54x7DCzJuGW2vyp2Raa54+Ke8iN2lHdLY/kR4ZJc0HR8vQ7pbDDnw1bIJ7H/KOahgz2aO0faYt3rZUPnab2ohhhk3sL5q4T9Lzil041J6E7V0io/xCEvaGPPBJouiWKOf1IxzXHr3pJJX67bNx7KrNfjI9JtfI+398CroV/hnBX/GY0MqHCDageuhJ8PZegupJfcC6O3EZ+LcMTt/zPpPjYD2Hkoun0Xl+TbIJ7Dwq4hb8HRnkr1eoP12MBG91jqH0DvVp7f1lhZBr5n59kH21PItADgAs78ghWETtunQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230031)(376005)(82310400014)(36860700004)(1800799015);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2024 12:37:38.9596 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: deafd5e0-7cdf-4b26-818a-08dc435a5e65 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5PEPF00014B8F.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU5PR08MB10704 X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,GIT_PATCH_0,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Ping! On 3/7/24 4:14 PM, Tejas Belagod wrote: > This patch fixes a bug where vect_recog_abd_pattern called vect_convert_output > with the incorrect vecitype for the corresponding pattern_stmt. > vect_convert_output expects vecitype to be the vector form of the scalar type > of the LHS of pattern_stmt, but we were passing in the vector form of the LHS > of the new impending conversion statement. This caused a skew in ABD's > pattern_stmt having the vectype of the following gimple pattern_stmt. > > 2024-03-06 Tejas Belagod > > gcc/ChangeLog: > > PR middle-end/114108 > * tree-vect-patterns.cc (vect_recog_abd_pattern): Call > vect_convert_output with the correct vecitype. > > gcc/testsuite/ChangeLog: > * gcc.dg/vect/pr114108.c: New test. > --- > gcc/testsuite/gcc.dg/vect/pr114108.c | 19 +++++++++++++++++++ > gcc/tree-vect-patterns.cc | 5 ++--- > 2 files changed, 21 insertions(+), 3 deletions(-) > create mode 100644 gcc/testsuite/gcc.dg/vect/pr114108.c > > diff --git a/gcc/testsuite/gcc.dg/vect/pr114108.c b/gcc/testsuite/gcc.dg/vect/pr114108.c > new file mode 100644 > index 00000000000..b3075d41398 > --- /dev/null > +++ b/gcc/testsuite/gcc.dg/vect/pr114108.c > @@ -0,0 +1,19 @@ > +/* { dg-do compile } */ > + > +#include "tree-vect.h" > + > +typedef signed char schar; > + > +__attribute__((noipa, noinline, optimize("O3"))) > +void foo(const schar *a, const schar *b, schar *c, int n) > +{ > + for (int i = 0; i < n; i++) > + { > + unsigned u = __builtin_abs (a[i] - b[i]); > + c[i] = u <= 7U ? u : 7U; > + } > +} > + > + > +/* { dg-final { scan-tree-dump "LOOP VECTORIZED" "vect" { target aarch64*-*-* } } } */ > +/* { dg-final { scan-tree-dump "vect_recog_abd_pattern: detected" "vect" { target aarch64*-*-* } } } */ > diff --git a/gcc/tree-vect-patterns.cc b/gcc/tree-vect-patterns.cc > index d562f57920f..4f491c6b833 100644 > --- a/gcc/tree-vect-patterns.cc > +++ b/gcc/tree-vect-patterns.cc > @@ -1576,9 +1576,8 @@ vect_recog_abd_pattern (vec_info *vinfo, > && !TYPE_UNSIGNED (abd_out_type)) > { > tree unsign = unsigned_type_for (abd_out_type); > - tree unsign_vectype = get_vectype_for_scalar_type (vinfo, unsign); > - stmt = vect_convert_output (vinfo, stmt_vinfo, unsign, stmt, > - unsign_vectype); > + stmt = vect_convert_output (vinfo, stmt_vinfo, unsign, stmt, vectype_out); > + vectype_out = get_vectype_for_scalar_type (vinfo, unsign); > } > > return vect_convert_output (vinfo, stmt_vinfo, out_type, stmt, vectype_out);