From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by sourceware.org (Postfix) with ESMTPS id 82E313858D32 for ; Mon, 26 Sep 2022 11:12:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 82E313858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-wr1-x42d.google.com with SMTP id c11so9615329wrp.11 for ; Mon, 26 Sep 2022 04:12:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=yE6SQY5ziijOjzQF/ob8wbblXsOYkccodEjL6ump8U4=; b=jD0+kAoDZuhWQSxnLsc62snRiMzIaw3ui1wVOLLcIb0N6BF2+px+CC9/Wk7mf0WJ47 5Rm/Bkz0s+UeFTEb2OMKZK/2SVqMn/EZ8CbFV/VkabRhbtdWfmRpT3Fy79OmkJE1UshK 6ZAId/eC0/xTmWZqjxpeM14xczGUJamGlbOKJKEOlG6sPEnJSDXCUbWnTDSRM1W6hXbZ BCsg+do0XzC1iwcm3KMHN80xVUEilgErqH79oByutU9hU+48AA6qrTd92tAOI+osGkHV ltJ8RjsKF6kb7YBXVxLHzodyiUSXxuflYDKbIMBd3MubddueqJGICfuz9q8ieoF1rFAH oNnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=yE6SQY5ziijOjzQF/ob8wbblXsOYkccodEjL6ump8U4=; b=ddhDyWnV+/M/pOs9YPv3WY82X6gVkp9G3IsJBOcUfKHlLh+nfyFykCv/bFvA74ySPO 1Oycwyzr+BmEmfV6em/zhkFY1QXZF9uWVXleldxGIQcfuF12xurp75HtD8Xd8gVr2IBq RLQfyT86RuSuZGJcLJp973K259Vkvt/Sun45V+bKr4z3zvH9iMLrQKfbUL0TMWW5ZRye eN/hH6+NCUWBdy0pa3fV6TN0adw+i4YS3skGrO96QJG6/yBTv0cDe/0KLP5kExXE7VWg 0GyV0JN30k7UkiW7lS+H7ToJp+PwvGLujrW1Kgv5uDEVJ7NdDmUqgRQX+pW22ucW1kvm dK9A== X-Gm-Message-State: ACrzQf3Bur62JI5IO92IIIJRgKczs1ouRAAg/RHyS1K4zowZVl8tXSsr msyPpKyBYXbTY3VbN9u/ppBsKQ== X-Google-Smtp-Source: AMsMyM57zaWIb3uwSBINyXsiCtJZwsYEJCEy0SbYKcWtWVxtODxSJM8usQhgcM4RvR5vv4HAjD0mRQ== X-Received: by 2002:adf:fe08:0:b0:22b:311:afcd with SMTP id n8-20020adffe08000000b0022b0311afcdmr13113528wrr.629.1664190737410; Mon, 26 Sep 2022 04:12:17 -0700 (PDT) Received: from fomalhaut.localnet ([2a01:e0a:8d5:d990:e654:e8ff:fe8f:2ce6]) by smtp.gmail.com with ESMTPSA id o3-20020a05600c4fc300b003a5ca627333sm11060285wmq.8.2022.09.26.04.12.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Sep 2022 04:12:16 -0700 (PDT) From: Eric Botcazou X-Google-Original-From: Eric Botcazou To: Richard Biener Cc: gcc-patches@gcc.gnu.org, nd@arm.com, gcc-patches@gcc.gnu.org Subject: Re: [PATCH]middle-end fix floating out of constants in conditionals Date: Mon, 26 Sep 2022 13:12:16 +0200 Message-ID: <10150741.nUPlyArG6x@fomalhaut> In-Reply-To: <3197460.44csPzL39Z@fomalhaut> References: <3197460.44csPzL39Z@fomalhaut> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Before my change we had always done the folding *only* for TREE_CONSTANT > (arg) and my change allowed it for some cases of !TREE_CONSTANT (arg), but > I did not want to touch the !TREE_CONSTANT (arg) case at all: ...to touch the TREE_CONSTANT (arg) case at all... -- Eric Botcazou