public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeff Law <jeffreyalaw@gmail.com>
To: Edwin Lu <ewlu@rivosinc.com>, gcc-patches@gcc.gnu.org
Cc: gnu-toolchain@rivosinc.com
Subject: Re: [RFC] RISC-V: Handle new types in scheduling descriptions
Date: Tue, 10 Oct 2023 11:11:12 -0600	[thread overview]
Message-ID: <101c89cb-df98-4e12-be41-5c20870b6d7d@gmail.com> (raw)
In-Reply-To: <20231009210250.947831-1-ewlu@rivosinc.com>



On 10/9/23 15:02, Edwin Lu wrote:
> Now that every insn is guaranteed a type, we want to ensure the types are
> handled by the existing scheduling descriptions.
> 
> There are 2 approaches I see:
> 1. Create a new pipeline intended to eventually abort (sifive-7.md)
> 2. Add the types to an existing pipeline (generic.md)
> 
> Which approach do we want to go with? If there is a different approach we
> want to take instead, please let me know as well.
> 
> Additionally, should types associated with specific extensions
> (vector, crypto, etc) have specific pipelines dedicated to them?
> 
> 	* config/riscv/generic.md: update pipeline
> 	* config/riscv/sifive-7.md (sifive_7): update pipeline
> 	(sifive_7_other):
I'd largely expect that we look at an unhandled type and first look to 
see if its properties roughly fit into an existing define_insn_unit.  If 
so, just add it to the existing unit.  Otherwise we end up needing to 
create another unit.

What would be really interesting would be to see if we can get the 
scheduler to indicate that it's trying to schedule an insn that doesn't 
have a reservation.    ie, our backend tells us if we have an insn with 
no type, the next step is to see if we have a type with no 
units/reservations.


Jeff

  reply	other threads:[~2023-10-10 17:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-09 21:02 Edwin Lu
2023-10-10 17:11 ` Jeff Law [this message]
2023-10-10 21:18   ` Edwin Lu
2023-10-10 21:18     ` Edwin Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=101c89cb-df98-4e12-be41-5c20870b6d7d@gmail.com \
    --to=jeffreyalaw@gmail.com \
    --cc=ewlu@rivosinc.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gnu-toolchain@rivosinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).